Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <008d3e20-2c6b-c3f1-3fd3-ef4ef4dd061e@linaro.org>
Date:   Mon, 12 Dec 2022 19:11:17 -0600
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: [PATCH net-next 2/2] net: ipa: add IPA v4.7 support
Content-Language: en-US
To:     Jakub Kicinski <kuba@kernel.org>,
        Konrad Dybcio <konrad.dybcio@linaro.org>
Cc:     Alex Elder <elder@linaro.org>, davem@davemloft.net,
        edumazet@google.com, pabeni@redhat.com, andersson@kernel.org,
        agross@kernel.org, robh+dt@kernel.org,
        krzysztof.kozlowski+dt@linaro.org, elder@kernel.org,
        linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        Luca Weiss <luca.weiss@fairphone.com>
References: <20221208211529.757669-1-elder@linaro.org>
 <20221208211529.757669-3-elder@linaro.org>
 <47b2fb29-1c2e-db6e-b14f-6dfe90341825@linaro.org>
 <fa6d342e-0cfe-b870-b044-b0af476e3905@linaro.org>
 <48bef9dd-b71c-b6aa-e853-1cf821e88b50@linaro.org>
 <20221212155450.34fdae6b@kernel.org>
From:   Alex Elder <alex.elder@linaro.org>
In-Reply-To: <20221212155450.34fdae6b@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/12/22 5:54 PM, Jakub Kicinski wrote:
>>> which in total gives us 0x146a8000-0x146aafff
>> Can you tell me where you found this information?
> [1], [2]
> 
>>    
>>> That would also mean all of your writes are kind of skewed, unless
>>> you already applied some offsets to them.
>> This region is used by the modem, but must be set up
>> by the AP.
>>    
>>> (IMEM on 6350 starts at 0x14680000 and is 0x2e000 long, as per
>>> the bootloader memory map)
>> On SM7250 (sorry, I don't know about 7225, or 6350 for that matter),
>> the IMEM starts at 0x14680000 and has length 0x2c000.  However that
>> memory is used by multiple entities.  The portion set aside for IPA
>> starts at 0x146a9000 and has size 0x2000.

This is awesome, thank you!

Yes I think there are a couple of minor corrections to make
but I haven't had the time to go do the research yet, so
hadn't yet responded.

Nothing is "supported" upstream anyway until there's a
system with a DTS that uses it, and that won't happen
until after the end of the merge window.

Again, thank you very much, it's a safe thing to take
for now.

					-Alex