Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <46c1f014-7c3f-88c4-d576-7b6bd5e1590d@quicinc.com>
Date:   Mon, 12 Dec 2022 17:35:58 -0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.6.2
Subject: Re: [Freedreno] [PATCH] drm/msm/hdm: Fix the error handling path of
 msm_hdmi_dev_probe()
Content-Language: en-US
From:   Abhinav Kumar <quic_abhinavk@quicinc.com>
To:     Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Rob Clark <robdclark@gmail.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@gmail.com>,
        Daniel Vetter <daniel@ffwll.ch>
CC:     <linux-arm-msm@vger.kernel.org>, <freedreno@lists.freedesktop.org>,
        <kernel-janitors@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>
References: <b3d9dac978f1e2e42a40ec61f58aa98c44c85dfd.1670741386.git.christophe.jaillet@wanadoo.fr>
 <b34374ed-0444-6bd9-4994-7f890455b451@quicinc.com>
In-Reply-To: <b34374ed-0444-6bd9-4994-7f890455b451@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 12/12/2022 5:34 PM, Abhinav Kumar wrote:
> 
> 
> On 12/10/2022 10:50 PM, Christophe JAILLET wrote:
>> If an error occurs after a successful msm_hdmi_get_phy() call, it must be
>> undone by a corresponding msm_hdmi_put_phy(), as already done in the
>> remove function.
>>
>> Fixes: 437365464043 ("drm/msm/hdmi: move msm_hdmi_get_phy() to 
>> msm_hdmi_dev_probe()")
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>

Actually, i missed one nit

In the subject line, it should be "drm/msm/hdmi"

The "i" is missing.

Please fix that and post it.

> 
>> ---
>> Not sure if the Fixes tag is correct. At least it is when the probe needs
>> to be fixed but the issue was maybe there elsewhere before.
> 
> Seems right to me.
> 
>> ---
>>   drivers/gpu/drm/msm/hdmi/hdmi.c | 12 ++++++++++--
>>   1 file changed, 10 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/hdmi/hdmi.c 
>> b/drivers/gpu/drm/msm/hdmi/hdmi.c
>> index 4d3fdc806bef..97372bb241d8 100644
>> --- a/drivers/gpu/drm/msm/hdmi/hdmi.c
>> +++ b/drivers/gpu/drm/msm/hdmi/hdmi.c
>> @@ -532,11 +532,19 @@ static int msm_hdmi_dev_probe(struct 
>> platform_device *pdev)
>>       ret = devm_pm_runtime_enable(&pdev->dev);
>>       if (ret)
>> -        return ret;
>> +        goto err_put_phy;
>>       platform_set_drvdata(pdev, hdmi);
>> -    return component_add(&pdev->dev, &msm_hdmi_ops);
>> +    ret = component_add(&pdev->dev, &msm_hdmi_ops);
>> +    if (ret)
>> +        goto err_put_phy;
>> +
>> +    return 0;
>> +
>> +err_put_phy:
>> +    msm_hdmi_put_phy(hdmi);
>> +    return ret;
>>   }
>>   static int msm_hdmi_dev_remove(struct platform_device *pdev)