Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp7726042rwb; Mon, 12 Dec 2022 19:33:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Dq7PdMQ5nUngjTTkl811Ext3oXIVaxk8JkI4k3XWFQus0aUaH7xEgUx3xnZXuWz2pFQbL X-Received: by 2002:a17:907:29d2:b0:7c1:98d:a8a3 with SMTP id ev18-20020a17090729d200b007c1098da8a3mr9482484ejc.7.1670902417531; Mon, 12 Dec 2022 19:33:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670902417; cv=none; d=google.com; s=arc-20160816; b=e7N+6SPvTVwwfL+EFZKvCLuow5r1FIbqz19I3wY+6mF7QWjSULiorb8SfQwL7kXjl1 iZs5VU12TQmvuVt1fNyjkTDwaOyVf2EGvyqNS8lchkBdDUcdAW40Xhcoq/KessdkQxGi nAKHikM22XLHUfqNHx1TAo/c6+t4oOtJI5EcxPqwbe5JNGJYM7xmNAHGQbxVWJ/ZplYi r0RNu2y3aVpg8hhsNI0ExhI+jZBDtZMsHbnYVR8un0J0e+BvbANbzppqp0Q2qtDzDRVC J0BdYUtYkbVTRVCGLM+cJl4QQDRxLA4BTA75kGI1PXjf/SG6oQxt9YLW8RrI4CQm1us+ OtOg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=HpZ9jX3u4847/+62/XiO19y9qAcrk3g+ILqUmJpDZtY=; b=pWP7ZAQ4wIE4mQU518DSNyXpbooOYje/mPK8Yi6873509bKmSQN2aFuu1sw9DJuEa7 Y/NLsJYTsdcnVze3PqAj6YoZaEfEGVIHRumYsm9hP0xk+ZDNI/39yQUa9hw63w1CkbLz bINZT0VEXt0Gu/rz5Yj//nB6vGcMtRMntV/SokELNTY4beMvBZBpqeTNsGDEPa99cLpD M/5FCr9205jkaLWzdr5MLgsuejNLNvshDn8IX5qoOm6AUZKepnBN+Kxl1NUwj7fQobbo P1ZQ84krHKfoDl2mWs5jNS+uTs0QJSapHJy1vMNL6ONuvawoxhZ7oF5TQdawhT3LbPSl xqaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="veZwu5/E"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id qw38-20020a1709066a2600b007ae26c753edsi8597593ejc.52.2022.12.12.19.33.18; Mon, 12 Dec 2022 19:33:37 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="veZwu5/E"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233933AbiLMC6m (ORCPT + 74 others); Mon, 12 Dec 2022 21:58:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233100AbiLMC6j (ORCPT ); Mon, 12 Dec 2022 21:58:39 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18256140B8; Mon, 12 Dec 2022 18:58:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HpZ9jX3u4847/+62/XiO19y9qAcrk3g+ILqUmJpDZtY=; b=veZwu5/Eb8m4aS4Crkb0P1/wsj YwFyUxJIwfc2OqEiXDFLmJA8cFBdMJqRuNev+HB8RKnzra5xMT6eJLcEZ6eePLlqpzWZ2xsld4jal 5fqZn1xhl9wrhVl231xMS0ycXCdwNfpPVOC93J/d9cQBUix9ODwvoOkpo4az+hEolyTZtToMVojY6 pq0mJHfJAAfaaHdcnwMkuptqDPF3k0YGBnPBwGoK/+i6GP5BORIkaTZjCAyaidOU7IWUE6UvEz+Q/ c81Lk0bOtzmThZITeObp4DSLwpdT+A69GP1S4aNYrv9MP+pEtDwCzEpLagcIbveKniTxAKwALLzSl 9Spt2ozw==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p4vV5-00A3qb-71; Tue, 13 Dec 2022 02:58:35 +0000 Date: Mon, 12 Dec 2022 18:58:35 -0800 From: Luis Chamberlain To: Petr Pavlu Cc: david@redhat.com, Petr Mladek , prarit@redhat.com, mwilck@suse.com, linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] module: Don't wait for GOING modules Message-ID: References: <20221205103557.18363-1-petr.pavlu@suse.com> <0017c9ce-7e92-6010-7bc9-716131a25ec5@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0017c9ce-7e92-6010-7bc9-716131a25ec5@suse.com> Sender: Luis Chamberlain X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 12, 2022 at 12:29:02PM +0100, Petr Pavlu wrote: > On 12/8/22 03:44, Luis Chamberlain wrote: > > On Wed, Dec 07, 2022 at 04:15:21PM +0100, Petr Mladek wrote: > >> Reviewed-by: Petr Mladek > > > > Queued onto modules-next. > > Thanks both. I'm **terribly sorry** for dropping this to Linus' pull request late but I kept trying to justify a few things and I couldn't do it, and so I'll reply to this patch with my last minute observations soon. I figured it was better to be safe than sorry and the potential for yet *more* regressions was *real* and I really wanted to avoid us having to crunch / race for a fix over the holidays. I will leave the fix as-is now in modules-next though, so it can get more testing, but indeed, I don't feel quite ready for the masses specially before the holidays. Luis