Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764097AbXHNWOZ (ORCPT ); Tue, 14 Aug 2007 18:14:25 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S935871AbXHNV4j (ORCPT ); Tue, 14 Aug 2007 17:56:39 -0400 Received: from netops-testserver-4-out.sgi.com ([192.48.171.29]:36880 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755107AbXHNV4h (ORCPT ); Tue, 14 Aug 2007 17:56:37 -0400 Date: Tue, 14 Aug 2007 14:56:35 -0700 (PDT) From: Christoph Lameter X-X-Sender: clameter@schroedinger.engr.sgi.com To: Lee Schermerhorn cc: "Serge E. Hallyn" , Dhaval Giani , bob.picco@hp.com, nacc@us.ibm.com, kamezawa.hiroyu@jp.fujitsu.com, mel@skynet.ie, akpm@linux-foundation.org, Balbir Singh , Srivatsa Vaddagiri , lkml , ckrm-tech Subject: Re: Regression in 2.6.23-rc2-mm2, mounting cpusets causes a hang In-Reply-To: <1187127685.6281.139.camel@localhost> Message-ID: References: <20070812152126.GA26239@linux.vnet.ibm.com> <20070813201215.GA16908@vino.hallyn.com> <1187103831.6281.24.camel@localhost> <20070814180339.GA32553@vino.hallyn.com> <1187115224.6281.40.camel@localhost> <20070814192306.GB32553@vino.hallyn.com> <20070814204951.GA2065@vino.hallyn.com> <1187127685.6281.139.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 33 On Tue, 14 Aug 2007, Lee Schermerhorn wrote: > > Ok then you did not have a NUMA system configured. So its okay for the > > dummies to ignore the stuff. CONFIG_NODES_SHIFT is a constant and does not > > change. The first bit is always set. > > The first bit [node 0] is only set for the N_ONLINE [and N_POSSIBLE] > mask. We could add the static init for the other masks, but since > non-numa platforms are going through the __build_all_zonelists, they > might as well set the MEMORY bits explicitly. Or, maybe you'll > disagree ;-). The bitmaps can be completely ignored if !NUMA. In the non NUMA case we define static inline int node_state(int node, enum node_states state) { return node == 0; } So its always true for node 0. The "bit" is set. We are trying to get cpusets to work with !NUMA? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/