Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 08:35:45 +0100
From:   Horatiu Vultur <horatiu.vultur@microchip.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     <linux-arm-kernel@lists.infradead.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <davem@davemloft.net>,
        <edumazet@google.com>, <pabeni@redhat.com>,
        <Steen.Hegelund@microchip.com>, <daniel.machon@microchip.com>,
        <lars.povlsen@microchip.com>, <UNGLinuxDriver@microchip.com>,
        kernel test robot <lkp@intel.com>,
        "Dan Carpenter" <error27@gmail.com>
Subject: Re: [PATCH net-next] net: microchip: vcap: Fix initialization of
 value and mask
Message-ID: <20221213073545.vuel5l6k7cej6xk6@soft-dev3-1>
References: <20221209120701.218937-1-horatiu.vultur@microchip.com>
 <20221212130224.19bf695f@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <20221212130224.19bf695f@kernel.org>
Precedence: bulk

The 12/12/2022 13:02, Jakub Kicinski wrote:
> 
> On Fri, 9 Dec 2022 13:07:01 +0100 Horatiu Vultur wrote:
> >       case VCAP_FIELD_U128:
> > +             value = data->u128.value;
> > +             mask = data->u128.value;
> 
> If setting both to value is intentional - please mention in the commit
> message. Otherwise this looks odd.

It should not be both set to value. Will fix this in th next version.

-- 
/Horatiu