Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 09:50:57 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Klaus Jensen <its@irrelevant.dk>
Cc:     linux-nvme@lists.infradead.org, Christoph Hellwig <hch@lst.de>,
        Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
        Sagi Grimberg <sagi@grimberg.me>, linux-kernel@vger.kernel.org,
        Klaus Jensen <k.jensen@samsung.com>,
        Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] nvme-pci: fix doorbell buffer value endianness
Message-ID: <20221213085057.GA3998@lst.de>
References: <20221212150243.41283-1-its@irrelevant.dk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221212150243.41283-1-its@irrelevant.dk>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Mon, Dec 12, 2022 at 04:02:43PM +0100, Klaus Jensen wrote:
> -		old_value = *dbbuf_db;
> -		*dbbuf_db = value;
> +		old_value = le32_to_cpu(*dbbuf_db);
> +		*dbbuf_db = cpu_to_le32(value);

As the buildbot noticed, this now means dbbuf_dbs needs to be
a __le32, and the endianess annoations will have to wee through
quite a few places.