Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: idc91472f:Fastmail
Date:   Tue, 13 Dec 2022 09:52:18 +0100
From:   Klaus Jensen <its@irrelevant.dk>
To:     Christoph Hellwig <hch@lst.de>
Cc:     linux-nvme@lists.infradead.org, Keith Busch <kbusch@kernel.org>,
        Jens Axboe <axboe@fb.com>, Sagi Grimberg <sagi@grimberg.me>,
        linux-kernel@vger.kernel.org, Klaus Jensen <k.jensen@samsung.com>,
        Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] nvme-pci: fix doorbell buffer value endianness
Message-ID: <Y5g9QhH1asYdXpZx@cormorant.local>
References: <20221212150243.41283-1-its@irrelevant.dk>
 <20221213085057.GA3998@lst.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="f6KDFeo6ijDRncdJ"
Content-Disposition: inline
In-Reply-To: <20221213085057.GA3998@lst.de>
Precedence: bulk


--f6KDFeo6ijDRncdJ
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Dec 13 09:50, Christoph Hellwig wrote:
> On Mon, Dec 12, 2022 at 04:02:43PM +0100, Klaus Jensen wrote:
> > -		old_value =3D *dbbuf_db;
> > -		*dbbuf_db =3D value;
> > +		old_value =3D le32_to_cpu(*dbbuf_db);
> > +		*dbbuf_db =3D cpu_to_le32(value);
>=20
> As the buildbot noticed, this now means dbbuf_dbs needs to be
> a __le32, and the endianess annoations will have to wee through
> quite a few places.
>=20

Yes, I'll fix it :)

--f6KDFeo6ijDRncdJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmOYPUEACgkQTeGvMW1P
DelZbAgAjUBmJQ3Vwc+bf2H2i5eMeE6lMqnNtytTmRAE7zysG9f6Xj4tHORjniAP
IWfnTH8xqTuD+LY2QoHDb8/VlGwy0v8Jx+l71zScPtetvKJbL4ei7YMi195aQPxP
4kH3UyfWgrKZKZT6zlT1mecyvZqNZDM7ie/syoIRY9p4BaQAibKXhp2Oh8hu3Qkf
y3sUo2tVvoeqqeNbFXbQ+f2IaQViNViB47iT13USIDr2K4q87D/lJMsXBGMDKgxd
sJcpLhfd1X/VnfEPHOef/JgqwV0xNFz/7ETwEeOQD42V2Z1lKbprztIs+UBV9fM8
Hl+26hwhmSe2cBmDfGUlQacynyy/cg==
=UqF1
-----END PGP SIGNATURE-----

--f6KDFeo6ijDRncdJ--