Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8116160rwb; Tue, 13 Dec 2022 02:20:59 -0800 (PST) X-Google-Smtp-Source: AA0mqf5O3jKqQChyK6e5edJ4iDhhtCyY4VQgExHdELkCQi2bO5hZxd3fCoNxGqZsb7ilstcDSUPz X-Received: by 2002:a17:906:e54:b0:7c1:23f7:623a with SMTP id q20-20020a1709060e5400b007c123f7623amr15749072eji.66.1670926859624; Tue, 13 Dec 2022 02:20:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670926859; cv=none; d=google.com; s=arc-20160816; b=nQLCnK7L1OVFYaEnMPykuwYR4Api/LjgW4SKk/u01kJWKfkwcThXu0HeH2SBnmYOfL 6AmNettBmrZmly91KXVQWe9IZ677BipNO1NjaBrxpsGlG5k8/pxqTJHruoKWmwLTIYL1 Km+oUom08JNsJ/W2CZpXXUa/FIhGxqZIP15ijp1pR+mXif9u456/sId4mUCFmqUkvnCM fjOCArizUQq7q+hO9X4eyw95ssDwx/IoxmO0L9d2L8CRm8P3iKlaOZQCQ4NZdevHX3UC 7wNAUT7e8MKYV2Ci5NIQRdBVxnG+78awAAJOe+Bahy67IXy1u93/POVwa5oZ1YueLi9T UMZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=u/7+ZT3pzDLDelBgAUU3yID+krw1lrosVuhNs3QgqHk=; b=lGBid5SZlAu8zOwu0SgQnd4menl+yH4iVzQikwL7KqnaM8jnAM83ey6G8zpXnzOfoi QqtarOwH/POEO6AsLvA4kp7ScFA435lm2dtRh2JgYrmu68x7MMzIjIwDtq/AW6yIv86r AcUgJA/iWhmwHuekC1QGd5t6Hf88hhXa3tZpPZsVCjO23Nuj29/3ZtwzPjkEW8Q44N+P i5ECHQmrNBjQ7rbZGERigkiCxOA1KJ70UmtDGwHSUnmAaij8oVq6O9qADxyT5QV84Sdz zEmTLT4GZAhdTVeYTpGc31sDUoxrwH2JTNlUhyhh2iG3CMNaq2awnUDFjdtnh8K4QGPM VGTw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=uVkClGY1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mp6-20020a1709071b0600b007c0a33b5188si8434861ejc.705.2022.12.13.02.20.40; Tue, 13 Dec 2022 02:20:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=uVkClGY1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235104AbiLMKPO (ORCPT + 74 others); Tue, 13 Dec 2022 05:15:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234753AbiLMKPM (ORCPT ); Tue, 13 Dec 2022 05:15:12 -0500 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.154.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 026061B7AD; Tue, 13 Dec 2022 02:14:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1670926496; x=1702462496; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=Gfjh3ZJpkPC3xWETT6ztzTsldD6PDg4VZwFB/XqjB4k=; b=uVkClGY1+hj2U+jqWNkpVmIVKhNhEEQMzoPZpFK1yfZ+Rmz6EpzFSK61 TwaspXeREpRLheZnstDI6/5gtMeaaWCLbiWJVGheMhyk0EUrpxDnPG/sQ nLpJ2SXnc/K8/2QPLmZH3nIogrKYKq3PiGmPdSuByEK1v33xmcZKWPBvZ 9g7mVM1a+pn/Vst7rdK031H+FVz6SWEdl9Y0VZHdeMbClzXE+8Ug5GFTx DMxPY/WeV2ix3642at8mg2IzwMPaL1BPqlT25vJvCFlVpYzVdfVktV/63 iOr61ZGXXGqLFbo2CKct1BRtRB1go9LK+YIl8yaY+QSxDSPG0zn0my5jN g==; X-IronPort-AV: E=Sophos;i="5.96,241,1665471600"; d="scan'208";a="127869668" Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa6.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Dec 2022 03:14:56 -0700 Received: from chn-vm-ex03.mchp-main.com (10.10.85.151) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Tue, 13 Dec 2022 03:14:56 -0700 Received: from CHE-LT-I17769U.microchip.com (10.10.115.15) by chn-vm-ex03.mchp-main.com (10.10.85.151) with Microsoft SMTP Server id 15.1.2507.16 via Frontend Transport; Tue, 13 Dec 2022 03:14:50 -0700 From: Arun Ramadoss To: , CC: , , , , , , , , , , , , Subject: [Patch net] net: dsa: microchip: remove IRQF_TRIGGER_FALLING in request_threaded_irq Date: Tue, 13 Dec 2022 15:44:40 +0530 Message-ID: <20221213101440.24667-1-arun.ramadoss@microchip.com> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org KSZ swithes used interrupts for detecting the phy link up and down. During registering the interrupt handler, it used IRQF_TRIGGER_FALLING flag. But this flag has to be retrieved from device tree instead of hard coding in the driver, so removing the flag. Fixes: ff319a644829 ("net: dsa: microchip: move interrupt handling logic from lan937x to ksz_common") Reported-by: Christian Eggers Signed-off-by: Arun Ramadoss --- drivers/net/dsa/microchip/ksz_common.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/microchip/ksz_common.c b/drivers/net/dsa/microchip/ksz_common.c index d612181b3226..c68f48cd1ec0 100644 --- a/drivers/net/dsa/microchip/ksz_common.c +++ b/drivers/net/dsa/microchip/ksz_common.c @@ -1883,8 +1883,7 @@ static int ksz_irq_common_setup(struct ksz_device *dev, struct ksz_irq *kirq) irq_create_mapping(kirq->domain, n); ret = request_threaded_irq(kirq->irq_num, NULL, ksz_irq_thread_fn, - IRQF_ONESHOT | IRQF_TRIGGER_FALLING, - kirq->name, kirq); + IRQF_ONESHOT, kirq->name, kirq); if (ret) goto out; base-commit: e095493091e850d5292ad01d8fbf5cde1d89ac53 -- 2.36.1