Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 11:40:43 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Yang Yingliang <yangyingliang@huawei.com>
Cc:     Max Filippov <jcmvbkbc@gmail.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-xtensa@linux-xtensa.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH v1] spi: xtensa-xtfpga: Fix a double put() in
 xtfpga_spi_remove()
Message-ID: <Y5hku6VFhguH2osM@sirena.org.uk>
References: <7946a26c6e53a4158f0f5bad5276d8654fd59415.1670673147.git.christophe.jaillet@wanadoo.fr>
 <CAMo8BfKCv9j-ftKWU+B27g1oHBB_=EZhGBH7qymyVAeF10JcnQ@mail.gmail.com>
 <Y5dKk+uw3UcW2Pu1@sirena.org.uk>
 <bdb26ba3-7276-359a-7784-6ec3e35c64de@huawei.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="mqecs6IEkkZ9zLfG"
Content-Disposition: inline
In-Reply-To: <bdb26ba3-7276-359a-7784-6ec3e35c64de@huawei.com>
Precedence: bulk


--mqecs6IEkkZ9zLfG
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Tue, Dec 13, 2022 at 09:30:32AM +0800, Yang Yingliang wrote:
> On 2022/12/12 23:36, Mark Brown wrote:
> > On Sat, Dec 10, 2022 at 06:48:02AM -0800, Max Filippov wrote:

> > Probably worth a comment though since it is a bit of a gotcha.  Ideally
> > we'd improve this in the bitbang code but that's harder.

> Ideally, spi_bitbang_stop() should undo spi_bitbang_start(). shall we move
> spi_master_put() in spi_bitbang_stop() instead of
> calling it separately in drivers?

Ideally like I say, there's issues with devm IIRC which make it more
complicated than just adding a put() there.

--mqecs6IEkkZ9zLfG
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOYZLsACgkQJNaLcl1U
h9BZPwf+Ny42WwHXUMIzf46c6f9EyBH0/UqF7yyuUcaJ9EVVi1mYMaY1p1CbG45Z
80H+ZkfcWDDlrgSAsukJCzVJ3U3foAI3MtarQJFJ+6h6zcw/SqEExQ1hADg5tH3C
svM/zcT7k9yoPVcYXLaLJ7QnB+TUAdUXdYAxpHeAXokDK7IsYpynr4IMwjuOEajH
U3UJ9dbRHpACDz4a8+ZGzcsdTpJfzEYe5X80GmJerkix/O8uGFq1cK/mLvgwscFr
BS/LJbABnUQVJBHkRpzdG8V6CwouG0W+hwWNy9EXi2rvnQhpVWtnLQq97ngY+DaO
HwVRroIuno1HawxhJm6flTpK/SEzAQ==
=/C27
-----END PGP SIGNATURE-----

--mqecs6IEkkZ9zLfG--