Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8278182rwb; Tue, 13 Dec 2022 04:37:10 -0800 (PST) X-Google-Smtp-Source: AA0mqf7Kfj1lISK4N4AFEiwtqseCgdR05K3kmCQ85CVxsjFqCx3RxWVA5opQRg5TeW+QhzISYz7i X-Received: by 2002:a05:6a20:94c8:b0:a4:6ce5:46e7 with SMTP id ht8-20020a056a2094c800b000a46ce546e7mr26451173pzb.10.1670935029868; Tue, 13 Dec 2022 04:37:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670935029; cv=none; d=google.com; s=arc-20160816; b=yW/KqZoMS4qu6QzSKuA8os3ry/XCom202XEDC5xxeV/Mh2+i5i2gxB+0pe3Cmpuq40 hmvIxhpp4bsxSVedTHSUAMPc0C4oAUY147odn8cPWrCbc6W6Bo2cw451FErW5ueqBRN7 El6r7Cswsz9VPMN7PX93e0I30lfxQNRmF5XO8d0pqzK06GLjwSV5gyCqO/k3lhUnGQdg sPpp/Q+q/cstzQe0b09iHOqMkNjP7+OlOk4bjTshrdakc3CqyZyWehvWnryjWY7nnIFu ryPqKqVteJnwRKJpUAmLEiBFvNjewLXxbrc3KhnK30eYNKtWwxMGxI88ap93S3jEtIXc 9P6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QQzBeXlaOVDibgrGmbkRD9MbAgTr4HaUJ7KIazxC9OU=; b=hKvIy3GNXRDsUNfBuDdllrj3Zw9ZvCf3H6+j7sf5Db8zNUFK+XWhqv+KZ6ANwLK5ns yz1CM3y7BGXLGN6p9dC6CsKvmn7u1kCp+Ff6zezucFl/zLepQQD7uz0h1SBlRygVFd7O gsQNDr898aJXati3vNkWchIUxb4hdD095KtgDW4cdaRz+gS6V2aaZarrli0tBLrxlbnS bNB1WRCTK8gBj/tBfdnDmu/KjcYOBKsetAzM1c2b7FOakopSz/d1cNFZ0l3gIdzG0wev bTT8qEedwp+S/nQbR4Hm6UnsLNo58O+NMiZbf9urgocAtvwHdUOQyYANfxAohPD7tl1E bOMQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uwTIiPuU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g18-20020a63f412000000b00477ca5b5617si12718965pgi.147.2022.12.13.04.37.00; Tue, 13 Dec 2022 04:37:09 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=uwTIiPuU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235482AbiLMMEo (ORCPT + 73 others); Tue, 13 Dec 2022 07:04:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234703AbiLMMEk (ORCPT ); Tue, 13 Dec 2022 07:04:40 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BF48715A26 for ; Tue, 13 Dec 2022 04:04:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B750614B3 for ; Tue, 13 Dec 2022 12:04:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9346C433D2; Tue, 13 Dec 2022 12:04:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670933076; bh=PPHuWE4XkstXrom2xaRiEphZZiBoxWs7d6Ao/vsKC+s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uwTIiPuU7JeBUvPvgQBH94owxmCf6mPQZD5/lNCQfrdyMM3pHq6GeBC5YCi2tWQrt Vr6YgRAAWYCakDYorT4zNNDLfOvlOyCNvB7YyznYwu0zLCECTHB/X8Ldl4xEf8uuWa cTced4Vwr/AFNwwIPGmrA1hryVgJiwtf/nhGBjEVph1fabgoFPPwOM4jxjHasQ/znN wVJGI7ynbaRR9TWAqQzZavHlk40PYWMfuHLkDu9G0ocBmAeNL4FhAmjNGReBYZmZcS b8LFTr5dXCBJRsb8moLMUqiEpJXo+QmpvpUpDK97NzkVipZJ8rSc3e/AzJaj2536IV C3RPAvCLxx9Yw== Date: Tue, 13 Dec 2022 12:04:31 +0000 From: Mark Brown To: Rouven Czerwinski Cc: Liam Girdwood , Jaroslav Kysela , Takashi Iwai , kernel@pengutronix.de, Marco Felsch , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ASoC: max98088: fix dai1/2_hw_params access Message-ID: References: <20221213095328.122309-1-r.czerwinski@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HgDPkyQ14qG89rof" Content-Disposition: inline In-Reply-To: <20221213095328.122309-1-r.czerwinski@pengutronix.de> X-Cookie: Edwin Meese made me wear CORDOVANS!! X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --HgDPkyQ14qG89rof Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Dec 13, 2022 at 10:53:27AM +0100, Rouven Czerwinski wrote: > From: Marco Felsch >=20 > According the reference manuals [1], [2] updating register 0x14/1c > should only be done after #shdn bit is set to 0. >=20 > [1] https://datasheets.maximintegrated.com/en/ds/MAX98089.pdf > [2] https://datasheets.maximintegrated.com/en/ds/MAX98088.pdf >=20 > Signed-off-by: Marco Felsch > --- > sound/soc/codecs/max98088.c | 8 ++++---- You've not provided a Signed-off-by for this so I can't do anything with it, please see Documentation/process/submitting-patches.rst for details on what this is and why it's important. --HgDPkyQ14qG89rof Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOYak4ACgkQJNaLcl1U h9Ad4gf9GB01gs7BPIzFvCH25I5aQlpvYWfjZX6pVoRy6gCVh+0zqbmH3XoyBHim ieacSU9N2nGG48HkUKlQXsOb5/QXde45Gh8T9s4xwV5YdvM0TF1o9+jNE2uGEOgC CnMcUt4AZl73ihJi8NqiqHYa7Rg5p3rFDgoe4mmCn9M4br5Rd8fKyCgeQnzqSGa7 xzkvruCaOWI0sJ6OCfFbIkKq2G2yO+3Z5uSMBR41+eiFyDBHfy2bGLckJ9GLeEDm sg7O3NeMki2GEbctfGemG2Oa1JHVB0Qq+1AoHu6Jp0xzfsUDZjwRtxU/b+I2J2c1 a3ooBqIuJ9tmSI4cw6vnWYuTpOkhrw== =hmG0 -----END PGP SIGNATURE----- --HgDPkyQ14qG89rof--