Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] f2fs: add support for counting time of submit discard cmd
Date:   Tue, 13 Dec 2022 20:21:21 +0800
Message-Id: <20221213122121.18685-1-frank.li@vivo.com>
In-Reply-To: <0cc89bf7-ea7c-d6e9-5ba9-548181de4c82@kernel.org>
References: <0cc89bf7-ea7c-d6e9-5ba9-548181de4c82@kernel.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?H8a/rSQG3F2cn2T/BR20dYHmyIVbaTIwijA1OY64kKgl+NqgPZXU3o27czZw?=
 =?us-ascii?Q?SFyPfYwLrE3JMMdOXsoW3/zG9OC2qkBxATjXf2sJHiwYWrn9LUhHkiSoS6s5?=
 =?us-ascii?Q?L+nB7+Tbm4yrJat9k9ylFlgTB8WJ9fKEjRg7hVP1RMWyhb0xTgnxUt/qrS+E?=
 =?us-ascii?Q?ZLJAOHdNyQBfWzaJ+N322DewNi/DlhP85wO2nbchlr/H7AYd3vOl6IJW8a/z?=
 =?us-ascii?Q?FLt1Mft19Wuj6FxtEk7NsefUEUc4HyD36q4VZIU+wjphyjwteKdpuxqc/zzz?=
 =?us-ascii?Q?KCHS4YFqnISkFsmijbSpWK7RsMpnOZqHRVfuQ8tIUaXU3Pyh1fS8lxff/Hyv?=
 =?us-ascii?Q?JDnPEA/KPBfOimyGV0kdwcQQhRhcMsVQzBkLGOqhv1L9BYyr75tnW6HNtXsg?=
 =?us-ascii?Q?WmOG6hjCpMGyZyg99zVmN+U0cXIZcW8ohuRy7QdRIuec9rfjiG7bwnjMuZO/?=
 =?us-ascii?Q?rI/CN7PF9kfyVtiV6+B9OS51QWTgRYXYlS1Gs5SXZe1B1oJv9jz0oVFMrhN3?=
 =?us-ascii?Q?bt1PRu3ph7Am4DFGweJv8jsgKcOw+K5tJMvPJokr/8yD0yXwqD2IJkSEwwnF?=
 =?us-ascii?Q?unzNXeFR2tTSmQs4Cn3aMNrCp0haqL8rljCrn8CtIA4GzE5hHrgBr3edYf+L?=
 =?us-ascii?Q?qc0v5RRYQjW8Igze6PD87xQWDzmM0CzBhP81easVSjN3ibuJY0AGRS+WqcDf?=
 =?us-ascii?Q?CaMrMGQGGG6A6GrF/ydDgatVtONg8tlAAj/g+vaM5IsTGZrHQddVuhKWtiNR?=
 =?us-ascii?Q?suSJvz+72jHU66tligE6JYQfnTSOu9RRFR7rXh09efDHZJKNYCftKAx1TvfN?=
 =?us-ascii?Q?gu9QXs4w7BOhkKH/1jAZHPLV2EJKSMOCyPZ3mQ5fdcumTIenTUFKBvMERLcf?=
 =?us-ascii?Q?+Zv9wBWo81SP1uxfX9yW2T4CYoZkuuQOP1JGbSF7YHnm/f7gWptxcNDSwijS?=
 =?us-ascii?Q?TUhKmLpOEmHLYW6nDT3tygYArYAVoq8b6Q9SBkGJAREfS6t44a9mctUmj6IY?=
 =?us-ascii?Q?wypDhWkt6J9nV3CrzTEDn4oo13J/vA0SL/iwCV6EGZyawQcdui4rrBrgIhUC?=
 =?us-ascii?Q?bGz89AoNpVC5EbE255dn1NSedsZnsfi/NDc1N7H07Y7U6ykoAl7wNYc4EAfk?=
 =?us-ascii?Q?I1reylxB+8wgPoAllD/U1D2ZthARpeXdDHiXe2F5gY+FDXBaUH5FbKBNHt/7?=
 =?us-ascii?Q?+0n6Zh0DypERtHWAx0qqWK2zXbFzkA9PitKXamGIXhgESaRsDBRuaTkhW3LG?=
 =?us-ascii?Q?7zfcYhzcRum7oxW8w/EzO9G+OSvOnGG/S/bTt1pJ5FYtpEajRVcloLmPL1F/?=
 =?us-ascii?Q?WgFR3L9Gf7P11JrNGvxfoo/EQDJiroVP8CqN7vRPwBhgCE7LQY/Z62YPcpJs?=
 =?us-ascii?Q?G6vk8TnW5TmEZXJfDOyaYKkKWkdCXKFMbJGNhGs3FXNWf/ipFa8nYwV41kfj?=
 =?us-ascii?Q?4NBYsc8G0naB4e6NAlX3HwKJQ7/IqicPYaf75Tf9zy2Lzg6kQVsg9wSYjAUB?=
 =?us-ascii?Q?/KGWdvxb720IBNwTftq+KsHd6kPHmA5fGYMLRHBPU95wlwsBuAwQQvzBjZJD?=
 =?us-ascii?Q?qiLWUFpCVeByC8GS7zFdepAJgUjvbcp4yxEfmWW0?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f112fc51-fc0d-49b8-486e-08dadd049016
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 12:21:29.5364
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3Ohkn4ewcq6dX1gdbqsDu514LRqoPO4Jay4R4fFx0RdO94dL/w7lb+8lvdpKswE6GO/hP5n7Za26IgMj2Bsk5Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR06MB5245
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jaegeuk,

>>> Again, w'd better to consider this functionality only when DEBUG_FS 
>>> is enabled.
>> 
>> BTW, why can't we use iostat to get the discard latencies?
> 
> Agreed.

Let me spend some time on this. So, I guess this patch can't catch up with the merge window.
And I still have some patches that have not been picked, can you take a look, hope they can
catch up with the window.

How long is the 6.2 merge window left and when will you send the f2fs 6.2 pull request?

Thx,
Yangtao