Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 13:04:00 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jishnu Prakash <quic_jprakash@quicinc.com>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org,
        devicetree@vger.kernel.org, robh+dt@kernel.org,
        linus.walleij@linaro.org, quic_kamalw@quicinc.com,
        quic_jestar@quicinc.com, sboyd@kernel.org,
        quic_subbaram@quicinc.com, quic_collinsd@quicinc.com,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH] spmi: Add check for remove callback in spmi_drv_remove
 API
Message-ID: <Y5hqMFw0xl6lmJYL@kroah.com>
References: <1670145780-13111-1-git-send-email-quic_jprakash@quicinc.com>
 <1670145780-13111-2-git-send-email-quic_jprakash@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1670145780-13111-2-git-send-email-quic_jprakash@quicinc.com>
Precedence: bulk

On Sun, Dec 04, 2022 at 02:53:00PM +0530, Jishnu Prakash wrote:
> Add a check for remove callback presence before calling it for a
> spmi driver, to avoid NULL pointer dereference error if remove callback
> has not been specified for that SPMI driver.
> 
> Signed-off-by: Jishnu Prakash <quic_jprakash@quicinc.com>
> ---
>  drivers/spmi/spmi.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/spmi/spmi.c b/drivers/spmi/spmi.c
> index a456ce5..6b34356 100644
> --- a/drivers/spmi/spmi.c
> +++ b/drivers/spmi/spmi.c
> @@ -350,7 +350,8 @@ static void spmi_drv_remove(struct device *dev)
>  	const struct spmi_driver *sdrv = to_spmi_driver(dev->driver);
>  
>  	pm_runtime_get_sync(dev);
> -	sdrv->remove(to_spmi_device(dev));
> +	if (sdrv->remove)
> +		sdrv->remove(to_spmi_device(dev));
>  	pm_runtime_put_noidle(dev);
>  
>  	pm_runtime_disable(dev);

What in-kernel spmi driver does not have a remove function set that
requires this change?

thanks,

greg k-h