Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yangtao Li <frank.li@vivo.com>
To:     jaegeuk@kernel.org, chao@kernel.org
Cc:     linux-f2fs-devel@lists.sourceforge.net,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] f2fs: do some cleanup for f2fs module init
Date:   Tue, 13 Dec 2022 20:09:46 +0800
Message-Id: <20221213120946.16875-1-frank.li@vivo.com>
In-Reply-To: <635cee2a-3f11-b963-b800-b417be7007b5@kernel.org>
References: <635cee2a-3f11-b963-b800-b417be7007b5@kernel.org>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tM65QBr+MtlGrKI4wOMvDx3JdZ4UHBw4k0uMxOlezSDF7wqO+oFZQK8u+aDD?=
 =?us-ascii?Q?HD+hMH+uQfcClqAmIHJSvDdL6AXkvrXVk2kEqz26REy0CZpgh8UZg7iXImAO?=
 =?us-ascii?Q?WA4l9hUYo6kt3o1Occ3fgBM1DW53Be8hyQbgG0HQczTrh/VuhdC/HKizEga2?=
 =?us-ascii?Q?CoHNyZQWMqL5WRFX7VRYkfNWieZWfc5eDZuJds1NhQAobY7uGAGgkjcRBxdY?=
 =?us-ascii?Q?93gK4ua18XzXtHp7zc/ClGvZNYk10Tm87vP9qjNxhHfnTE0DqPf2i1ZMF5cs?=
 =?us-ascii?Q?QgpsFBGyTRgIlMtfTpOiXUUX6PWDa7xaUJw16b8HtkwXsojBMSqpasjBJb0y?=
 =?us-ascii?Q?Ryg98U+Abr7hpVzJY2v4U9baU821y7AkiImWaeJTis2srsIhqCzfIOS+BZZH?=
 =?us-ascii?Q?vnCD8AD+EQRm0M3n6KF2RI4iETWiEAleF89J79NVw7YGyAapn8qmqTrRoDmI?=
 =?us-ascii?Q?rsVjClTL3lYp0lBdyQ3lsEqvyJM16wZySuuYV2Od3yNx/V+/HayV0wObJFTb?=
 =?us-ascii?Q?WoKhYPa53/o/SYSOJTF4Ak5Qd32UIuinNJKF3NLpjrQXEpAtOuZeH6n4kQJj?=
 =?us-ascii?Q?RofnSEVesAKWfer9QJV/FiCdGglaKWmLalM1KPJE9WHw5Spe8xrLRXDLeXgR?=
 =?us-ascii?Q?iijNoOMkxhyogCC3hI98S22+XPiQ1BIhZX6C5wRW3qxbGcQ67lUukNJGwzQK?=
 =?us-ascii?Q?Hoz3b47hLnW8Ze1X8JGxpB7ZUzgNWc8UvXBZ5kUt+clXpsw2E2860f4ZmO++?=
 =?us-ascii?Q?qCXBf35Ef21xVnxnK1Q11DvKnRs8wSvMXJw87N0Uk1pf5O7JHCUrwUeT/dK2?=
 =?us-ascii?Q?LNCYBa6J1I3yZVVEUFgyFYH/x8D7yEpUz5W9K4wB/uFAnoqqXaLkPjB0P6g1?=
 =?us-ascii?Q?DN4KwP2Fr8B/gXrzjT3Wa3zflPj9uFxB1xYzY/vbnLOI+kVZpGvWgSm0vgJM?=
 =?us-ascii?Q?GiAFIVjHlpSw3ULUkDzaTLaaZnL3oLFoLSNBeSJ6njgGH+y/m06V6FuWAmUu?=
 =?us-ascii?Q?u5HvBuqbzFxMZZ9SfekDvN62naWjWa6rs4eU51UfuykcHyQnrkXTzOzvsl7V?=
 =?us-ascii?Q?oCyPWY8m0/QJFTDA7SR4oNp0hzG/0SkM2ghHOUhE1UpScUe+BqcSkvudSe5z?=
 =?us-ascii?Q?V1/Oygx42sQhrdDqMRr6Tu1YoHROd929Nx8qRpQI+lt0odUmEt6Q5sPJ0NDD?=
 =?us-ascii?Q?fdV8Rfii1k/gPUXRndNSMm/emOE0GET5HKPwthYMrY7jMC9pjrBYACj8q7dk?=
 =?us-ascii?Q?EeJVFZfnEwqVkzu2tVhCmvTN7SPoIYryJH/6O1kTjlbAdkjjAQ09ZiSkD2B3?=
 =?us-ascii?Q?SKmi++4+xGfm7a9bB71eMJ3raPYw6CTvG4ecwqnXsYuqCp+cM0WJA5MmKw5d?=
 =?us-ascii?Q?S3izHdgMtyeYAqCdPqIDMtARaAEL36mXKF4XxhrM0DF4qhgRXfb0g5lRzhym?=
 =?us-ascii?Q?bt6ccDgzWKB5KpAfMEIPD/ybTHhuYj94JLaJ4dM5BRocAj7sXSLzk4BFsl2r?=
 =?us-ascii?Q?JS+XvtsiH78hIoMUQ9kf2WRJWKR6F87p4ptMGK93+9o46aTc1yfOB922TSbe?=
 =?us-ascii?Q?8JrJ5SSreCa7ceQXkK6m0N2c8aiaBRNgVeOPvKMp?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4267bed2-8e36-496d-f027-08dadd02f24b
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 12:09:55.2957
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: J+Dhp4rX05+T2IRLaE4QCadQh5SJj8PNR0PlexqvH4Kgty8nq+3v9w1T0QsftgXeAOqhoJUjM7fGUHyZ4mzY0Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PUZPR06MB5770
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>>>> I don't think this needs cleanup, other part looks good to me.
>>>>
>>>> What is the point here comparing to the below? fyi; I picked this change.
>>>
>>> IIUC, the question is for Yangtao? :P
>> 
>> Heh, to you. :) I think either looks fine. Hence,
> 
> Ah... alright.

> I comment on this cleanup, due to I don't see any benefit, since both implementations are very common in kernel codes.

Mainly the cleanup of f2fs_init_compress_cache() and f2fs_init_bioset functions().
For other parts, I don't think it is necessary to take up too many lines, just deal with them by the way. :D

Thx,
Yangtao