Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8294204rwb; Tue, 13 Dec 2022 04:49:53 -0800 (PST) X-Google-Smtp-Source: AA0mqf7DkFO4v1jF8TbGmiv6DlfBZXl/2JMzq5wJsIqOmTE79YdAOp6OJ8cjKx8aDKgqZu1RHAB6 X-Received: by 2002:a17:907:9a84:b0:7c1:75e9:986 with SMTP id km4-20020a1709079a8400b007c175e90986mr5567296ejc.37.1670935793194; Tue, 13 Dec 2022 04:49:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670935793; cv=none; d=google.com; s=arc-20160816; b=CTRFbwBrIsHuq/4DgoZsBwLGg6IRmj84EbIBQvvzfxcL/yMzlw3pGXGseWlJgZZ7aJ xyNjeMEqiw8eXrSM7S6rlES1b0JgsViIpIjx8v0fKcYoCT8ZCxcuB5+ZuIwK+b62EeaH I1tmoNt+YRENeMHZaB0xnnrhl2mTz5JrWfBZqZAgZcX9NwU3lHCqORPEi6PEJgguaahC nCSm1nVi79jW5MjPsqSzCJSWkLAC+Mt2o68lddrtSXHk2TKcKRbmeVVCXzI1fYSk+rSA XNZRSZ3JM/1hlH2ph3XugVmenzOa0PN1UIQhNyZnb0ii0HR6sx87DDVxIpQIaJPLv57M OhkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=iA5GJ+VaB8o57aR6gsmYtIX/yg5eC3cN9UPUgbQyA0I=; b=KrBoApfHI2z3flbmwrrphZNIJGZQwFHlP7vE28w2vWxGIc7tspaQRpcvwvG+0ZuBT9 hLJeLQ7NPmD0+demBOAhUU7EqfchRSQpOZYi04ifFJElkLvCNOv8+c+UI53x7ErYn5u6 xsNS5JhxJXae9NFVZerYwwhk3WpxDuFsEdAmOhQGsKHMnVs//m+zl7Wso3XggMwkxW91 RJsf72GoV0JDLwNg0MvDRAndpNeckziwaYOM45VJv2zDmNJsuMnvS9HjOe0C5wBRrgCd 4fcCkWkG46osRNXqK5P5mIg20qgrUk/xPU2Y2muvfzBogYQafPx3mUi6bb1cr+l+SetX UX4w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hs30-20020a1709073e9e00b007bbf9652314si9678150ejc.435.2022.12.13.04.49.34; Tue, 13 Dec 2022 04:49:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235285AbiLMLwg (ORCPT + 73 others); Tue, 13 Dec 2022 06:52:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46646 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235043AbiLMLwX (ORCPT ); Tue, 13 Dec 2022 06:52:23 -0500 Received: from out30-7.freemail.mail.aliyun.com (out30-7.freemail.mail.aliyun.com [115.124.30.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9423EFCFB; Tue, 13 Dec 2022 03:52:20 -0800 (PST) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R151e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=zyfjeff@linux.alibaba.com;NM=0;PH=DS;RN=5;SR=0;TI=SMTPD_---0VXEBpaV_1670932326; Received: from localhost(mailfrom:zyfjeff@linux.alibaba.com fp:SMTPD_---0VXEBpaV_1670932326) by smtp.aliyun-inc.com; Tue, 13 Dec 2022 19:52:18 +0800 From: zyfjeff To: linux-fsdevel@vger.kernel.org, fuse-devel@lists.sourceforge.net Cc: miklos@szeredi.hu, linux-kernel@vger.kernel.org, zyfjeff Subject: [PATCH] fuse: remove duplicate check for nodeid Date: Tue, 13 Dec 2022 19:51:47 +0800 Message-Id: <20221213115147.26629-1-zyfjeff@linux.alibaba.com> X-Mailer: git-send-email 2.34.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org before this check, the nodeid has already been checked once, so the check here doesn't make an sense, so remove the check for nodeid here. if (err || !outarg->nodeid) goto out_put_forget; err = -EIO; >>> if (!outarg->nodeid) goto out_put_forget; Signed-off-by: zyfjeff --- fs/fuse/dir.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/fuse/dir.c b/fs/fuse/dir.c index cd1a071b625a..a33cd1131640 100644 --- a/fs/fuse/dir.c +++ b/fs/fuse/dir.c @@ -395,8 +395,6 @@ int fuse_lookup_name(struct super_block *sb, u64 nodeid, const struct qstr *name goto out_put_forget; err = -EIO; - if (!outarg->nodeid) - goto out_put_forget; if (fuse_invalid_attr(&outarg->attr)) goto out_put_forget; -- 2.34.0