Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 20:24:27 +0800
From:   Chen Yu <yu.c.chen@intel.com>
To:     Honglei Wang <wanghonglei@didichuxing.com>
CC:     Josh Don <joshdon@google.com>, Yicong Yang <yangyicong@huawei.com>,
        <yangyicong@hisilicon.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Joel Fernandes <joel@joelfernandes.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Tim Chen <tim.c.chen@intel.com>,
        Mel Gorman <mgorman@techsingularity.net>,
        Juri Lelli <juri.lelli@redhat.com>,
        "Rik van Riel" <riel@surriel.com>, Aaron Lu <aaron.lu@intel.com>,
        Abel Wu <wuyun.abel@bytedance.com>,
        K Prateek Nayak <kprateek.nayak@amd.com>,
        "Gautham R . Shenoy" <gautham.shenoy@amd.com>,
        Ingo Molnar <mingo@redhat.com>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>,
        "Daniel Bristot de Oliveira" <bristot@redhat.com>,
        Valentin Schneider <vschneid@redhat.com>,
        Hillf Danton <hdanton@sina.com>,
        Len Brown <len.brown@intel.com>,
        Chen Yu <yu.chen.surf@gmail.com>,
        Tianchen Ding <dtcccc@linux.alibaba.com>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 1/2] sched/fair: Introduce short duration task check
Message-ID: <Y5hu+2YA2OYR4VqE@chenyu5-mobl1>
References: <Y5gRsnLQLlzugB4I@chenyu5-mobl1>
 <2a54f264-de3d-d5a3-941a-016ed2cfea0a@didichuxing.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <2a54f264-de3d-d5a3-941a-016ed2cfea0a@didichuxing.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?yMeHELps9vU5s/iwUqAGM0PrE+lmOrUWkGHat3EWRkWhavM7P/ikmKtKcNXd?=
 =?us-ascii?Q?T235DbCTlALmWTP8ELz1t6R0hafuvByyQ4NMlApGF/DsdjZiTkQBHYdGo8H1?=
 =?us-ascii?Q?hF18aA8ypUe/RIjHPuEa4Z3gtyMkuF4uYzfGMYzGRJcJjo8sea2vaaJBA/gL?=
 =?us-ascii?Q?4OTGNmp2EUbgCSrtrQEwbqFMxTv0nF2edvjY7fqwQbPnwF7w1Z5nWRPTt498?=
 =?us-ascii?Q?JCpBlC3mreMwncwMR+UWRoW2OM37mtT114l7czQpuHPYrnSqDRAFqK3/MsA6?=
 =?us-ascii?Q?tgz2IYVrbmJ7F2YydWGSPLrk2ktEkPJRpyvrfL9TFofHKCL+XCHgCE9Cx/pt?=
 =?us-ascii?Q?rP2RanIo/keGrOEzXequKe0jKhMCtQfVsr9Gdav73u8dKRow2MGVbwg6emOs?=
 =?us-ascii?Q?tOfTt6FeFbg6EfUFCqjtF4Pxabcghzi0WGOo5sRUd3fsh6G+Cgxrhf39m/Fj?=
 =?us-ascii?Q?o56btjRu+m/0r9IEqvb6UCnRj1xn7DDfNI7Tsnv/5jzduGhDQNFNx6OEFiVE?=
 =?us-ascii?Q?/QOSk6sXLqrejUIcZuDa2Xp9IZ6QUWNL3/YvR2N8e8P+NfOn3RHebEgtcGb7?=
 =?us-ascii?Q?aVaP+MY4fuVUAvWA56sdIKYgXV/TFy/mNcSKALg50PhxL/0kcM6HGJcCksJr?=
 =?us-ascii?Q?F8AAk3XUpNmetIAzRSf3Dk/9fFLuJG3+WlHnwqPT3ygvcaEYFqdaf/CPz1K+?=
 =?us-ascii?Q?Hten3PlBBtgxfYD7m2V7nYG172ogRP9Y3+CPQW4tJIekYH5ntyeGovkZiiJL?=
 =?us-ascii?Q?V178HqJu8yNheYzV4URffHlwLGI8W1He3L153NV2oLTYu9KBCZlBnvdEPbcj?=
 =?us-ascii?Q?aLRafut/R0tao1kyU6MWDJjW7HHzW5iPW1+9FoWPFTHAgXDrOjv8ZZ0RUSeW?=
 =?us-ascii?Q?vbyS/T7Xmc7dKp+AGhW7+5NNO+v3AH7d1ldfcqpphrsONtP+5Omm4x55/iMc?=
 =?us-ascii?Q?r2njlL4fSy7NBjXXmBHYciYCGF49munH5MaZXkxZYTp81+V3SzCvYhL7gl1k?=
 =?us-ascii?Q?ZmUPxPu0BiH/NCO5MO4QuCHOpXrUVJiz9/DsMlRwEbFcQQdZB+wvh9F4rHQC?=
 =?us-ascii?Q?5zCMLiAp/vNfDBywh0fOYQnGwSZpaA6pde5sWJgSZIMDp1fHFo1/FkZJJPeB?=
 =?us-ascii?Q?NqeLQ8Xnv8H5JsfWjOMP9LIHoxrTxh6A8WWkLM8PvGmYVPKTzrzhTdxWbHXg?=
 =?us-ascii?Q?aWjBD2BsKM3CzuRqDIsy89E1wH3kAX7KBiTjrAXJvo/skK1ttVSYyYvVhMHt?=
 =?us-ascii?Q?mQwwoo6VPr5rLhQYlGfR1N0I2Y/jhYtMv2Ue2seLuh6fmMS6rQ1PrhHL5j6s?=
 =?us-ascii?Q?1PsU+iBHUWk0sBdETTAzBxFm2OEW7Khu0QJB8hyDJglPKhk5mGBn1AmXUPlp?=
 =?us-ascii?Q?f3wH+t76QD/2cI032970oxWYxxx/h4aMLbdsHsMIrgZQOzZ+JuywbHJyqnt+?=
 =?us-ascii?Q?iWovjAa+IPV5czJpmxRow/Kr3rjpS9qpRs4TT8/8ScQCqW/jaNomX0tPhRQO?=
 =?us-ascii?Q?wgfhrBZxkCkF9ofLpn4kRewWYALtFkQBQhFeoURek7pZH3MmkmC1/H2CFsF/?=
 =?us-ascii?Q?HtANqyeyQESPI1Jnh6ChALyP3yOa59JRUscB+PXu?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 50c27eec-1fce-4716-c513-08dadd05064c
X-MS-Exchange-CrossTenant-AuthSource: MN0PR11MB6206.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 12:24:47.8490
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Q/8zdbCgbRBRYMRhjPBzHXfMrQH2+zCqTqUwXAcjQ7WoN2Lw8PC6GuAiiz1wJ4vlYnbMmPG6AhwUfQMMLcxhUQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB6411
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-12-13 at 18:06:50 +0800, Honglei Wang wrote:
> 
> 
> On 2022/12/13 13:46, Chen Yu wrote:
> > On 2022-12-12 at 10:17:35 -0800, Josh Don wrote:
> > > > BTW, I've changed the threshold to (sysctl_sched_min_granularity / 8) in my next
> > > > version, as this is the value that fit my previous test case and also not to break
> > > > the case Josh mentioned.
> > > 
> > > Do you mean a hardcoded value of some number of micros, or literally
> > > sched_min_granularity / 8?
> > The latter. According to the test, the average task duration when system
> > is under heavy load:
> > 6 ~ 9 us for netperf
> > 7 ~ 70 us for hackbench
> > 7 ~ 8 us for tbench
> > 13 ~ 20 ms for schbench
> > Overall the duration of the micros are quite small(except for schbench).
> > The default sysctl_sched_min_granularity is 750 us in kernel if no user
> > has changed it. Then 750 / 8 = 93 us, which is close to what you suggested(100us).
> > On the other hand, if someone changes sysctl_sched_min_granularity,
> > then '8' can be viewed as log2(256). That is, if there are 256 CPUs online,
> > and the sysctl_sched_min_granularity is changed to 750 us * log2(256) by
> > the user, we can devide the sysctl_sched_min_granularity by 8 in case the
> > sysctl_sched_min_granularity is too large.
> > 
> 
> Hi Yu,
> 
> Seems there is a min_t() call in get_update_sysctl_factor(). In most cases,
> we'll get 750 us * (1+log2(8)) = 3000 us in default due to
> sysctl_sched_tunable_scaling is set as '1' default. (Correct me if I
> misunderstand).
>
Thanks for pointing this out! I overlooked this part previously.
So (sysctl_sched_min_granularity / 8) is 375 us by default.
> For the value in production environment, I've seen 10 ms and 3 ms in
> different place, FYI. Hope this help.
I see. 10 ms would generate a short duration threshold of 1.25 ms. From
my understanding if the user increases the sysctl_sched_min_granularity
then it is expected to have longer average duration tasks in the system.
And the short duration threshold should also be raised.

thanks,
Chenyu