Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 09:11:46 -0400
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Niklas Schnelle <schnelle@linux.ibm.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>, iommu@lists.linux.dev,
        Joerg Roedel <joro@8bytes.org>,
        Pierre Morel <pmorel@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, will@kernel.org,
        Robin Murphy <robin.murphy@arm.com>,
        linux-kernel@vger.kernel.org,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Sven Peter <sven@svenpeter.dev>
Subject: Re: [PATCH] iommu: Allow .iotlb_sync_map to fail and handle s390's
 -ENOMEM return
Message-ID: <Y5h6EuA+mx29pMCg@nvidia.com>
References: <20221213121104.1659412-1-schnelle@linux.ibm.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221213121104.1659412-1-schnelle@linux.ibm.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?5BJb8XFnJ4wwS2R/fTCTv82SF5qNeht/5v03VXv+cwd2lPTHT46MbOE3g0/n?=
 =?us-ascii?Q?MY61fIQRPcS2NvSmJwH4oQX9KGx9PfIVGfos1Edzb3hM/YiVGysa1po8uBxE?=
 =?us-ascii?Q?RusMlltQanD2/rF05Ejp6U7EysEsTRAEv3VoDnQfu6ZvcYXsx9VU3topYZT3?=
 =?us-ascii?Q?NOC/JRfS+dXE4cq4Dv+DnvvvUF9PlkCOjnv2j57PTZNTbTPTG4i1d0fFesEY?=
 =?us-ascii?Q?rZ/oD92l616r019NUr97MOe/2scQRkAwsibHhArwvGevCVYvKW9H3MHErfDX?=
 =?us-ascii?Q?nDp8JjB0GRbVk8hF34t5F8vHz06+bj3qCCsl/8jCPAuWqomaS+AllbksgiUO?=
 =?us-ascii?Q?mfIYgURVMjyc5cMWdeCX5au8ZokBk99djXCMUKmgEJGZxjkSG0fNaWNtAfS5?=
 =?us-ascii?Q?25UYyEAGGaJ9h9Z245zJJPvU5xSmn8yEAbPkAwfCpwnpwTzYc/2Yy5UDb+VI?=
 =?us-ascii?Q?ION+H73kJhn9ivncOVoQr5/emb3iSGDJHUiepHhi8Td42raBLUJpj7Ajm5B2?=
 =?us-ascii?Q?hxk66WkSD9aSkfMxL2b4uwhfvWDhgMUcFlFZ/Wvfsw1r1KLZrC2IN7mD1mzV?=
 =?us-ascii?Q?z+WVGwZVAQB6q/8rXLd32Zh/gskcmC4iiRtlDVo5n5M3kxVg/6yqplIdKU8g?=
 =?us-ascii?Q?7m2L4LAA5MhkXLdNtwRdjrnUi7vRcB5kzcENcOgGwX0LEtOOXwWFtgdcjeZN?=
 =?us-ascii?Q?mnX3K81/pzs76AA/GGWlzlJybGhjss/jP8eUXdMwt3gOsGeHAnfRn/whUfQ5?=
 =?us-ascii?Q?dPO/7nkHV/hIFKc62T3B/nH3jdTeEu2ujD8luLCV/10/WRGAJZEg2u2FZ4MJ?=
 =?us-ascii?Q?3nvRRZ/Ybxlj3qWR+Wjp15tMDzaNMLTQrI+2l9ziB4B5qYXJRLDSONRgtlZJ?=
 =?us-ascii?Q?ZHvYBbxNxaXU7eGsvfnORp7ZJBTDTmQ8EQpN1Aws6RQT02E6qhFQHa2Qpmma?=
 =?us-ascii?Q?hNs0mvImoA2vKckMwIHdfLcPPvoUQpI3dlJS7ggQ7KNIrMZS6U+qS8JL1NJe?=
 =?us-ascii?Q?e7htmMwLYfcHryBQwxDwXMRnPEOsYtpw0mJL4G9TGdGg6r58anGAYqU0Jwaz?=
 =?us-ascii?Q?KJQJ1k63gTrMcYgTJopWnvEa1xFt0awnrt7tMn5QBGrJyoqu3C79eJrmqYmp?=
 =?us-ascii?Q?iq+rue21C9e3xRcHjTYHr4hS2BwryLTDMeHrzGbd5pRk4SFjcpRcXp0fSUA2?=
 =?us-ascii?Q?Oy3G80Ua3DRpIWwEsRTq99RgYhW/ZgvLlxJZH7QmOLRGYKLh8JsHJ2nS4B0A?=
 =?us-ascii?Q?3uDPHx8IQ8sA+JwCywpHMmmZAK/nTx6FDidZtE4N6T6yLKEYmpH6XLgXlfEi?=
 =?us-ascii?Q?SYgOwgwo3o5v0RGFbRD/v4uw5sBHbnBfBAsi7lALFXiKDjF5iCrfMesyxBkV?=
 =?us-ascii?Q?IYxLRZbJDEjzbywic4dSoQ7QPZ6ticjWNq/WofcPhwqF1oFVCkb8xf2HZI9x?=
 =?us-ascii?Q?8DTbtOjiwgxWkL+QvGbjxGXkxa9MZZLtRkEyl+1r8WHU1p1tFaOSnSHYL80n?=
 =?us-ascii?Q?DAomMflOcoLvtnAU/hiwlM0BZsHmErDhr041V61+O/PZlDuuJVzQiwa378sN?=
 =?us-ascii?Q?BNSx6WCun0n0IpUBRiw5JYKlcOsc2D0F9NhTdEnz?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1d26441e-8c08-4792-6410-08dadd0b96fd
X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 13:11:47.5319
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Px8Gk//segF36kIJp4Xi2P082dHGoLWbcpQHN7IL9pl6tsIDMyh0tE6h/t0WG0Xx
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5810
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE
        autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 13, 2022 at 01:11:04PM +0100, Niklas Schnelle wrote:
> --- a/drivers/iommu/tegra-gart.c
> +++ b/drivers/iommu/tegra-gart.c
> @@ -252,8 +252,8 @@ static int gart_iommu_of_xlate(struct device *dev,
>  	return 0;
>  }
>  
> -static void gart_iommu_sync_map(struct iommu_domain *domain, unsigned long iova,
> -				size_t size)
> +static int gart_iommu_sync_map(struct iommu_domain *domain, unsigned long iova,
> +			       size_t size)
>  {
>  	FLUSH_GART_REGS(gart_handle);
>  }

return 0 ?

Jason