Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <74be1d4fff25840b8be2b786263c37840e5cca4c.camel@linux.ibm.com>
Subject: Re: [PATCH] iommu: Allow .iotlb_sync_map to fail and handle s390's
 -ENOMEM return
From:   Niklas Schnelle <schnelle@linux.ibm.com>
To:     Jason Gunthorpe <jgg@nvidia.com>
Cc:     Matthew Rosato <mjrosato@linux.ibm.com>, iommu@lists.linux.dev,
        Joerg Roedel <joro@8bytes.org>,
        Pierre Morel <pmorel@linux.ibm.com>,
        linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        borntraeger@linux.ibm.com, hca@linux.ibm.com, gor@linux.ibm.com,
        gerald.schaefer@linux.ibm.com, agordeev@linux.ibm.com,
        svens@linux.ibm.com, will@kernel.org,
        Robin Murphy <robin.murphy@arm.com>,
        linux-kernel@vger.kernel.org,
        Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
        Sven Peter <sven@svenpeter.dev>
Date:   Tue, 13 Dec 2022 14:24:37 +0100
In-Reply-To: <Y5h6EuA+mx29pMCg@nvidia.com>
References: <20221213121104.1659412-1-schnelle@linux.ibm.com>
         <Y5h6EuA+mx29pMCg@nvidia.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.2 (3.46.2-1.fc37) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-12-13 at 09:11 -0400, Jason Gunthorpe wrote:
> On Tue, Dec 13, 2022 at 01:11:04PM +0100, Niklas Schnelle wrote:
> > --- a/drivers/iommu/tegra-gart.c
> > +++ b/drivers/iommu/tegra-gart.c
> > @@ -252,8 +252,8 @@ static int gart_iommu_of_xlate(struct device *dev,
> >  	return 0;
> >  }
> > =20
> > -static void gart_iommu_sync_map(struct iommu_domain *domain, unsigned =
long iova,
> > -				size_t size)
> > +static int gart_iommu_sync_map(struct iommu_domain *domain, unsigned l=
ong iova,
> > +			       size_t size)
> >  {
> >  	FLUSH_GART_REGS(gart_handle);
> >  }
>=20
> return 0 ?
>=20
> Jason

Stupid me for not at least compile testing on more platforms.
Will send a v2.