Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 16:09:30 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Jishnu Prakash <quic_jprakash@quicinc.com>
Cc:     agross@kernel.org, bjorn.andersson@linaro.org,
        devicetree@vger.kernel.org, robh+dt@kernel.org,
        linus.walleij@linaro.org, quic_kamalw@quicinc.com,
        quic_jestar@quicinc.com, sboyd@kernel.org,
        quic_subbaram@quicinc.com, quic_collinsd@quicinc.com,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH] spmi: Add check for remove callback in spmi_drv_remove
 API
Message-ID: <Y5iVqrnlX8NoiOkl@kroah.com>
References: <1670145780-13111-1-git-send-email-quic_jprakash@quicinc.com>
 <1670145780-13111-2-git-send-email-quic_jprakash@quicinc.com>
 <Y5hqMFw0xl6lmJYL@kroah.com>
 <367fdcef-7360-055a-897b-71a66063b4ba@quicinc.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <367fdcef-7360-055a-897b-71a66063b4ba@quicinc.com>
Precedence: bulk

On Tue, Dec 13, 2022 at 07:12:10PM +0530, Jishnu Prakash wrote:
> Hi Greg

Hi, please do not top-post :(

> These are two SPMI drivers without remove callbacks defined:
> 
> drivers/mfd/qcom-spmi-pmic.c
> drivers/mfd/hi6421-spmi-pmic.c

Great, they should be fixed up now, right?

> We made this change after noticing an issue internally with the first one
> above, there was a crash when trying to remove it with rmmod, which is fixed
> by this change.

Then please say that in the changelog text, otherwise we have no idea
_why_ this is needed.  All you said was "add this new check _IF_" and we
have no idea what the answer to "if" is :(

thanks,

greg k-h