Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <da5bc530-5075-e17f-aed4-7a4b1f86932f@redhat.com>
Date:   Tue, 13 Dec 2022 10:54:37 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.0
Subject: Re: [PATCH-tip] sched: Fix use-after-free bug in dup_user_cpus_ptr()
Content-Language: en-US
To:     Will Deacon <will@kernel.org>
Cc:     Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Juri Lelli <juri.lelli@redhat.com>,
        Vincent Guittot <vincent.guittot@linaro.org>,
        Dietmar Eggemann <dietmar.eggemann@arm.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
        Daniel Bristot de Oliveira <bristot@redhat.com>,
        Phil Auld <pauld@redhat.com>,
        Wenjie Li <wenjieli@qti.qualcomm.com>,
        =?UTF-8?B?RGF2aWQgV2FuZyDnjovmoIc=?= <wangbiao3@xiaomi.com>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org
References: <20221128014441.1264867-1-longman@redhat.com>
 <20221201134445.GC28489@willie-the-truck>
 <330989bf-0015-6d4c-9317-bfc9dba30b65@redhat.com>
 <20221202101835.GA29522@willie-the-truck>
 <e9c7a920-4801-59fd-2429-361c54523d8e@redhat.com>
 <20221213125404.GD5719@willie-the-truck>
From:   Waiman Long <longman@redhat.com>
In-Reply-To: <20221213125404.GD5719@willie-the-truck>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 12/13/22 07:54, Will Deacon wrote:
> On Fri, Dec 02, 2022 at 09:30:56AM -0500, Waiman Long wrote:
>> On 12/2/22 05:18, Will Deacon wrote:
>>> On Thu, Dec 01, 2022 at 12:03:39PM -0500, Waiman Long wrote:
>>>> On 12/1/22 08:44, Will Deacon wrote:
>>>>> On Sun, Nov 27, 2022 at 08:44:41PM -0500, Waiman Long wrote:
>>>>>> Since commit 07ec77a1d4e8 ("sched: Allow task CPU affinity to be
>>>>>> restricted on asymmetric systems"), the setting and clearing of
>>>>>> user_cpus_ptr are done under pi_lock for arm64 architecture. However,
>>>>>> dup_user_cpus_ptr() accesses user_cpus_ptr without any lock
>>>>>> protection. When racing with the clearing of user_cpus_ptr in
>>>>>> __set_cpus_allowed_ptr_locked(), it can lead to user-after-free and
>>>>>> double-free in arm64 kernel.
>>>>>>
>>>>>> Commit 8f9ea86fdf99 ("sched: Always preserve the user requested
>>>>>> cpumask") fixes this problem as user_cpus_ptr, once set, will never
>>>>>> be cleared in a task's lifetime. However, this bug was re-introduced
>>>>>> in commit 851a723e45d1 ("sched: Always clear user_cpus_ptr in
>>>>>> do_set_cpus_allowed()") which allows the clearing of user_cpus_ptr in
>>>>>> do_set_cpus_allowed(). This time, it will affect all arches.
>>>>>>
>>>>>> Fix this bug by always clearing the user_cpus_ptr of the newly
>>>>>> cloned/forked task before the copying process starts and check the
>>>>>> user_cpus_ptr state of the source task under pi_lock.
>>>>>>
>>>>>> Note to stable, this patch won't be applicable to stable releases.
>>>>>> Just copy the new dup_user_cpus_ptr() function over.
>>>>>>
>>>>>> Fixes: 07ec77a1d4e8 ("sched: Allow task CPU affinity to be restricted on asymmetric systems")
>>>>>> Fixes: 851a723e45d1 ("sched: Always clear user_cpus_ptr in do_set_cpus_allowed()")
>>>>>> CC: stable@vger.kernel.org
>>>>>> Reported-by: David Wang 王标 <wangbiao3@xiaomi.com>
>>>>>> Signed-off-by: Waiman Long <longman@redhat.com>
>>>>>> ---
>>>>>>     kernel/sched/core.c | 32 ++++++++++++++++++++++++++++----
>>>>>>     1 file changed, 28 insertions(+), 4 deletions(-)
>>>>> As per my comments on the previous version of this patch:
>>>>>
>>>>> https://lore.kernel.org/lkml/20221201133602.GB28489@willie-the-truck/T/#t
>>>>>
>>>>> I think there are other issues to fix when racing affinity changes with
>>>>> fork() too.
>>>> It is certainly possible that there are other bugs hiding somewhere:-)
>>> Right, but I actually took the time to hit the same race for the other
>>> affinity mask field so it seems a bit narrow-minded for us just to fix the
>>> one issue.
>> I focused on this particular one because of a double-free bug report from
>> David. What other fields have you found to be subjected to data race?
> See my other report linked above where we race on 'task_struct::cpus_mask'.

So you are referring to the fact a task structure may be changed while 
it is being copied to a child process at the same time. I think it is a 
hard problem to fix as I am not aware of a way to freeze the content of 
the task structure while the copying is in progress. There are just too 
many fields in the task structures that can be changed in many different 
contexts from different CPUs.

Anyway, this dup_user_cpus_ptr() bug is not related to racing in this 
copying process, it is caused by a race after that. I think it may be 
worthwhile to put a note about possible race in the dup_task_struct() 
process but I can't think of a good way to fix it.

Cheers,
Longman