Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8728674rwb; Tue, 13 Dec 2022 09:42:18 -0800 (PST) X-Google-Smtp-Source: AA0mqf6LwiRr7j9ZBFeDwOJ6YyzeLpXyhAn4DyfXkFzcBsSv1DFEsMO69EGcvLqjqRt1sTU2FqKN X-Received: by 2002:a17:906:1441:b0:7bf:c00d:5072 with SMTP id q1-20020a170906144100b007bfc00d5072mr17858544ejc.72.1670953338105; Tue, 13 Dec 2022 09:42:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670953338; cv=none; d=google.com; s=arc-20160816; b=pHHQWRUrvyTMQ3Qphmfk0KENaMrcBMllhusdUvnVmtD+HtU8vloflnVNpkSjjyniME eKOWyYixKYibnIecp4EEEibUvN/CwpBEgLvM9qLixFaCyIGq+PlgHx6ioTAtOlMpT7o0 j1XqRb0rMGFCcHRFXd5kYnpdn/Mwsu8kSDYYniO8ialbxFA8Kp0pjjUkIcGY+L/b0KUY 70+NSiJd7AiRp2KscrXH4spzGDqVXPvsfiRTY61z/6Ki0F8TQNtwBpaNp6tR1kvACLmu MyMPVR2XF9n7BhTFISX6QmxoHlzCrlQBJ3OXU8Zo2j3nnIbgFyVPNDiZ8KUMF40W0pmT +Dyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=+gHcL0GavN66hEyQQto3Gxp/s7JccGCmVE4ksMartuc=; b=ooQJeTjqcnW+VJ+7RGOCPrGPypNG9OCYLxV7i2b2Wiv3MYxrtEu1MK1qyyjVvA7fyc PjdNnRep0muI2Qd5TEZ6NaG80zHiZvHiTj0h9VHyXTJxTUqU7KMIZmBsP2n0K1g3EPH+ uff1JF0OV0aOJsWxcUU71/eUtjwvonA5Bb6L6c6+rxr9dJ7jW7WpxcmzLEMBFcY9uJlT YvDN32DXrgcXA/rDFifkREO/4zxwkKMWIJh1W0+u9GMLHQfIeD8bLhJkCAZfPz8xUjHO tOxEvGudHv8J0lNtc619pOQA2O9r7dC7n/P0DzpBiUVS1FaP4A+G5CLnrGRgFUwqkuMb 1Spg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=svtedpfr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id re21-20020a170906d8d500b007c0fe071d9asi6801824ejb.391.2022.12.13.09.42.00; Tue, 13 Dec 2022 09:42:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=svtedpfr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235828AbiLMR2v (ORCPT + 72 others); Tue, 13 Dec 2022 12:28:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48450 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235490AbiLMR2s (ORCPT ); Tue, 13 Dec 2022 12:28:48 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47FA321273; Tue, 13 Dec 2022 09:28:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=+gHcL0GavN66hEyQQto3Gxp/s7JccGCmVE4ksMartuc=; b=svtedpfrmgRz4xaWewVFJm/yqD yqeYYjNiqllJeWMYVvO+hGpYRaoRLiwtrOCkBuiaN5D4ma8GagYKR/y3usItIh61p4SRs5FuOTCmv K8B84LSgkFMmRSUZ2fPjpdcZv3X6Hn/skU4RME/va+fXJ1nHlrdxCbWA302/9209llsZdYYnH2hCG 31l2qENg7yJ/X4MPoWpN3r7S8mCGzzA4pIL9d9i9N0BUqOKUya3gsoEpFW3ZgFJea5M4wIMJas0Ck 18jb1tkQO3d2LE8fn0MTcre9vD/rvQuVYxGY4my9+yKPCVkbhkqLLIRKFkFGGBf7cX9HKwGkyp5Ug Xc51TFIA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:35694) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p5956-0007O7-04; Tue, 13 Dec 2022 17:28:40 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1p5951-0006c0-Lf; Tue, 13 Dec 2022 17:28:35 +0000 Date: Tue, 13 Dec 2022 17:28:35 +0000 From: "Russell King (Oracle)" To: "Seija K." Cc: Stefano Stabellini , Thomas Bogendoerfer , Chris Zankel , Max Filippov , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org Subject: Re: [PATCH] arch: change variable types to match those of what is assigned to them Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: Russell King (Oracle) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 13, 2022 at 12:03:51PM -0500, Seija K. wrote: > There are many places where "int len = strlen(foo);" is written, just > for len to be passed as a parameter of size_t. This causes truncation > and then expansion back from int to size_t. Not to mention this is > poor logic and needless truncations can add extra unneeded > instructions. > This patch aims to fix the worst offenders. I didn't bother looking too closely as the patch has been severely mangled. I think you need to reconsider how you send patches and find a way to test before you send emails to mailing lists. Thanks. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!