Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 13:13:37 -0500
From:   Peter Jones <pjones@redhat.com>
To:     Evgeniy Baskov <baskov@ispras.ru>
Cc:     Ard Biesheuvel <ardb@kernel.org>, Borislav Petkov <bp@alien8.de>,
        Andy Lutomirski <luto@kernel.org>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Alexey Khoroshilov <khoroshilov@ispras.ru>,
        "Limonciello, Mario" <mario.limonciello@amd.com>,
        joeyli <jlee@suse.com>, lvc-project@linuxtesting.org,
        x86@kernel.org, linux-efi@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3 00/24] x86_64: Improvements at compressed kernel stage
Message-ID: <20221213181336.fjyxagxkjtq3jchl@redhat.com>
References: <cover.1668958803.git.baskov@ispras.ru>
 <20221213180317.qoy2l3mcpjparocq@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20221213180317.qoy2l3mcpjparocq@redhat.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

On Tue, Dec 13, 2022 at 01:03:17PM -0500, Peter Jones wrote:
> On Tue, Nov 22, 2022 at 02:12:09PM +0300, Evgeniy Baskov wrote:
> > This patchset is aimed
> > * to improve UEFI compatibility of compressed kernel code for x86_64
> > * to setup proper memory access attributes for code and rodata sections
> > * to implement W^X protection policy throughout the whole execution 
> >   of compressed kernel for EFISTUB code path. 
> 
> Hi Evgeniy,
> 
> I've tested this patch set on hardware and QEMU+MU firmware, and it
> works for me with a couple of minor issues:
> 
> - on one machine that has the DXE protocol but not the EFI one, we get
>   an error because the firmware doesn't support EFI_MEMORY_RP
> - on QEMU I'm seeing the size of "(unsigned long)_head - image_base"
>   wind up as 0, which leads to an EFI_INVALID_PARAMETER on the
>   clear_memory_attributes() call.
> 
> In both cases the system winds up working, but with unnecessary console
> output.

I just realized I've overstated here - I haven't actually hit the first
problem on x86, only on ARM, where we don't currently use this code.  I
discovered it in grub, and checked your patch set to see if you had the
same issue I did.  That said, "in both cases the system winds up
working" is probably still true - in that the edk2 code supports
EFI_MEMORY_RP on x86 but not ARM, so x86 won't hit the issue when using
DXE unless someone cooks up another implementation.  Nevertheless I
believe the patch to fix it is correct and should be applied.

Thanks!

-- 
        Peter