Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9c0e0e7c-45e4-ad65-f9a0-2eb582a62a3d@intel.com>
Date:   Tue, 13 Dec 2022 09:54:14 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.1
Subject: Re: [PATCH v4] x86/resctrl: Clear staged_config[] before and after it
 is used
Content-Language: en-US
To:     Shawn Wang <shawnwang@linux.alibaba.com>, <fenghua.yu@intel.com>
CC:     <bp@alien8.de>, <dave.hansen@linux.intel.com>, <hpa@zytor.com>,
        <james.morse@arm.com>, <jamie@nuviainc.com>,
        <linux-kernel@vger.kernel.org>, <mingo@redhat.com>,
        <tglx@linutronix.de>, <x86@kernel.org>
References: <20221209024436.22170-1-shawnwang@linux.alibaba.com>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20221209024436.22170-1-shawnwang@linux.alibaba.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?c3psUkZUaHkyZXE3UjZ2YkM3UjYzclNHaDNUdmJmQ2prTGsvdGtlaVFwc3JN?=
 =?utf-8?B?UnBISGh4Z3RFbktjSVltSzAxd09CUzZpMUJ6YXNZS3UzZ0phc0FldzMrSW1T?=
 =?utf-8?B?SmZ3MW1FSTAvSXB0cEk1ZUdVVnA3dlZ4Y3lXUHNFU3dUL2YxOWtJdGFLa3BK?=
 =?utf-8?B?THV4TFJSRk93Y2pvVFh3NU9QV1NlUktYbVI3NFo2RTFCMU96Mm55cmF3ZVFI?=
 =?utf-8?B?RW53Rk5SbmhteEhLV0dBV1lXNnVDYzM2dXZGTTkxQWlTQ0d0akhhZ05vVjJo?=
 =?utf-8?B?c0xOclJwSXRtUlZ1R1RYZE9zaTRjUVdYVzF4TUx2TkdXQ3lwNit1ZVB4a3dN?=
 =?utf-8?B?WTQrV0FQblBHaHNZMFBUb1EzV0R1R2N5V1pHZ0U3S1dLNVF2ekl1M0VVNlRv?=
 =?utf-8?B?YU9ZSExHYmQrd2M2V3RLazc1MndxUGwzRnVmMVcwOVcvMVdwa1pBeGJkMVlm?=
 =?utf-8?B?Sm5jYlFLSzU0TmRhMGhYY3NXOStzTFlBcTV4L21hNk16Z0ZENUlXU1NFKzhW?=
 =?utf-8?B?aWdQay83K2oySnpwR3VERFc5WTRtS1VER1dVZDd4b0ptWmFrVDVyRlRyYkR3?=
 =?utf-8?B?R1dHWkFHVitHVnkwV1poZVR6UjdnQzdHd1JiWmxldHp6bU5KTGcwczlOd0p4?=
 =?utf-8?B?MjZ2UUFHcGdkWWNJbW9tZUdpckQ0SFNnY1M0RFg2SG53NW9yQWpMNjdKMGJi?=
 =?utf-8?B?ZUZmVitHc2RLTmhianMwV1BJME55Zi8vK1EzeUNKOWZIbkV0UUFIcEI3NXo1?=
 =?utf-8?B?U0dnY2xWeE9ldG12cEtCV29kdWNTYVE1ek9vc0ltZTY5dzNTSWw1eFhveW93?=
 =?utf-8?B?VFVyZi9mNG5TZnJQT1RnWFVyUjNFamtYT29MY2xyaUR3dHY3ZG1Fb2pnQjFz?=
 =?utf-8?B?bGF4UUNOR1NtcHZ5VGx2RXFmZnp5OVdjaGpha2UrV2ptbXE5R0pwVmRsODI2?=
 =?utf-8?B?NEsyNGpIakFicUJlNnpDc0hsQXF3d1E3aUxCODNtVDdORlNXVDVMVVNsZkZ5?=
 =?utf-8?B?NGFjMktJVjF2SnY1Uzh2Y0ZUWm9KTklvNGg3akZTRGxBWFhhNVJET1lxUFcv?=
 =?utf-8?B?enp2bEdjcGNZWGR6RkRMTUo5eFpGRGZBTTBGT3dYUzN0U0RFQldvQlAwUkx6?=
 =?utf-8?B?Nm1LRU1yc3FOODhaWHJCaEtUaTVtaVI3UE4wYnF3TmxXaVlSMzZHODVYaFRs?=
 =?utf-8?B?OFpsMjI1ZElmRUhUMkVhOXNJU1pwdmhOM1RUUDRheUtaZFREWFRLeGpSL1FD?=
 =?utf-8?B?ejE1NUg4SC9MVEE3TkpMU09qbnpKZm8zY0xJWjVYbVRXKzFSY3hNeEdoc05s?=
 =?utf-8?B?dE9oYVMydGViMkFSM09KV2JRamVOMHhIUVJXbkxtdFowRGI4ckpucHluL1ly?=
 =?utf-8?B?TXJxZ0RrNDdzNndEaHJFbGJpSXV1ZnVkZk5VWXlCZE0wQUpjVThRcDVCek9T?=
 =?utf-8?B?VXpDY2U2bW1nVWM4Q01QWlptQUFWUVVVcGpSbDd1ZjVXUkhmanlBN01Yakgx?=
 =?utf-8?B?WWhRSGhyN0lIMHQySXdJd0t6K2pvVHZVcE9MUk51MFV4U2lwd1pDWkpodlk1?=
 =?utf-8?B?R3RVRHBNalA0VjNTdS9SRFN6b0h0S0FqbjVpWVFEWXJJeW8wMFVCOU83c3BC?=
 =?utf-8?B?RFd6Nk5tcGR4ZjlaYitST1FSazZJS1ZzcGlMQW9DSWNpMmI1VWZsaEg3Z290?=
 =?utf-8?B?TVF2ZFhZZzFXZHBzamlORTFBQ3ZUWXc1WGNIYXNHSjF4ZUJLWEwxcmtUQjJo?=
 =?utf-8?B?QWpFdGVVTjd0K2NHMXVOS3cydmRFbld3cW4rT0JVZDF6OGU2bytpQW1nTmNR?=
 =?utf-8?B?ZDRuMEE5LzhZbU1hc2xBTytoYnNMVHRPTlRVNXkwOUVXSDVWSU9oRXBBNnpF?=
 =?utf-8?B?NDRXYUJyc25GcmoxaExWN0I4ZmE5SmYvUFhqYlZLLzZZL1ZYU1JpNmZsak4z?=
 =?utf-8?B?amRjdUdpMktDTXh0bkh4OUU0U0VUTzkwYnJSNEE2bXRGc0lpSjFsUnZwZEE3?=
 =?utf-8?B?YzZjalNkdnZmcDNHcGxSenFmQ0NLRnl6Qm52cEJLRjlNMVNPdHpUVzZmdmtq?=
 =?utf-8?B?aUVNeWIyZmhPb21iY1BtcmdPd0E2Y3Y0cW9RdDJlNWM3bzJFUjMwRW40di9Q?=
 =?utf-8?B?bzViZyswMFhKb1JIZmtsQ2VEZi9JeWxXNll1dlJINjdCOVlpM1ljd3ZYMDdE?=
 =?utf-8?B?WEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9fd2293c-8ae2-4dd7-4fde-08dadd330db4
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 17:54:17.1212
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +bDmPeh70RkG62P//5HgFjHgTurP4RwGW0NqirgEKHEZMXuhGRpAg1m+CSAd+eEROgg5hS1RJnAzO4F/JIYZ5rQgueKC7731gcEA1bsezT4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR11MB5418
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_PASS,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Shawn,

On 12/8/2022 6:44 PM, Shawn Wang wrote:
> As a temporary storage, staged_config[] in rdt_domain should be cleared
> before and after it is used. The stale value in staged_config[] could
> cause an MSR access error.
> 
> Here is a reproducer on a system with 16 usable CLOSIDs for a 15-way L3
> Cache (MBA should be disabled if the number of CLOSIDs for MB is less than
> 16.) :
> 	mount -t resctrl resctrl -o cdp /sys/fs/resctrl
> 	mkdir /sys/fs/resctrl/p{1..7}
> 	umount /sys/fs/resctrl/
> 	mount -t resctrl resctrl /sys/fs/resctrl
> 	mkdir /sys/fs/resctrl/p{1..8}
> 
> An error occurs when creating resource group named p8:
>     unchecked MSR access error: WRMSR to 0xca0 (tried to write 0x00000000000007ff) at rIP: 0xffffffff82249142 (cat_wrmsr+0x32/0x60)
>     Call Trace:
>      <IRQ>
>      __flush_smp_call_function_queue+0x11d/0x170
>      __sysvec_call_function+0x24/0xd0
>      sysvec_call_function+0x89/0xc0
>      </IRQ>
>      <TASK>
>      asm_sysvec_call_function+0x16/0x20
> 
> When creating a new resource control group, hardware will be configured
> by the following process:
>     rdtgroup_mkdir()
>       rdtgroup_mkdir_ctrl_mon()
>         rdtgroup_init_alloc()
>           resctrl_arch_update_domains()
> 
> resctrl_arch_update_domains() iterates and updates all resctrl_conf_type
> whose have_new_ctrl is true. Since staged_config[] holds the same values as
> when CDP was enabled, it will continue to update the CDP_CODE and CDP_DATA
> configurations. When group p8 is created, get_config_index() called in
> resctrl_arch_update_domains() will return 16 and 17 as the CLOSIDs for
> CDP_CODE and CDP_DATA, which will be translated to an invalid register -
> 0xca0 in this scenario.
> 
> Fix it by clearing staged_config[] before and after it is used.
> 
> Fixes: 75408e43509e ("x86/resctrl: Allow different CODE/DATA configurations to be staged")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Shawn Wang <shawnwang@linux.alibaba.com>
> Suggested-by: Xin Hao <xhao@linux.alibaba.com>
> ---

Thank you very much.

Tested-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>

Reinette