Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8857508rwb; Tue, 13 Dec 2022 11:18:09 -0800 (PST) X-Google-Smtp-Source: AA0mqf7XNkbnMOC7Qhsjvkbb8DxSxI6189J3PKtSZr8hw8DEYccns1EfkFbfbqv+U3XVVpO5Q8w/ X-Received: by 2002:a05:6a00:1988:b0:577:49da:6074 with SMTP id d8-20020a056a00198800b0057749da6074mr27716300pfl.19.1670959088800; Tue, 13 Dec 2022 11:18:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670959088; cv=none; d=google.com; s=arc-20160816; b=j1Ca2g2zLFRN4rlMk0yePQx1lJJcdBegK/uKzEizhS7EnV6T1c005fxhJAG7v7aqdi iKH+6f3was6I7bACq4Zru2vQTzm0hD36g+zfj6gboUOrBxkV8fZcDlAPxCNjDNDQlgml j9kPSLlVwKt66ZPgcynKRPLzHXo4K+Suz2UvCupWKFprTZjFjo3wAkrGpyTknSoNt3Uw vsqOB9DRXIsVL82Nz6M5eoQIzyZaECGDC01oRn0EzWqe00uzuuk7INQBT1tWse5565Yz myqdkx042J0kZ/U58FmLDYAE9Q11fM1Y3MOFGkZypmRjw8oEnr80dHTVEQYPCV4lwyyu ZzfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :dkim-signature:dkim-signature; bh=+W2cKxBOJdZjf/2uoiAlpf5BlMTh6jYNUgsdvKaLvJw=; b=M38hhZ8V8kUlrJA9747gWxfcAuFEG4RJBTRQxxpF3QkmtkN1UcMc8GPdqm+uG5Ykh+ rzWFNKyrN2HfE5GcsnS92mIacmW5hI6aDV2lbsF5FxL1LRmNv2jJErnKwh+C/LQqP6xw Q5MZQaVAKf6TvswNKjiShSL2HrATdpNCRBM96b0ERRBq/YGn6sYFYZvFHH9qz3ODLVzn ySaMWEYvw2xJFuORhcVmG0fP3mKj/8xPaGymI/itLPRT6pXpiBGVVgFgyxGMm56GmdS4 rY55nbsT04iY1/RsiIbDLUMrhH1RobZWhAbvnKcmwOCgd/6NiJqCsq+Gg3EdQQFHfXeg 1grA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Px225xbk; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h9-20020a056a001a4900b0056c07a694dasi13330278pfv.158.2022.12.13.11.17.59; Tue, 13 Dec 2022 11:18:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@suse.cz header.s=susede2_rsa header.b=Px225xbk; dkim=neutral (no key) header.i=@suse.cz header.s=susede2_ed25519; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236671AbiLMSmO (ORCPT + 73 others); Tue, 13 Dec 2022 13:42:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236463AbiLMSmA (ORCPT ); Tue, 13 Dec 2022 13:42:00 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A77111097; Tue, 13 Dec 2022 10:41:59 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CF4BB1FDB4; Tue, 13 Dec 2022 18:41:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1670956917; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+W2cKxBOJdZjf/2uoiAlpf5BlMTh6jYNUgsdvKaLvJw=; b=Px225xbk76wtn5wa1gA/2JRZ5gLecTajTPZ+KKa/1z4DJ/n3SDbL/hgOoJ4/XfVhcnCzuQ hnPw/Kcubh7vf+2oCRsPVjCpL/X6EYu1+Iegljab+VJCk9Fq1pJ4T5cEA0B2jIg+Xgh4IX L3bJFA0gPegM0h37iN2E1dWfVns4nTs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1670956917; h=from:from:reply-to:reply-to:date:date:message-id:message-id:to:to: cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+W2cKxBOJdZjf/2uoiAlpf5BlMTh6jYNUgsdvKaLvJw=; b=JbLuqmK96nZI8Z86QUdWjAy0E4NT3nqmiYQS0ua2t1hTIlZdax8RHg7cbJ6SJPL1OlK45G tHSW3iRqrGQHbKBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 95328138F9; Tue, 13 Dec 2022 18:41:57 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id xIIII3XHmGMCegAAMHmgww (envelope-from ); Tue, 13 Dec 2022 18:41:57 +0000 Date: Tue, 13 Dec 2022 19:41:15 +0100 From: David Sterba To: Christophe JAILLET Cc: Chris Mason , Josef Bacik , David Sterba , Sweet Tea Dorminy , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-btrfs@vger.kernel.org Subject: Re: [PATCH] btrfs: Fix an error handling path in btrfs_rename() Message-ID: <20221213184115.GE5824@twin.jikos.cz> Reply-To: dsterba@suse.cz References: <943f0f360f221da954f5dd7f16e366d0e294ae72.1670876024.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <943f0f360f221da954f5dd7f16e366d0e294ae72.1670876024.git.christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.5.23.1-rc1 (2014-03-12) X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_SOFTFAIL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 12, 2022 at 09:14:17PM +0100, Christophe JAILLET wrote: > If new_whiteout_inode() fails, some resources need to be freed. > Add the missing goto to the error handling path. > > Fixes: ab3c5c18e8fa ("btrfs: setup qstr from dentrys using fscrypt helper") > Signed-off-by: Christophe JAILLET Added to misc-next, thanks.