Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8866801rwb; Tue, 13 Dec 2022 11:25:56 -0800 (PST) X-Google-Smtp-Source: AA0mqf5+eXZFifS3+A+mUI9c/tffQmkusi4fOKzF2Z+tVJAZga/SczEsH+/7+iOmXHoLhlxjlADf X-Received: by 2002:a17:902:bc4a:b0:189:832d:8586 with SMTP id t10-20020a170902bc4a00b00189832d8586mr23065073plz.13.1670959556188; Tue, 13 Dec 2022 11:25:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670959556; cv=none; d=google.com; s=arc-20160816; b=nejzgqN7S6U0LXg4hnTYeLDXwYxIx/KirMLHMpqmXXNw/A9xMAf7f039Bz5k+M97wg EmBVV5G0tkKO5duIZ7rVw2wvIVWozft/GvVlMR5kZ5oXMGHXxBMUTmQhr480Th61huFD vKMknbVaj5PY1Ra7MIjPW6XGZrKCT1nseIe6Ot6n6n+Mz96ISSCuAzuKVpJioEUJSQyC lCHOQydsvXkl+myjhoJx5ed1zCZzNrAq33ZH9pL0tnJ01jDyp8o6hrlP0n7ArX1gzsgx AVdepYvPeVRzG0KkFS6NCmiDgZyNRUT4sqs0uYTqDvbGXPsPlRfz8glVSE2/vew9TQDv 5G8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=gC79KdPgX8meWkHV6kEH9PpY7k/sykKi+3gQfcC9IOQ=; b=IwlFrrEbeiwVhBE+VNqTeOwx4+FDJZtxrdur+CD6MFr66IGgbs56ClT5SAu1vxk94t Iu5hkzjq798WxhPTaNoa4/1bYn6jZvm+c8iC7Wi7+kgB4YTlZQTuMh5x1wS5JgsXjRzZ M0zokRuuh8EN+6L3cfAiDKNGHcDolUBWS54PKYpTQxrX1xnf0kYi7kfS8GrZgf5nLv3b VvYLo5ov4yoX5MWjIeuY/zQfWObvy9vSeni+7QsGLupM1Zx1aQ4VRtmMpB8gfJ/YGh+U KUD2eFuxoY0L1Jin3YukGiuHxVTabsyfF4G49sIm6u8ybGWI0cAdGEIkBI2T6y2FILJw udoA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GrJhw/af"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w16-20020a631610000000b0046e96b9ecfdsi13115038pgl.801.2022.12.13.11.25.46; Tue, 13 Dec 2022 11:25:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b="GrJhw/af"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236292AbiLMSpr (ORCPT + 72 others); Tue, 13 Dec 2022 13:45:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236344AbiLMSpn (ORCPT ); Tue, 13 Dec 2022 13:45:43 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EF9F24F0D for ; Tue, 13 Dec 2022 10:45:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670957103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=gC79KdPgX8meWkHV6kEH9PpY7k/sykKi+3gQfcC9IOQ=; b=GrJhw/afHh5tSPXb6noS6xJNUuigebxVQEAiDXu4KcNNJZymo6gX8c1enDPBIsKihc8USf U9VaPCpAvVG+FmgUGLPwaoJFnB6382DUvgqte0UECpJmjH1yo5AXsDfl/9HBKuFQB8llft Hv6Wh9VJYpccItP2pH18LUzQ7MavRiU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-20-BvYR3lxsNKWZAZOxPDL65Q-1; Tue, 13 Dec 2022 13:44:58 -0500 X-MC-Unique: BvYR3lxsNKWZAZOxPDL65Q-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E6381185A78F; Tue, 13 Dec 2022 18:44:57 +0000 (UTC) Received: from llong.com (unknown [10.22.32.205]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2E9CCC15BA0; Tue, 13 Dec 2022 18:44:57 +0000 (UTC) From: Waiman Long To: Jens Axboe , Tejun Heo , Josef Bacik , Zefan Li , Johannes Weiner , Andrew Morton Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, =?UTF-8?q?Michal=20Koutn=C3=BD?= , "Dennis Zhou (Facebook)" , Waiman Long Subject: [PATCH-block v3 0/2] blk-cgroup: Fix potential UAF & flush rstat at blkgs destruction path Date: Tue, 13 Dec 2022 13:44:44 -0500 Message-Id: <20221213184446.50181-1-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org v3: - Drop v2 patch 2 as it may not be needed. - Replace css_tryget() with percpu_ref_is_zero() in patch 1 as suggested by Tejun. - Expand comment on patch 2 to elaborate the reason for this patch. v2: - Remove unnecessary rcu_read_{lock|unlock} from cgroup_rstat_css_cpu_flush() in patch 3. It was found that blkcg_destroy_blkgs() may be called with all blkcg references gone. This may potentially cause user-after-free and so should be fixed. The second patch flushes rstat when blkcg_destroy_blkgs(). Waiman Long (2): bdi, blk-cgroup: Fix potential UAF of blkcg blk-cgroup: Flush stats at blkgs destruction path block/blk-cgroup.c | 22 ++++++++++++++++++++++ include/linux/cgroup.h | 1 + kernel/cgroup/rstat.c | 18 ++++++++++++++++++ mm/backing-dev.c | 8 ++++++-- 4 files changed, 47 insertions(+), 2 deletions(-) -- 2.31.1