Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp8871792rwb; Tue, 13 Dec 2022 11:30:39 -0800 (PST) X-Google-Smtp-Source: AA0mqf5X7hkLM8IRVQdPg3FLv8nDLJakAwuSGzmz6Jg5sNBYyd9VQO9oHMcK2fdptmvo+uLj+gCI X-Received: by 2002:a17:907:d008:b0:7ad:8a7a:1a44 with SMTP id va8-20020a170907d00800b007ad8a7a1a44mr19099111ejc.47.1670959839268; Tue, 13 Dec 2022 11:30:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670959839; cv=none; d=google.com; s=arc-20160816; b=FEaCTwmopdYeBuZV8u2R3LmJ67/ZiBy+BCsCZ/sOB5Fmy+F6Ul4hEem/HQFmqFVQzt Nx294r3cBQMg1gkuKlcnMd+ynNAKjSPNB9qH8gKGpOoEfqd/O4Enfs9XvfkQ5+akoM43 M+DW3pNDH5PyBLBdMZQPJzy8AMYl0DaYqTfzcWLMNi+Td/bYW+tTpgS3CmrboaYGq9lb ZxVpi7MiX/iWKRlWefCrcl+HvRAxT4gTQTIgLtuudu3VJ713E5D7EuUDXZyM5ZbEEQ/d DufgxRs2J7IFcRzCsHKpMACTf0kNWBCwhHcTJk5qboa4kVPRuFqm8xVqJ1/kbq8U8qs6 sGJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=V+Ey6+x0DiQeXB+HxcsVQeqMn4lDNI2M51+RkCxiEq0=; b=kbuge9ML/WqaODwgV0x2BYwXh8P9Hn2/VkKkLjvZubI5qAZbPRVH6rMiFo9pGxLk1j AEB0TMEpkZg7b7ogpSn34nmzpVqV/oE7C6Nc8qyt4MWlIhzmk7/kXFz7mmRnv8Q3vnGC /+IY+yCRq8k+Klx8wZrHAqExm0NIR+6ywf1XelA+w6CarA5dD6XX0g8nlJdaTN6lTMcF lQGAFz1BbwoKMwUD8PasfCcGqAQL6Sl7O3IpvsGYOuPF2H64VqwdlizyC6c7b7XqNf4n HfXF4IBOWsL6SRj4+1E6tyz5lZQ4KvLDoA3N+SnepHjvVNjdnt21N+qQ7Zx0D40GR3vf UkaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c3hwuUoT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ec48-20020a0564020d7000b0046a7f3ddb8csi8761689edb.523.2022.12.13.11.30.21; Tue, 13 Dec 2022 11:30:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=c3hwuUoT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236905AbiLMTR5 (ORCPT + 73 others); Tue, 13 Dec 2022 14:17:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60622 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236872AbiLMTRf (ORCPT ); Tue, 13 Dec 2022 14:17:35 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68445120A8 for ; Tue, 13 Dec 2022 11:17:33 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E767AB815B1 for ; Tue, 13 Dec 2022 19:17:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65B4CC433EF; Tue, 13 Dec 2022 19:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670959050; bh=oQXZwLpEHai9jIJPJXjlwzNaTMDa9dkWWo0SoGbc+jw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c3hwuUoTS1nYS74nAYE15G6ufa1d8mbLQGLmD0fIG3cSe19dTDwanL2uGifbWSDQA 6Dnn+NMMr4QtV4gse2Jsjb0y5gPXG3ixDuEEBCSXAlIlkq2ni+KPgKGGlBle2vCrNc 7ZKlPNkCnsV5CojmO7mSa61aOiNgpgbYd6oi8TPrFYZv8Hh7+iAJtpaSyRTq2yDU3P kl1vtvkeXvL5cAjPARciDVEWFfFyXHWB4SFt4HAX9zYYXMV+x7zzN/UvtifQTs4ami uHqdk8UNPxzVZ6g+YRFjyXoGAmCBhW/Hz2wlV5WL7NDcT2di2SfNGPtpvtj5ge/yzu +EKgtvV0EudxQ== Date: Tue, 13 Dec 2022 11:17:28 -0800 From: Jaegeuk Kim To: Yangtao Li Cc: chao@kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] f2fs: add support for counting time of submit discard cmd Message-ID: References: <0cc89bf7-ea7c-d6e9-5ba9-548181de4c82@kernel.org> <20221213122121.18685-1-frank.li@vivo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221213122121.18685-1-frank.li@vivo.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/13, Yangtao Li wrote: > Hi Jaegeuk, > > >>> Again, w'd better to consider this functionality only when DEBUG_FS > >>> is enabled. > >> > >> BTW, why can't we use iostat to get the discard latencies? > > > > Agreed. > > Let me spend some time on this. So, I guess this patch can't catch up with the merge window. > And I still have some patches that have not been picked, can you take a look, hope they can > catch up with the window. > > How long is the 6.2 merge window left and when will you send the f2fs 6.2 pull request? I cut off the patches for this merge window. Please consider next release. BTW, could you please send a patch set instead of random posts? It's quite hard to find which one was merged or not. Thanks, > > Thx, > Yangtao