Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   SeongJae Park <sj@kernel.org>
To:     Kefeng Wang <wangkefeng.wang@huawei.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        David Hildenbrand <david@redhat.com>,
        Oscar Salvador <osalvador@suse.de>,
        SeongJae Park <sj@kernel.org>, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, damon@lists.linux.dev,
        vishal.moola@gmail.com, willy@infradead.org
Subject: Re: [PATCH -next 8/8] mm: damon: remove unneed damon_get_page()
Date:   Tue, 13 Dec 2022 19:26:33 +0000
Message-Id: <20221213192633.138774-1-sj@kernel.org>
In-Reply-To: <20221213092735.187924-9-wangkefeng.wang@huawei.com>
References: 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi Kefeng,

On Tue, 13 Dec 2022 17:27:35 +0800 Kefeng Wang <wangkefeng.wang@huawei.com> wrote:

> After all damon_get_page() callers are converted to damon_get_folio(),
> remove unneed wrapper damon_get_page().
> 
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
>  mm/damon/ops-common.h | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h
> index 4ee607813981..35a2e42a27da 100644
> --- a/mm/damon/ops-common.h
> +++ b/mm/damon/ops-common.h
> @@ -8,13 +8,6 @@
>  #include <linux/damon.h>
>  
>  struct folio *damon_get_folio(unsigned long pfn);
> -static inline struct page *damon_get_page(unsigned long pfn)
> -{
> -	struct folio *folio = damon_get_folio(pfn);
> -
> -	return &folio->page;
> -}
> -
>  void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr);

Let's keep the one blank line before damon_ptep_mkold().

>  void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr);
>  
> -- 
> 2.35.3

Thanks,
SJ