Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 11:12:07 -0800
From:   Dan Williams <dan.j.williams@intel.com>
To:     <ira.weiny@intel.com>, Dan Williams <dan.j.williams@intel.com>
CC:     Ira Weiny <ira.weiny@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Lukas Wunner <lukas@wunner.de>, <linux-pci@vger.kernel.org>,
        <linux-acpi@vger.kernel.org>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        Dave Jiang <dave.jiang@intel.com>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>
Subject: RE: [PATCH V4 1/9] PCI/CXL: Export native CXL error reporting control
Message-ID: <6398ce8773383_b05d12941d@dwillia2-xfh.jf.intel.com.notmuch>
References: <20221212070627.1372402-1-ira.weiny@intel.com>
 <20221212070627.1372402-2-ira.weiny@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20221212070627.1372402-2-ira.weiny@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Fg/E140xPddk9OT1FjdLtYmVJEwF3BqOljo/nQQWEHqFJX+AvsA3ABGnNtaA?=
 =?us-ascii?Q?t4Ludhj7IYZ+VFVsahSjiMmq6FJuIkJoEKD+jIcpRcSdrDVgCOy68V41XyoM?=
 =?us-ascii?Q?M0JVBchrVzjJQjlIhwgYXBUpCr8KgzIQl6MX+s10+7ZbVJWUp0ryssw0LwMW?=
 =?us-ascii?Q?bTV3dc9FBA2d8YpAUUfP6pPZ0Y4/ux8RaSgrnUbLVqvHArlO/xYCWbDeWuPh?=
 =?us-ascii?Q?HH07sir8C/bYekNqW5DB6+xxZtFRjHznEUTlIQQwYzoCFu4uk1Itw2ACu56s?=
 =?us-ascii?Q?k0XKRwrvMC6xu2ppFw4PdwPwbIANvgFiwhRDb+Pyi7hh0La/9sYq3zEslYE5?=
 =?us-ascii?Q?O1HZ9sMBG1nFpc10LXr4geW0wTUigelxHND92wqwAZIDs5hMfkSkb+S9f5iB?=
 =?us-ascii?Q?hH5EgWJp2InqjuokeG/nm7Qjf5L9TFYEfrhi4v890PqSOUCGBcy+P6RRvAHT?=
 =?us-ascii?Q?e5KnB8zyKQXkRNTGjwpS7EvkbJ3yTN24x0N2NCNndSJZ1XBmS8njPDKn/SXC?=
 =?us-ascii?Q?Hd9d8bDG1PzLUjC0mzFgacJMcoKD27dgWRwCpuScNdc0nF6GlLPt9yh+bkvp?=
 =?us-ascii?Q?AycWPj9f4vlBxZRo10l97M7/2ufq5l0psBCByBozABHk7+mUSPeGfzjsbEd1?=
 =?us-ascii?Q?oNzCvHXQpCURAX6ungVMK30fpksOPjj5FP3mb3Ya/IGtB0JbpPDl2oYnscux?=
 =?us-ascii?Q?/GLQU70FKRoPhbaGUdGCcKic3n7BTODI5q2V0RHtT8Jh8URVTBXtRW1zeCdR?=
 =?us-ascii?Q?BVe+rRnpNI/OslUAWVA02Wra8OPS1DwkhMGlxxbi6s4EaQG/AslZIAK+vJSz?=
 =?us-ascii?Q?I24Ecp/L3TjiU9EAdYLpso+rWyUoAeEok7qQWdJ3Q2+DFLGkeJ5Ovxc67os1?=
 =?us-ascii?Q?9lIyJ/ZCeoS5wFXi4hf+v02M6o5Fsz2XHfsjBYOqiWQzKtaiAeK0T+1CsAmB?=
 =?us-ascii?Q?3HKYjtX/MgVs36CVwXR27TbW5dl/BIycX/auttohpt0cNEzV7nsESJCBink+?=
 =?us-ascii?Q?3+EUGHctKA4JxSXNOqaipiZPF7F5ZvIpg2kmYP2G91FQO9np5o7db4J/cKJn?=
 =?us-ascii?Q?NST2BDJH662VJy20r7rjl1agfGVSGvtrHFpbgfUxWEcOapM7ShxwlnP2prLM?=
 =?us-ascii?Q?fZ0NbTxoExM32wMCH3A94UOO0yeidOjg3YvjPdh12zk5OjNgZtsznH/0hDo5?=
 =?us-ascii?Q?JeZNYA+g0ssb9QLY16YoExSk4+VlKaFe65uKFmkJ9oGWuzismHZikQsJeKzV?=
 =?us-ascii?Q?H3z+OMUbTvySSo9z7G4RvTPIwjww22KGucsd9N8A2dUvEMFcEGcQbDyzP7Nk?=
 =?us-ascii?Q?8Fv3AwjjMAGA2owm/SQFqr62YhwkDnywDeeNyAlYWUIXo6tbZfjHT2csLI0H?=
 =?us-ascii?Q?XZ+SNryj9lfPP0CNIMmRbb2658CAt/Rlv/PMEiQRHUk0v86PUBGV1TKkAzlR?=
 =?us-ascii?Q?ZHGEptITaU59/1mSHVfxzlQzEO0LLqy/8XRQaH+DM35z/tCYGQ2NRnY0RYr9?=
 =?us-ascii?Q?nQqx8UH50P2YzNda+w2etsxMSZPwsB5w4Sb1Ve8xQYNGniCX3soaQ3lvmXL5?=
 =?us-ascii?Q?90/iXxBbCNMRJdX8GSiGk2jiH5e7AcYam3RCQBBPCYJbnJ7+WU7TnVH2JZDW?=
 =?us-ascii?Q?aA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a5633cf6-75ee-4254-a525-08dadd3defaf
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2126.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 19:12:11.2386
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: +51uY0cQM59HaqSWl1h/Z8KZzFtyxxtxrJiMT8eEoEKwzQpdpjJecgRm8jaKGsTsN0vRUw9hN+i9lCEoN+OTOnEmKTavTh3OisfRS+D96Uk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB5888
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

ira.weiny@ wrote:
> From: Ira Weiny <ira.weiny@intel.com>
> 
> CXL _OSC Error Reporting Control is used by the OS to determine if
> Firmware has control of various CXL error reporting capabilities
> including the event logs.
> 
> Expose the result of negotiating CXL Error Reporting Control in struct
> pci_host_bridge for consumption by the CXL drivers.
> 
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Lukas Wunner <lukas@wunner.de>
> Cc: linux-pci@vger.kernel.org
> Cc: linux-acpi@vger.kernel.org
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>

Looks good to me,

Reviewed-by: Dan Williams <dan.j.williams@intel.com>

> 
> ---
> Changes from V3:
> 	New patch split out
> ---
>  drivers/acpi/pci_root.c | 3 +++
>  drivers/pci/probe.c     | 1 +
>  include/linux/pci.h     | 1 +
>  3 files changed, 5 insertions(+)
> 
> diff --git a/drivers/acpi/pci_root.c b/drivers/acpi/pci_root.c
> index b3c202d2a433..84030804a763 100644
> --- a/drivers/acpi/pci_root.c
> +++ b/drivers/acpi/pci_root.c
> @@ -1047,6 +1047,9 @@ struct pci_bus *acpi_pci_root_create(struct acpi_pci_root *root,
>  	if (!(root->osc_control_set & OSC_PCI_EXPRESS_DPC_CONTROL))
>  		host_bridge->native_dpc = 0;
>  
> +	if (!(root->osc_ext_control_set & OSC_CXL_ERROR_REPORTING_CONTROL))
> +		host_bridge->native_cxl_error = 0;
> +
>  	/*
>  	 * Evaluate the "PCI Boot Configuration" _DSM Function.  If it
>  	 * exists and returns 0, we must preserve any PCI resource
> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
> index 2f4e88a44e8b..34c9fd6840c4 100644
> --- a/drivers/pci/probe.c
> +++ b/drivers/pci/probe.c
> @@ -596,6 +596,7 @@ static void pci_init_host_bridge(struct pci_host_bridge *bridge)
>  	bridge->native_ltr = 1;
>  	bridge->native_dpc = 1;
>  	bridge->domain_nr = PCI_DOMAIN_NR_NOT_SET;
> +	bridge->native_cxl_error = 1;
>  
>  	device_initialize(&bridge->dev);
>  }
> diff --git a/include/linux/pci.h b/include/linux/pci.h
> index 1f81807492ef..08c3ccd2617b 100644
> --- a/include/linux/pci.h
> +++ b/include/linux/pci.h
> @@ -577,6 +577,7 @@ struct pci_host_bridge {
>  	unsigned int	native_pme:1;		/* OS may use PCIe PME */
>  	unsigned int	native_ltr:1;		/* OS may use PCIe LTR */
>  	unsigned int	native_dpc:1;		/* OS may use PCIe DPC */
> +	unsigned int	native_cxl_error:1;	/* OS may use CXL RAS/Events */
>  	unsigned int	preserve_config:1;	/* Preserve FW resource setup */
>  	unsigned int	size_windows:1;		/* Enable root bus sizing */
>  	unsigned int	msi_domain:1;		/* Bridge wants MSI domain */
> -- 
> 2.37.2
>