Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <3dd48267-d31d-5b4a-3c16-5b186d85988a@intel.com>
Date:   Tue, 13 Dec 2022 11:22:46 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [PATCH v7] igb: Assign random MAC address instead of fail in case
 of invalid one
To:     Lixue Liang <lianglixuehao@126.com>, <kuba@kernel.org>,
        <linux-kernel@vger.kernel.org>
CC:     <jesse.brandeburg@intel.com>, <davem@davemloft.net>,
        <edumazet@google.com>, <pabeni@redhat.com>,
        <netdev@vger.kernel.org>, <lianglixue@greatwall.com.cn>,
        kernel test robot <lkp@intel.com>
References: <20221213074726.51756-1-lianglixuehao@126.com>
Content-Language: en-US
From:   Tony Nguyen <anthony.l.nguyen@intel.com>
In-Reply-To: <20221213074726.51756-1-lianglixuehao@126.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dGVpbVVoZ2hQOFZWS051WjlSQ0UwUkcxb2pwWUIvVGNwbVhTZUc0bFhUNm9y?=
 =?utf-8?B?blhseExFblF3MCtRRklESnFoUVFFQmJXYloweDlNUG9HVWtjRkwrQTBxdWdM?=
 =?utf-8?B?aGYzSVgxNTRpYUVwMHVEaEl0bFFBWmhtdmdiOGt4dmlGS1RNY1V0SkVOaktD?=
 =?utf-8?B?MENGTmc2WWpVYjcrcDJuWjh6N3dnUDkzRnpONjFhSUxVMkZiSmFadGhsNTZv?=
 =?utf-8?B?UVR3emp0KzhPMk05MHRadlVsWW9OYUpESWlTdEVTSzBwc0NDZFFqeWkrT2dD?=
 =?utf-8?B?TWFXMEFrZHE1Vng5aVhNMDBURXF0THJnMzU1NDBDUkJaU2ZKcHhlbUFQNzdT?=
 =?utf-8?B?UG56bEwxTDdSYmd4NnNXN01qSFh3ai8xVGhXeG16a0Y1NzdGMVJLejllK2xX?=
 =?utf-8?B?Y2NGTllkWTVBOXVYVm1BWVV1MFZIV0w0Qm0zL1VwSHB3TzJlbWhQNjBXTmJi?=
 =?utf-8?B?YjhWOG1xVU5lS3RPQXJtZGg5TXgxb0VlTngxbXRSa01LOTlGOVNvSm1LTkNh?=
 =?utf-8?B?eGFsWUk3WmU4MmQvMEdCL1BNY1dPUkpGVUlnTlRxRTZpckNQMU1KblBnUnJo?=
 =?utf-8?B?YUhJUTAxZmZzRi9XMWR3ZkFhaW1rM1pGeGI5TW16L281cWxqck9BcTFHLzFV?=
 =?utf-8?B?QjVCV3htcytLOHdMc1Z2VDN4WFQ2S1RNTkRibUEzM1ZSaXdiem5xQytyWVZ2?=
 =?utf-8?B?dlhBNGNUUzFtbkVrdkNGYVFibktvb21FWTRqL05tVVlQTDFuOWZISjVVUUY2?=
 =?utf-8?B?aUZGbm5qcTdEeENLWWp2eDFLM2tqVGQzeEl1bUVxanZkTjE0Y211RGpsM3NB?=
 =?utf-8?B?RDZYblVVOGswbmI4Y21PRFJ5b1VRcTlhamx0cXRDVVlrVWFEeUV1bDVteDcv?=
 =?utf-8?B?R3RZVTlSVGYxTGxkSEJ4ait1dXpGUmIwK3pIZEdaZEczdDB6MHhHMUhHOTQ4?=
 =?utf-8?B?QlhTNC9TQkVHTXhka2F4NUw4d1FHdS9jYUVxcGV0Uk14OGQrM2JqajJ0RHRm?=
 =?utf-8?B?RXlKKzNGZkVvQVNORjJxWUwrdHlBQks3akRHeUFrekY4ejVnRTJvRGFZTEF5?=
 =?utf-8?B?MjBRUTg5c2pXTVhUb1p0QlczdDFvK0x5TTg5UXV1QUptSjBVTW5uZ3lockJW?=
 =?utf-8?B?bnpNWXk5TW1MNkVVU3VKMUJYNDQ3U1VscDdZTVFCdElYblpJQnZhbVp2N3dW?=
 =?utf-8?B?RkhVVXVZVGQzTEJNRHpjT3VYazc1ejR0VGh6MTVxc3RTNUZJcjVSZ3ptUTZX?=
 =?utf-8?B?WTdEZ3djUWUwQ3J1S2tsVlQ0S3JEc3hnbk04WHlrQzgzT3pZcmE0dElqMWZ0?=
 =?utf-8?B?NkVDOG9kZUhCcDFSL0ozcmpRUTYwcWowcWZqcXNxRDVEbEljUnJOa3ZHSUd4?=
 =?utf-8?B?Z1ZWWDViaHNrVVhScmxLcEJleVIyeG5mVXFGWWh5azZnMlVNOUswRmhXSVYv?=
 =?utf-8?B?Rys1czhEbFlTZ0JtN1BWdDg2eXVHd1d1eVBQdlZaa2R5b3E5ZzdPOGo3SmdF?=
 =?utf-8?B?elFuQStpaWF2RXZMbXN1aER5bW1DMUFXd01WL1MwU1BrT2hoV3NVS1ZOcGh6?=
 =?utf-8?B?ZUV5T1JVemU3cTF6Y29PczluazZScGJBRFlxV3cxSWxJQ1U1UWFscW1CUGh3?=
 =?utf-8?B?NVBMMzBacktQWUdBRktORTVUWGNCbjNlM1d3MUdXZXJGQkhucHM1eDFLTHIr?=
 =?utf-8?B?OWlvYjFzQXdxOGtFRERXcDFsMjBKWFYxY3VzSnNJVDdXZ3NyaExqWTBZTFVE?=
 =?utf-8?B?SlA0WENVMGwzeDNYeTdta2pDY0NaTjNubmJGeklXblJPaGRGbDRxTVVXOHM2?=
 =?utf-8?B?ZGQ5NDRYT3FmUTF3T1VuUUdseGMwSzEvK1h4UWFGUElZeGY0ajNzNTRkMTNj?=
 =?utf-8?B?SUhIbU9wbkIyUVN6bXcyd0VVL094K2RXRUg0WnRIanNRUXBYTGlQdElUWE11?=
 =?utf-8?B?R0ZySTBjSHl0b3ZEMnFlSVlTMk1qS29hMEdYOXdNaHE5UC90VmVqeVRJL0lk?=
 =?utf-8?B?Z2hJNzVpT3hiN0ErUS9CZHM0R0JOQXpGb3lTNElDZG5OcU9GMFRYQTdpMGtB?=
 =?utf-8?B?OFpOUHdRSDdzVzdQNERtdUdMckFERGJoMlRTeFNKRERXemUrSVNRd1dQSDVP?=
 =?utf-8?B?Z0VKVkxnWFZJZ25BK1R1b3JTdTZ5L1FWcVlBRkdFOStkZXJubGllT1NmZW5s?=
 =?utf-8?B?SEE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 584b5d9b-0688-4813-32ab-08dadd3f72d9
X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB3229.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Dec 2022 19:23:00.7736
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: yzEjLi+UHZAWyu3hhSAbkQBvzey/jY507RtI76P4Pef6Mnr2mm/lxu0zoM1+4SKn0n3oJj9JjISuSw/JUwUNv0exjSTFKusoLMD+bzs7D9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB7510
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/12/2022 11:47 PM, Lixue Liang wrote:
> From: Lixue Liang <lianglixue@greatwall.com.cn>
> 
> Add the module parameter "allow_invalid_mac_address" to control the
> behavior. When set to true, a random MAC address is assigned, and the
> driver can be loaded, allowing the user to correct the invalid MAC address.

Please include Intel Wired LAN, intel-wired-lan@lists.osuosl.org, for 
Intel ethernet driver patches.

> Signed-off-by: Lixue Liang <lianglixue@greatwall.com.cn>
> ---
> Changelog:
> * v7:
>    - To group each parameter together
> Suggested-by Tony Nguyen <anthony.l.nguyen@intel.com>
> * v6:
>    - Modify commit messages and naming of module parameters
>    - [PATCH v6] link:
>      https://lore.kernel.org/netdev/20220610023922.74892-1-lianglixuehao@126.com/
> Suggested-by Paul <pmenzel@molgen.mpg.de>
> * v5:
>    - Through the setting of module parameters, it is allowed to complete
>      the loading of the igb network card driver with an invalid MAC address.
>    - [PATCH v5] link:
>      https://lore.kernel.org/netdev/20220609083904.91778-1-lianglixuehao@126.com/
> Suggested-by <alexander.duyck@gmail.com>
> * v4:
>    - Change the igb_mian in the title to igb
>    - Fix dev_err message: replace "already assigned random MAC address"
>      with "Invalid MAC address. Assigned random MAC address"
>    - [PATCH v4] link:
>      https://lore.kernel.org/netdev/20220601150428.33945-1-lianglixuehao@126.com/
> Suggested-by Tony <anthony.l.nguyen@intel.com>
> 
> * v3:
>    - Add space after comma in commit message
>    - Correct spelling of MAC address
>    - [PATCH v3] link:
>      https://lore.kernel.org/netdev/20220530105834.97175-1-lianglixuehao@126.com/
> Suggested-by Paul <pmenzel@molgen.mpg.de>
> 
> * v2:
>    - Change memcpy to ether_addr_copy
>    - Change dev_info to dev_err
>    - Fix the description of the commit message
>    - Change eth_random_addr to eth_hw_addr_random
>    - [PATCH v2] link:
>      https://lore.kernel.org/netdev/20220512093918.86084-1-lianglixue@greatwall.com.cn/
> Reported-by: kernel test robot <lkp@intel.com>
> 
>   drivers/net/ethernet/intel/igb/igb_main.c | 17 ++++++++++++++---
>   1 file changed, 14 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index f8e32833226c..8ff0c698383c 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -241,6 +241,10 @@ static int debug = -1;
>   module_param(debug, int, 0);
>   MODULE_PARM_DESC(debug, "Debug level (0=none,...,16=all)");
>   
> +static bool allow_invalid_mac_address;
> +module_param(allow_invalid_mac_address, bool, 0);
> +MODULE_PARM_DESC(allow_invalid_mac_address, "Allow NIC driver to be loaded with invalid MAC address");
> +
>   struct igb_reg_info {
>   	u32 ofs;
>   	char *name;
> @@ -3358,9 +3362,16 @@ static int igb_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
>   	eth_hw_addr_set(netdev, hw->mac.addr);
>   
>   	if (!is_valid_ether_addr(netdev->dev_addr)) {
> -		dev_err(&pdev->dev, "Invalid MAC Address\n");
> -		err = -EIO;
> -		goto err_eeprom;
> +		if (!allow_invalid_mac_address) {
> +			dev_err(&pdev->dev, "Invalid MAC address\n");
> +			err = -EIO;
> +			goto err_eeprom;
> +		} else {
> +			eth_hw_addr_random(netdev);
> +			ether_addr_copy(hw->mac.addr, netdev->dev_addr);
> +			dev_err(&pdev->dev,
> +				"Invalid MAC address. Assigned random MAC address\n");
> +		}
>   	}
>   
>   	igb_set_default_mac_filter(adapter);