Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20221213104333.27548-1-konrad.dybcio@linaro.org>
References: <20221213104333.27548-1-konrad.dybcio@linaro.org>
Subject: Re: [PATCH] clk: qcom: dispcc-sm6115: Shrink single-parent definitions
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     marijn.suijten@somainline.org,
        Konrad Dybcio <konrad.dybcio@linaro.org>,
        Michael Turquette <mturquette@baylibre.com>,
        linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Konrad Dybcio <konrad.dybcio@linaro.org>, agross@kernel.org,
        andersson@kernel.org, krzysztof.kozlowski@linaro.org,
        linux-arm-msm@vger.kernel.org
Date:   Tue, 13 Dec 2022 14:24:19 -0800
User-Agent: alot/0.10
Message-Id: <20221213222421.7B112C433D2@smtp.kernel.org>
Precedence: bulk

Quoting Konrad Dybcio (2022-12-13 02:43:33)
> @@ -284,12 +268,13 @@ static struct clk_rcg2 disp_cc_mdss_vsync_clk_src =
=3D {
>         .cmd_rcgr =3D 0x20a4,
>         .mnd_width =3D 0,
>         .hid_width =3D 5,
> -       .parent_map =3D disp_cc_parent_map_1,
>         .freq_tbl =3D ftbl_disp_cc_mdss_esc0_clk_src,
>         .clkr.hw.init =3D &(struct clk_init_data){
>                 .name =3D "disp_cc_mdss_vsync_clk_src",
> -               .parent_data =3D disp_cc_parent_data_1,
> -               .num_parents =3D ARRAY_SIZE(disp_cc_parent_data_1),
> +               .parent_data =3D &(const struct clk_parent_data){
> +                       .index =3D DT_BI_TCXO,
> +               },
> +               .num_parents =3D 1,
>                 .flags =3D CLK_SET_RATE_PARENT,
>                 .ops =3D &clk_rcg2_shared_ops,

Is clk_rcg2_shared_ops and clk_rcg2_ops prepared for a NULL
'parent_map' pointer? _freq_tbl_determine_rate() is never called?