Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 19:33:42 -0300
From:   Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To:     Ian Rogers <irogers@google.com>,
        Athira Rajeev <atrajeev@linux.vnet.ibm.com>
CC:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Jiri Olsa <jolsa@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-perf-users@vger.kernel.org, bpf@vger.kernel.org,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH 2/3] perf build: Use libtraceevent from the system
User-Agent: K-9 Mail for Android
In-Reply-To: <CAP-5=fVVPDo_3cjKmumEVKDN2Zssz-ZU=nYVQFNr1xUGHxx-PQ@mail.gmail.com>
References: <Y491d1wEW4TfUi5f@kernel.org> <Y4921D+36UGdhK92@kernel.org> <Y494TNa0ZyPH9YSD@kernel.org> <Y498YP2N3gvFSr/X@kernel.org> <C9F248C8-AF8D-40A1-A1AD-BCC39FBA01C7@linux.vnet.ibm.com> <Y5DNBZNC5rBBqlJW@kernel.org> <36CD1041-0CAE-41C1-8086-C17854531B3E@linux.vnet.ibm.com> <Y5JfgyN59dSeKbUP@kernel.org> <Y5Jl8MeW90DXy1wT@kernel.org> <8F6F0C27-53F3-4837-A19C-845768253249@linux.vnet.ibm.com> <Y5cxyk3OdgFXlyhS@kernel.org> <BB236C92-3505-4DAB-AE28-A55F74EDE161@linux.vnet.ibm.com> <CAP-5=fVVPDo_3cjKmumEVKDN2Zssz-ZU=nYVQFNr1xUGHxx-PQ@mail.gmail.com>
Message-ID: <927374FD-C6C0-42B3-9F93-5379A5898FB3@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On December 13, 2022 7:09:07 PM GMT-03:00, Ian Rogers <irogers@google=2Eco=
m> wrote:
>Thanks Athira and Arnaldo=2E It is a little strange to me to be using
>the shell to do a version number test=2E The intent was to be doing
>these in the code:
>#if LIBRTRACEEVENT_VERSION >=3D MAKE_LIBTRACEEVENT_VERSION(1, 5, 0)
>vs
>=2E=2E=2E
>LIBTRACEEVENT_VERSION_WITH_TEP_FIELD_IS_RELATIVE :=3D $(shell expr 1 \*
>255 \* 255 + 5 \* 255 + 0) # 1=2E5=2E0
>ifeq ($(shell test $(LIBTRACEEVENT_VERSION_CPP) -gt
>$(LIBTRACEEVENT_VERSION_WITH_TEP_FIELD_IS_RELATIVE); echo $$?),0)
>CFLAGS +=3D -DHAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE
>endif
>=2E=2E=2E
>#ifdef HAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE
>I'm a little selfish as I'm maintaining a bazel build and a single
>version number to maintain is easier than lots of HAVE_=2E=2E=2E tests=2E=
 I'm
>happy to follow Arnaldo's lead=2E I think the test should also be
>greater-equal rather than greater-than:
>https://git=2Ekernel=2Eorg/pub/scm/libs/libtrace/libtraceevent=2Egit/tree=
/include/traceevent/event-parse=2Eh?h=3Dlibtraceevent-v1=2E5#n128

I'll fix that, and in a case like this please consider to send a patch wit=
h your preference, I'd happily
graft it=2E

- Arnaldo=20
>