Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <a32b21a9a624b39f150fbb66677aa7a5db527aa1.camel@gmail.com>
Subject: Re: [PATCH v2 net-next 1/3] net: dsa: mv88e6xxx: change default
 return of mv88e6xxx_port_bridge_flags
From:   Alexander H Duyck <alexander.duyck@gmail.com>
To:     "Hans J. Schultz" <netdev@kapio-technology.com>,
        davem@davemloft.net, kuba@kernel.org
Cc:     netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        open list <linux-kernel@vger.kernel.org>
Date:   Tue, 13 Dec 2022 14:38:41 -0800
In-Reply-To: <20221213174650.670767-2-netdev@kapio-technology.com>
References: <20221213174650.670767-1-netdev@kapio-technology.com>
         <20221213174650.670767-2-netdev@kapio-technology.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4 (3.44.4-2.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Tue, 2022-12-13 at 18:46 +0100, Hans J. Schultz wrote:
> The default return value -EOPNOTSUPP of mv88e6xxx_port_bridge_flags()
> came from the return value of the DSA method port_egress_floods() in
> commit 4f85901f0063 ("net: dsa: mv88e6xxx: add support for bridge flags")=
,
> but the DSA API was changed in commit a8b659e7ff75 ("net: dsa: act as
> passthrough for bridge port flags"), resulting in the return value
> -EOPNOTSUPP not being valid anymore, and sections for new flags will not
> need to set the return value to zero on success, as with the new mab flag
> added in a following patch.
>=20
> Signed-off-by: Hans J. Schultz <netdev@kapio-technology.com>
> ---
>  drivers/net/dsa/mv88e6xxx/chip.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx=
/chip.c
> index ba4fff8690aa..d5930b287db4 100644
> --- a/drivers/net/dsa/mv88e6xxx/chip.c
> +++ b/drivers/net/dsa/mv88e6xxx/chip.c
> @@ -6546,7 +6546,7 @@ static int mv88e6xxx_port_bridge_flags(struct dsa_s=
witch *ds, int port,
>  				       struct netlink_ext_ack *extack)
>  {
>  	struct mv88e6xxx_chip *chip =3D ds->priv;
> -	int err =3D -EOPNOTSUPP;
> +	int err =3D 0;
> =20
>  	mv88e6xxx_reg_lock(chip);
> =20

Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>