Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 13 Dec 2022 17:02:25 -0800
From:   Mike Kravetz <mike.kravetz@oracle.com>
To:     Nico Pache <npache@redhat.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        muchun.song@linux.dev, akpm@linux-foundation.org,
        willy@infradead.org, gerald.schaefer@linux.ibm.com,
        sidhartha.kumar@oracle.com
Subject: Re: [RFC V2] mm: add the zero case to page[1].compound_nr in
 set_compound_order
Message-ID: <Y5kgoTVteXm0QFgT@monkey>
References: <20221213234505.173468-1-npache@redhat.com>
 <Y5kPKpNp5qCnZEWy@monkey>
 <CAA1CXcB653kDtF90oWUgVA3TDUrJHac-WPe1HdsQtRwtN5B3gA@mail.gmail.com>
 <CAA1CXcDK=bpAbmkwyssja9d7eA3iEtNQ2aNaQo4DkdjV3YvOVA@mail.gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAA1CXcDK=bpAbmkwyssja9d7eA3iEtNQ2aNaQo4DkdjV3YvOVA@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?x+3bMpKxx9aZHm8/dHgA5tz8/xtqpg36fgf6rcWogKhIe1fV3AMuKlov7ecn?=
 =?us-ascii?Q?Dhgh0evXlLpaVYo8agS0YMv759frIPPbkB3ev9/UyYqP0G5keYnDODms702V?=
 =?us-ascii?Q?KsbAghKyjA76pv0xpAcccJCguTellqRnDArT5oXwGkLH8OITBmENzvOTO3vl?=
 =?us-ascii?Q?7z37T7CWd/4SOtW1UizJRC0FN5O0SpId+FTEK4ihDh+u0QhVDFtCUpmyeqEk?=
 =?us-ascii?Q?l8EiZwyUhdw66s4w8JjN0pZZqnzXJG2Hy59Tz63QCLwx5KLe+7bwQZQzlXs0?=
 =?us-ascii?Q?ZSap6c9X9S82NidChWUw9Ip8IdlpXJ/y9FoOBkVGL/Nih1y1w6vzp6R5CGUR?=
 =?us-ascii?Q?GonRPfa+zJGX0BUo+ZyCjBPWc4yfNenz51GnlBoLfTTinU1pUhJX/lMPscII?=
 =?us-ascii?Q?7Rq6A6P+5aHFVnjlnQ8uWssn51djTs9iA1VT72pC4UwXJxCOtbidEpw+4LZW?=
 =?us-ascii?Q?UgcnR9nHeMWtf/RzKzqnajYNtq5gZcHwgVcbBw5q+qJat1x5qG2xv50qt/GA?=
 =?us-ascii?Q?eNDJdciPXVB9PsNT0qKdsADrFLGp/htCdSG3MUx6jte9hAfvh9ng3oXuGtQN?=
 =?us-ascii?Q?pIzhDgBylmwiPqo0VdXK6QSvb06P/4q42x1njcKeGxGbKuFUYjWhxVeyKP5K?=
 =?us-ascii?Q?D6I5X+ZwDipVGVdw1Lw8daQXg/OLoeWkeecTmirmJkdBTd0nOlWs8v6ZDFUW?=
 =?us-ascii?Q?88CLGluLmd8AmmGEJ1aNjy/RtRslKSiWVAoM0DSjyc9GHD/930FaoIaUIj76?=
 =?us-ascii?Q?FJxV0kqwXwydnWpNg1KTsEFNO1HXJCrPo7mfyeRFU5GqZwd1Zd5EGz7VFTWU?=
 =?us-ascii?Q?e04g9DdnXxnBOOOBj4Y5VB91ZSNqcyE55CHN77WKwA1MsreWG0P576bvA9Uz?=
 =?us-ascii?Q?pqLAuWloRZxk1rkJMhQCQ7g+l+RwtwvP9SzXMGPV/bNJNZQM8KO1ZU0QDWXb?=
 =?us-ascii?Q?8sD29pk2nKDV0EOeNPm1LQkuyLlK5M/1UJZlYMDPllMquW8/DH9dFFBkULyC?=
 =?us-ascii?Q?uU3Yz0wnH0Wzx1ATmTV3g5C0+x5OQb73gUP+zj88Gct/HZ1qg5CnLJ89Sqof?=
 =?us-ascii?Q?yyf8UHfilXDL89mF2rxcU5b4HmkTx1zOuPuP+obBSP4Q+4n23bfbQietbM1M?=
 =?us-ascii?Q?mSzmpf4fYnZHeL0lfweOZ31786MISDQHAFMCb9ivMOE/cIUk9SyPeiU+bkCc?=
 =?us-ascii?Q?2zQ9qXrss9Wu47Ltx1hOt9Ha84Em5UiNIPRLgsb5k24TnxDCnoqaMSpMJkDn?=
 =?us-ascii?Q?Wa+g+22SV4bkacNpNHmHIs5hVS8bzD5c5NztxIgsCyag+f7H4x/CKyi0iwyX?=
 =?us-ascii?Q?WMQGYvwKp9dTNmX3Tj8//WVpnUy40Ijbt1e/fqxEU7VPvh7eaY6k8qEDEhz/?=
 =?us-ascii?Q?Qh6EwKRg7/8bRpf8ZUqK9H3WyiSzBHEQKOs5f/Qv/ICjH4C8kYb78Gl3Pr7q?=
 =?us-ascii?Q?As+OpKmi/Eq5XJTkYDNq7r4jYT3toERph4y2GATvrx1dIbb2J4gFE7Rz8LZu?=
 =?us-ascii?Q?y6Tp0bol2mUKbr1zGaQ7LasEVT9XHzDzub2+uHtIuOXjB0bDxM8blaWr5+y8?=
 =?us-ascii?Q?45BFc38leSlDtuMWycPMgO+g254IqIqw9dQ585VPFS2DY5SsFJpCw9qGdP+j?=
 =?us-ascii?Q?Pw=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bec2442d-8f9a-4fd5-6222-08dadd6edea6
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4196.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 01:02:28.0901
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KACEz7ejZHV8iax8IGsfukq944dKd4mzLpO+CktlvGerjg+B283aiLyFnctJJJOHx/rbaBapT2/ShzBcfbTIbw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN4PR10MB5606
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-13_03,2022-12-13_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 mlxlogscore=998 suspectscore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212140005
X-Proofpoint-GUID: LHuzE2SRxoUta4mGKGc8FiKwl-CeiaN2
X-Proofpoint-ORIG-GUID: LHuzE2SRxoUta4mGKGc8FiKwl-CeiaN2
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/13/22 17:27, Nico Pache wrote:
> According to the document linked the following approach is even faster
> than the one I used due to CPU parallelization:

I do not think we are very concerned with speed here.  This routine is being
called in the creation of compound pages, and in the case of hugetlb the
tear down of gigantic pages.  In general, creation and tear down of gigantic
pages happens infrequently.  Usually only at system/application startup and
system/application shutdown.

I think the only case where we 'might' be concerned with speed is in the
creation of compound pages for THP.  Do note that this code path is
still using set_compound_order as it has not been converted to folios.
-- 
Mike Kravetz