Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20221213081103.2182231-1-jun.nie@linaro.org> <Y5jKfdDrJkdKtEbC@sol.localdomain>
In-Reply-To: <Y5jKfdDrJkdKtEbC@sol.localdomain>
From:   Jun Nie <jun.nie@linaro.org>
Date:   Wed, 14 Dec 2022 09:33:41 +0800
Message-ID: <CABymUCMtTmSiZQNV9tXTYp90Jk3M37QiF4z5UbrukB43wSx-mw@mail.gmail.com>
Subject: Re: [PATCH] fscrypt: Fix null pointer when defer i_crypt_info
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     tytso@mit.edu, jaegeuk@kernel.org, linux-fscrypt@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Eric Biggers <ebiggers@kernel.org> =E4=BA=8E2022=E5=B9=B412=E6=9C=8814=E6=
=97=A5=E5=91=A8=E4=B8=89 02:54=E5=86=99=E9=81=93=EF=BC=9A
>
> On Tue, Dec 13, 2022 at 04:11:03PM +0800, Jun Nie wrote:
> > syzbot report below bug[1]. Fix it with checking null pointer before
> > deferring i_crypt_info.
> >
>
> Thanks, but this has already been fixed upstream by commit 105c78e12468
> ("ext4: don't allow journal inode to have encrypt flag").
>
> Also, I don't think adding a NULL check to __fscrypt_inode_uses_inline_cr=
ypto()
> is a good idea because it is only meant to be called when the inode's enc=
ryption
> key has already been set up.  Instead of making the function return a
> potentially-incorrect result, it was better to address the root cause of =
why it
> was being called at an inappropriate time in the first place.
>
> - Eric

Thanks for the information! Do you know what's the plan/schedule of
back porting,
such as linux-5.15.y branch?

- Jun