Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <b2ada465-8eec-a7e3-0265-df9d0e8492d2@gmail.com>
In-Reply-To: <b2ada465-8eec-a7e3-0265-df9d0e8492d2@gmail.com>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Tue, 13 Dec 2022 17:48:59 -0800
Message-ID: <CAMo8Bf+8Bn7pNNbBbXgphfe41Kxx7cHb9LTtBexy15mpL8hKuw@mail.gmail.com>
Subject: Re: [PATCH] arch: change variable types to match those of what is
 assigned to them
To:     Seija Kijin <doremylover123@gmail.com>
Cc:     sstabellini@kernel.org, tsbogend@alpha.franken.de,
        chris@zankel.net, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org,
        linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Seija,

On Tue, Dec 13, 2022 at 4:51 PM Seija Kijin <doremylover123@gmail.com> wrote:
>
> There are many places where "int len = strlen(foo);" is written, just for len to be passed as a parameter of size_t.

[...]

> diff --git a/arch/xtensa/platforms/iss/console.c b/arch/xtensa/platforms/iss/console.c
> index 10b79d3c74e0..3159917ffd2f 100644
> --- a/arch/xtensa/platforms/iss/console.c
> +++ b/arch/xtensa/platforms/iss/console.c
> @@ -64,7 +64,7 @@ static int rs_write(struct tty_struct * tty,
>   static void rs_poll(struct timer_list *unused)
>   {
>       struct tty_port *port = &serial_port;
> -    int i = 0;
> +    size_t i = 0;

This is not what happens here at all.

-- 
Thanks.
-- Max