Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp308439rwb; Tue, 13 Dec 2022 18:04:26 -0800 (PST) X-Google-Smtp-Source: AA0mqf7AbZGtrCZwep6prjVrqVbje4XuuZoOf95+m7xzu47oWGsSz0F2NuUTJvvUfZtZjt6Q7Q31 X-Received: by 2002:a05:6402:4512:b0:45c:835c:c6ef with SMTP id ez18-20020a056402451200b0045c835cc6efmr15275548edb.32.1670983465979; Tue, 13 Dec 2022 18:04:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670983465; cv=none; d=google.com; s=arc-20160816; b=02STIFmnmU2RH8IE9kfbz0ZBBSPii12p9vGviaPrT/M+G0HRUgK22jh+nsqEWPTA8V d4qoS+e+TyXzUII1rb+dWfWRYOFkd3pcyeCkZm/TVGQ9m49KqP7UBUvdSYqHQ0/sFQt9 5DHj8R7q5ypwQaORfNqXDPcZ8/6bqjBm32kwZJD+qIx+iAvxKanTYh759tj8Zf7NxAUN wwTFcaN/APHbY0HSqLX39t9w0ffqJ2e5wFnh2TKeY/j76T2llwqL6lEN3IqmITzbNayl 6W97krmjkqiMttSZIsXn36Ayprigxc3kKN4b+bG7luOSSgkpSnavhReWdslWj57UwP1x mIIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=x9ki/DHkerz+mRbn0EfXE5VSdibPij8VUIomKAKYtBQ=; b=RjvI61L1vqqrNHNSKzk0fAz2m1cqP/5WVoHf7aDFxluxqvWojlihKUPfLUH7bLgb6R anYe9hSgbs0NQys8d5MCA82Zoz3GKVrE3DjPuHc7FpUiW5hwrA8SqmgI2Y5JRjx295zB l0t/kLegfs4E4lfL8aGW2FtYenLvke8Ljz1p+9c26GfuXvpcAawqUmp+UdEhrAKCgLRA F7vI6xP55lwA+e9jWL606N7FfVNIldIz7JyRmrB14N3rpV81szwl6RvfKTIEhJ6ZzGvX jl7sdEY137Kf4tgUDB1knz/BENkBFYcxYPNL3zG//uiGX4zfRW1vOEyBFJhpkl2qdX3c ds3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZagSLMGj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dr14-20020a170907720e00b007c09bc6a8bfsi9664780ejc.250.2022.12.13.18.04.07; Tue, 13 Dec 2022 18:04:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ZagSLMGj; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236949AbiLNBsR (ORCPT + 73 others); Tue, 13 Dec 2022 20:48:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54452 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236937AbiLNBsP (ORCPT ); Tue, 13 Dec 2022 20:48:15 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F2291AF23; Tue, 13 Dec 2022 17:48:14 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 466F2B815FC; Wed, 14 Dec 2022 01:48:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81C2AC433D2; Wed, 14 Dec 2022 01:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670982491; bh=aUZevh1kIs5Dt8FUXbDMGDAUlWhmCSkHl9KCN/N7Pyw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZagSLMGjBaKb1yD3mkqbTmD6fruWqqwaMkU1GBBK1HSwgIAHaTuV+wDFiOohYlg/w k0PcM25F52TCY3qEdnnYCnCNVTgAFuJNhOsWsdp8jE/IguFiEE1kOUZvcLmWu55BQa sjMGWH6IDiiYPQSgALaxZMb1aIK7qMFgVvJj+w7jIYrhG9/u/TIQyQK3zd6F0Omca6 6cQwx1ZCaSJE+OWmKHObaBO7M/PPt+PkJLsA0cKC3LfP16uQZIAm26Sgg83EHdempw r8XiFABPF2h5Y8XH8HloljYjhDaRGK8mKPVQ0sGRSfcNTkOhssh6dV3iAkCESAZhnh d9gNC5/RdOIxA== Date: Tue, 13 Dec 2022 17:48:10 -0800 From: Jakub Kicinski To: "Seija K." Cc: =?UTF-8?B?QmrDuHJu?= Mork , "David S. Miller" , Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: Fix for packets being rejected in the xHCI controller's ring buffer Message-ID: <20221213174810.553b0196@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 13 Dec 2022 12:40:52 -0500 Seija K. wrote: > Signed-off-by: Seija Kijin You need to update the Author / the From field as well as the sign-off. > No empty lines between tags. > Co-Authored-By: TarAldarion We need sign-offs for co-authors. Please take the "must be your real legal name" requirement seriously, we mean it. > diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c > index 554d4e2a84a4..39db53a74b5a 100644 > --- a/drivers/net/usb/qmi_wwan.c > +++ b/drivers/net/usb/qmi_wwan.c > @@ -842,6 +842,13 @@ static int qmi_wwan_bind(struct usbnet *dev, > struct usb_interface *intf) > } > dev->net->netdev_ops = &qmi_wwan_netdev_ops; > dev->net->sysfs_groups[0] = &qmi_wwan_sysfs_attr_group; > + /* LTE Networks don't always respect their own MTU on the receiving side; > + * e.g. AT&T pushes 1430 MTU but still allows 1500 byte packets from > + * far-end networks. Make the receive buffer large enough to accommodate > + * them, and add four bytes so MTU does not equal MRU on network > + * with 1500 MTU. Otherwise, usbnet_change_mtu() will change both. > + */ > + dev->rx_urb_size = ETH_DATA_LEN + 4; > err: > return status; The patch is still pooped, please try with git send-email.