Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH 1/3] tty: serial: fsl_lpuart: disable the CTS when send break signal
Date:   Wed, 14 Dec 2022 11:11:35 +0800
Message-Id: <20221214031137.28815-2-sherry.sun@nxp.com>
In-Reply-To: <20221214031137.28815-1-sherry.sun@nxp.com>
References: <20221214031137.28815-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?RfkaSgxLTwUzhhit6Q25C7kigO3bMSvyDd63oRWlTt/aAq+Dw1CV70WgLD3c?=
 =?us-ascii?Q?POQHIvUHLXfqHWCBHks9/1iQCx7qHpSdpO0atCdDXB8PRZytwUNBngzExIU9?=
 =?us-ascii?Q?kFEgLtu+e7fC4iTjqDI1k2zNeqtjX/QGP35f9ogYYRzEkm99r8M6b/GwP3pN?=
 =?us-ascii?Q?0Y/OZgLcmS5RcrzzkvdzjLCXhiSUeHqVpoQTW2/eQ8Z31rJHLPg40laMH5hT?=
 =?us-ascii?Q?eBDUJaeIfBvw8/3ar4/+GE1dFTbPuH4zk0ewXqRMtU502HZTdrWq7cxUJlpX?=
 =?us-ascii?Q?G55oJttad9qkH3BfQth4hqnVGBM/nY0c5kJvzLffsHsWSp/y5qaNGwN1wOEb?=
 =?us-ascii?Q?YRq2g/r8OTcEArD2Z2qHoJC89megc7FIDSl0GPyIhI7AASvIKectD9JRIQkH?=
 =?us-ascii?Q?CTuoHP4+F/4CznVnLyB8d9CrDQhgi7eDJiUetXnmWCuydRK8A3Q5T0XOvSZH?=
 =?us-ascii?Q?JOxJOtWyuLlQ6ygx4PofMZAwpvYIvKMvwhcDOGXd6mcCEMLtxH3ioDjxfkma?=
 =?us-ascii?Q?PzBqhpexCYcxurahYii3yKLT4P2JDOLaN9kkJ/ncAlr7d5p2EkwBQGuV9cZr?=
 =?us-ascii?Q?oohJf+6cKQEtmZSd/dWXPbl7gIGXmhfml4Iu6caKgwsMSxlnoXz4Xh+IekX7?=
 =?us-ascii?Q?D7NvQa4o745OjZioU9ATnnO6tBnrwYmCzod9qU/UW7pHrHv0vw77O5Hi1DPo?=
 =?us-ascii?Q?pKKC/GQHnAOYJ+MyhDKFx0qJ3zmbF9joVsEUkTJUT0cBWyZqA8ewGFNa+t3a?=
 =?us-ascii?Q?XF7Ltw0myhngZjhQFMjb1vB3RMd3fJTIt8VZ1QN8/w7X/jCbT7F1ruVMpwPT?=
 =?us-ascii?Q?+qDtzgIOv7GKRzHg1CHArZucImq9e5qISLSerqboWBcmwOx516Ruj0mUYmGJ?=
 =?us-ascii?Q?5t+Ct6ui+u+YkHsTfVgWNRurUUBjbjsCT9SBnP78B+nEDYiaAz/gkFMLohAk?=
 =?us-ascii?Q?Y8CKGSK9EjNnTfVvhM6+IvOIahgdjsHSQHl5H0UEBig+udMrhA2KbPuPACoF?=
 =?us-ascii?Q?QMoWOPeAIBdqeJwYC2n8i40SKHZvEeCoC75I1qagr34sLvpcGkMxiA976FFd?=
 =?us-ascii?Q?aBcVcRs6G8ArszDxiacGEkNc6dJKE/LoA2NlhLCNZJGGOtGuStW2phyELL70?=
 =?us-ascii?Q?QHc0Qk2YNqBzCzeM3SDoSiI65NnipG79oAOUYlIP2g+aaXziR20vb8l8+XyP?=
 =?us-ascii?Q?dCnY7vuvaJORGHLai4f6IVcw3Rddh/u7m9uIf4s2SXQaZQoqbZ0PVVdlonIV?=
 =?us-ascii?Q?2Hy3Q+Y7BiHGrh7w+qKVL11/ZHxxHfjVFc9LM6I1pxWuj2tshAAQIOX11rdv?=
 =?us-ascii?Q?OWrhMU/9wb4x4n+cmBFDG//7dhh31sv6x7fLm3L6KLGha+R6xssk9bY9RmE0?=
 =?us-ascii?Q?93utHU0+c/FQD1VW2eAGvBbI3V0ACqEVFj6dfyGkspssL9SGXcLqBPEr+tD3?=
 =?us-ascii?Q?IXXPe0FZKARowl391iILRTJnbRDi5mHJie8Zb3XJrVQjqC6XB3AArRnIF8RX?=
 =?us-ascii?Q?zm8tbw0/ORBRR8xV4gGjb+Dc0Bzw47mrZb5wsGJS+p4NHGSVMC4gOcSFlWP0?=
 =?us-ascii?Q?APVwL5/dNNmgPosTO30xm/NAE9N2kZwPN/MEj0Fj?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: de5d7df3-40f1-4ecc-703f-08dadd813881
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 03:13:49.7060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sL+ESSSfn5secDYBfdqz2IRgMHiFlmHtrEZwlXxVntLFooyC1hRIgB+MXhllNQtPePJe9R4z1QSM0g1pzMgI1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8316
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

LPUART IP has a bug that it treats the CTS as higher priority than the
break signal, which cause the break signal sending through UARTCTRL_SBK
may impacted by the CTS input if the HW flow control is enabled.

Add this workaround patch to fix the IP bug, we can disable CTS before
asserting SBK to avoid any interference from CTS, and re-enable it when
break off.

Such as for the bluetooth chip power save feature, host can let the BT
chip get into sleep state by sending a UART break signal, and wake it up
by turning off the UART break. If the BT chip enters the sleep mode
successfully, it will pull up the CTS line, if the BT chip is woken up,
it will pull down the CTS line. If without this workaround patch, the
UART TX pin cannot send the break signal successfully as it affected by
the BT CTS pin. After adding this patch, the BT power save feature can
work well.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/fsl_lpuart.c | 24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)

diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c
index bb12b328e224..f487d3d2effe 100644
--- a/drivers/tty/serial/fsl_lpuart.c
+++ b/drivers/tty/serial/fsl_lpuart.c
@@ -1464,12 +1464,32 @@ static void lpuart_break_ctl(struct uart_port *port, int break_state)
 
 static void lpuart32_break_ctl(struct uart_port *port, int break_state)
 {
-	unsigned long temp;
+	unsigned long temp, modem;
+	struct tty_struct *tty;
+	unsigned int cflag = 0;
+
+	tty = tty_port_tty_get(&port->state->port);
+	if (tty) {
+		cflag = tty->termios.c_cflag;
+		tty_kref_put(tty);
+	}
 
 	temp = lpuart32_read(port, UARTCTRL) & ~UARTCTRL_SBK;
+	modem = lpuart32_read(port, UARTMODIR);
 
-	if (break_state != 0)
+	if (break_state != 0) {
 		temp |= UARTCTRL_SBK;
+		/*
+		 * LPUART CTS has higher priority than SBK, need to disable CTS before
+		 * asserting SBK to avoid any interference if flow control is enabled.
+		 */
+		if (cflag & CRTSCTS && modem & UARTMODIR_TXCTSE)
+			lpuart32_write(port, modem & ~UARTMODIR_TXCTSE, UARTMODIR);
+	} else {
+		/* Re-enable the CTS when break off. */
+		if (cflag & CRTSCTS && !(modem & UARTMODIR_TXCTSE))
+			lpuart32_write(port, modem | UARTMODIR_TXCTSE, UARTMODIR);
+	}
 
 	lpuart32_write(port, temp, UARTCTRL);
 }
-- 
2.17.1