Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
To:     John Garry <john.g.garry@oracle.com>
Cc:     jejb@linux.ibm.com, martin.petersen@oracle.com,
        dgilbert@interlog.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: scsi_debug: Delete unreachable code in
 inquiry_vpd_b0()
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1a63qel53.fsf@ca-mkp.ca.oracle.com>
References: <20221213142122.1011886-1-john.g.garry@oracle.com>
Date:   Tue, 13 Dec 2022 22:09:51 -0500
In-Reply-To: <20221213142122.1011886-1-john.g.garry@oracle.com> (John Garry's
        message of "Tue, 13 Dec 2022 14:21:22 +0000")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wn9rEP+KLXaCs7dFZqVg1r3XT5TBogg3Zqwd0v4/5ObuTsr4NuGF3kUNB1qL?=
 =?us-ascii?Q?qGHGvRgdRf8Vrec4OemV74AV7g+B3kRUoXgLVv/t9Rkh3sBIMi/y8xmDsnio?=
 =?us-ascii?Q?hEM1wlIN9d8CL/AGd4dmTE+8UGqwXTyWZ61HnUd1DXh8SNaN0NlTAHiAn8kD?=
 =?us-ascii?Q?R0MNxGrkzd5TZG3GKG51xNUesuN3EbDYk3/sKiWm1F3UYJiPRWIrF/3iAdPM?=
 =?us-ascii?Q?MvbNrxI5YO7VpiYc2F+MvTXisx/RMZrzq55DbijKYVkvUfbcEWt2kTnRGtLU?=
 =?us-ascii?Q?nnfpIfQwiNu2GTi6LnspZPNB03QI+zHi1mx06Pp0AUxuS/WS8HzVFHwrOaQk?=
 =?us-ascii?Q?W7FrDX047SDlSYv2YuRINDxxdeFOUu+EnREbdkSMdbQHrriUcQ7FQScw4i/J?=
 =?us-ascii?Q?il4WKN4omQazDraiDu2gRCpu9EmA9zXMs9jP7ypT3uSLfIF0DVH44O69HHws?=
 =?us-ascii?Q?0cwaTsCHZV8yyn3fFpmgM2VMJxTg7zuxQFrhhNjbVjdtQG8/gd2bj2x3f0Zk?=
 =?us-ascii?Q?MdzgVW4qFFHOREzjYgIdHBIDfk+LYG0dMFY445bHq6fME7qXB/+fV5EZ598x?=
 =?us-ascii?Q?0YzhSLWCWrTiiA9gWD7rCMFEMkxisfppq6fQbxbELys9csD6hdS6hHRxWoSk?=
 =?us-ascii?Q?ZMtfBUUM6X7+3143P2X4plj+Se23Ge/c3H8UMf1Pou8zFz49WDnl3gN94E9a?=
 =?us-ascii?Q?p5Q96TdXt37dJByK5FeqU3vqnR6KXC+LAtBfT60Z7hy4czymznACz1+v7TgN?=
 =?us-ascii?Q?8UUsYcbhQJvtF56aAlY+nNaBr06lFt6JtZedH1UL1Jtkj3DcqHClcab1evqi?=
 =?us-ascii?Q?Fb6BbuqbpRhv10StaiHg2Ki490WyYxg62rFk21j59ELsyLKGxfX4QRLrLw+q?=
 =?us-ascii?Q?qu3n6+MrlyoXUYhwj2MYubushU4lOkFDMNJ/nub1nEN0WqQViMgKQTEvTo+S?=
 =?us-ascii?Q?YnjnkDwVYY26wTC/hHOt1SuKOl+8PuxcNQv/v1ASenMp0HHsp70H76Jvhp3x?=
 =?us-ascii?Q?qyO6cFtev4ufrD+SxnmheM2untUUU65721Blcu3+ZB0V/z5PLoXt1n5XF3DY?=
 =?us-ascii?Q?tCBQi/tkyk0io2n9ewmPUwjxw39wGK33dxd0+PIfVQiWL96kMKCpJuZRyyd0?=
 =?us-ascii?Q?C2nZrhthuCTyyG3zkyfRaDjsxoj2bjPf5h+lLTHOvr5wxcT9sZAZGEeDT69N?=
 =?us-ascii?Q?fvViEhIGaqVPRVM7I2ZxafQ2tPVmnYEiKJnSi+OrwkuMwekPdME1wDvbNr42?=
 =?us-ascii?Q?LvInZryrKBYGuGO3uVE94OB+ke5j0n8APTvKBhyYhEwTh5XgV4RZ2E2qK7fe?=
 =?us-ascii?Q?gJkXjOS70hKH9oJkofXbLW8boapk14nxbwqjjJt1r1nts9/QUPvD9MAvzbgc?=
 =?us-ascii?Q?cgSXobbCexm15kdUyqAl0wdgwLcmiUZRN2eA6bbMutfBeGWPrCsYBvTNa/8E?=
 =?us-ascii?Q?op6wu/WpL3TseULFPtV491dfombaeI1ZVx/xmsrD3y38e0JBKa/3+dVplK/Y?=
 =?us-ascii?Q?LEL5rZQzXwgxyUf9btGY9X/CIoCPita1t9Ws0q1Lb9EeCVFqxdtXp1YLtyOZ?=
 =?us-ascii?Q?AwtRZqn1TVC6T7vhEWJGo7HSaLUVw2K+M+/7QIQiyLBqpPGHHY4Kpc9UJYC8?=
 =?us-ascii?Q?kQ=3D=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ca9760b1-182c-4461-56d9-08dadd80aba9
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 03:09:53.3618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fb+ZEpOevZlGqV0qTBA1+YE/IIryYvJ40Jm9YS9JXHZy7oByTO6X/HHsm4seM/R4zADuJO/yQkA6yuvQsCQ8glm+P9kPgKKVrECKYkbDsH0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6829
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.923,Hydra:6.0.545,FMLib:17.11.122.1
 definitions=2022-12-13_10,2022-12-13_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0 bulkscore=0
 suspectscore=0 mlxscore=0 mlxlogscore=999 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000
 definitions=main-2212140023
X-Proofpoint-ORIG-GUID: 4j24_JJsgCwpD7S6JVHypadprD1fwL5w
X-Proofpoint-GUID: 4j24_JJsgCwpD7S6JVHypadprD1fwL5w
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


John,

> The 2nd return statement in inquiry_vpd_b0() is unreachable, so delete it.

Applied to 6.2/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering