Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Sherry Sun <sherry.sun@nxp.com>
To:     gregkh@linuxfoundation.org, jirislaby@kernel.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-imx@nxp.com
Subject: [PATCH 3/3] tty: serial: imx: disable the break condition when shutdown the uart port
Date:   Wed, 14 Dec 2022 11:11:37 +0800
Message-Id: <20221214031137.28815-4-sherry.sun@nxp.com>
In-Reply-To: <20221214031137.28815-1-sherry.sun@nxp.com>
References: <20221214031137.28815-1-sherry.sun@nxp.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?tfDYCHQHHm5SR6tpHmbbkwUrjNIGU0OUbwbrRLfMAbDHxPX2ME35bTNqRGwH?=
 =?us-ascii?Q?mUzNmIB0JGEznlMy4YGg1r+Ma96qxQQ5v6P4E3lkJpXR0j1297NDaa5pyfm0?=
 =?us-ascii?Q?z98+lmonyHBiQ1eJIMgeAES8Lap/3mgueg1DBWFqvkV/8p5cphmtDHy5fyAf?=
 =?us-ascii?Q?wD7vbeAE6cnM08MyahuQNRKqCwboejhdOcHtv4mo6GONOOApjzTSyrFpUT37?=
 =?us-ascii?Q?4yoJu4/dT4Pd/xnyOyyfUvF4dK1Xn7+B8NsbJWWVDzVFV62ne3j+RNubtduB?=
 =?us-ascii?Q?MdIPlIJMH5hSDTHdCbQgo7QADWuvucgRESYDiYyrXLvUE2q3Xc8d4W+NESrc?=
 =?us-ascii?Q?6C7/qoJDjFyi9F4SfkdZUfjUs/AWPWPfyFVCz1jm+3CiFiDMumbka2UefVzc?=
 =?us-ascii?Q?GTUsp2OcmAjMIgqYWdgw1frUtOmkaCPlRCuC0jaSpFJc8fEWe5OU4YaayhzL?=
 =?us-ascii?Q?wrc6dYEZ+z93bNALuSKkfcYUvKncPjyJj5vH6GzKTmPiAPyEfrRs6GMcdKTf?=
 =?us-ascii?Q?zl1eM9b+X6AlY6xkOkcIy2ytBMAmOgOml8UKM5UWyalGPWONoZ62yHJwv4xX?=
 =?us-ascii?Q?2uiZlMNk+BXmPBdGXvVy3/TK6RaeuOI+D6OBvJOZ9TJN3n3N8NiMF0URl/+M?=
 =?us-ascii?Q?SC5IRItJ/xLb2ag1MscROAUmq/aFQh40aBzFaRpmL2KKv6e+BTSFNgrkwROY?=
 =?us-ascii?Q?7aVZ1RyQzEqDL2idVyfZutGdq+jmLzTiM7mIRwtQAm69vprioP3O7Eqy4msW?=
 =?us-ascii?Q?VFdhnepbF3w0kByDZfDLfBk1WtOrlgPJyvrpHUHhR2HcVxbowyRAbp0K4Gei?=
 =?us-ascii?Q?RARKznjOMwY+PujxnyzmQDf+4gCiX6NLQHoJjOhAAHU6yBBZ9Vh7ZEOwfm2d?=
 =?us-ascii?Q?lhlQBWZVtN903/HT4C4qXVIjKs1chvPajV7BDk02W6SD6i2iPBY4DpN/YaRv?=
 =?us-ascii?Q?ncgcW+hgMZHf/OCxBOf0jX1nLpn65WwhP6yFJB83Z7vZ3tiorV8KmOq3IzLT?=
 =?us-ascii?Q?QC4ED6rAKoh4p2pT6p9c2+M9PeQC0C4DqUp+jOxBzMzGbw4SJPsgUIxtFP+T?=
 =?us-ascii?Q?tOuxqpYH4gJR7OxirBSXL2iRv1H5q8KncoYjxvhGLJc0I1btryXZdy4nmgSU?=
 =?us-ascii?Q?FSn4BH2ufl9gDMePcA+rN2/SJAlEqIBqlS0/XbUX6O7cuTfoYY26ZPJE3o8M?=
 =?us-ascii?Q?4h7Waf3k3LFjO9nqo3xzyQygCWtaqiQcAriKVEownbo0qyLLWA5ukpbir0Dr?=
 =?us-ascii?Q?r+8SslI1viZ9RcipZ9O7gmvzIp24qkBXEx/9Bg+oDcve9ACk9vfo5wz+2w5l?=
 =?us-ascii?Q?LThSbMSZkshmG+g7TV+cE4p5cF9RRJyLfqRm43UWjaeF5vz/wZhqKKY54Y/q?=
 =?us-ascii?Q?9YeYXslcDoO7wPC16AWj5FxjE4db3bNz6+WPyBsW/pFWghWGhFvLlWYyiFdm?=
 =?us-ascii?Q?gdsQ93lswSUSrUb0Oc5KxPhh17obT5wiMjomycbESJOtv8aUSZv+BtC0U15l?=
 =?us-ascii?Q?IcdauDesBuZQKHMMAT7SMSnOjBheAzBZ8m7SH1bUNJPxRCDe6zWT5ne3PCMP?=
 =?us-ascii?Q?nGKzHPHrGKKcmXrauiS83/z3oZ/ZzIwo8FaaRdcx?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c84fdd24-ae7b-46db-4ccb-08dadd813d6a
X-MS-Exchange-CrossTenant-AuthSource: AS8PR04MB8404.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 03:13:58.0835
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nOXE1OjpiVSNeBNZu9JjRBbD0Vx7wAhLqiDx3rOdTLda0KVXONco9WWsg3UWFfk3MfAcD7Yc0InxzvdKiWH7tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR04MB8316
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The comment in imx_uart_shutdown() says to disable the break condition,
but it doesn't actually do that, here fix this by disabling UCR1_SNDBRK
when closing the uart port like other uart drivers do.

Signed-off-by: Sherry Sun <sherry.sun@nxp.com>
---
 drivers/tty/serial/imx.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
index 757825edb0cd..74c9e68fc3bd 100644
--- a/drivers/tty/serial/imx.c
+++ b/drivers/tty/serial/imx.c
@@ -1564,7 +1564,8 @@ static void imx_uart_shutdown(struct uart_port *port)
 	spin_lock_irqsave(&sport->port.lock, flags);
 
 	ucr1 = imx_uart_readl(sport, UCR1);
-	ucr1 &= ~(UCR1_TRDYEN | UCR1_RRDYEN | UCR1_RTSDEN | UCR1_RXDMAEN | UCR1_ATDMAEN);
+	ucr1 &= ~(UCR1_TRDYEN | UCR1_RRDYEN | UCR1_RTSDEN | UCR1_RXDMAEN |
+		  UCR1_ATDMAEN | UCR1_SNDBRK);
 	/* See SER_RS485_ENABLED/UTS_LOOP comment in imx_uart_probe() */
 	if (port->rs485.flags & SER_RS485_ENABLED &&
 	    port->rs485.flags & SER_RS485_RTS_ON_SEND &&
-- 
2.17.1