Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 10:23:37 +0700
From:   Bagas Sanjaya <bagasdotme@gmail.com>
To:     "Derek J. Clark" <derekjohn.clark@gmail.com>
Cc:     linux@roeck-us.net, Jean Delvare <jdelvare@suse.com>,
        Jonathan Corbet <corbet@lwn.net>,
        =?utf-8?Q?Joaqu=C3=ADn_Ignacio_Aramend=C3=ADa?= 
        <samsagax@gmail.com>, linux-hwmon@vger.kernel.org,
        linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hwmon: (oxp-sensors) Add AYANEO AIR and AIR Pro
Message-ID: <Y5lBue87IXkhNs42@debian.me>
References: <20221213225511.77442-1-derekjohn.clark@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="RgS/zDzB4VTPWHzp"
Content-Disposition: inline
In-Reply-To: <20221213225511.77442-1-derekjohn.clark@gmail.com>
Precedence: bulk


--RgS/zDzB4VTPWHzp
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 13, 2022 at 02:55:11PM -0800, Derek J. Clark wrote:
> Adds support for the AYANEO AIR and AYANEO AIR Pro models of handheld
s/Adds/Add/
> devices. These devices use the same EC registers and logic as the One X
> Player mini AMD. Previous AYANEO models are not supported as they use a
> different EC and do not have the necessary fan speed write enable and
> setting registers. Tested on Aya Neo AIR. AIR Pro model EC functionality
"The driver is tested on ..., while ..."
> and DMI data were verified using command line tools by another user.
>=20
> The added devices are:
> - AYANEO AIR (AMD 5560U)
> - AYANEO AIR Pro (AMD 5560U)
> - AYANEO AIR Pro (AMD 5825U)
>=20
> Signed-off-by: Derek J. Clark <derekjohn.clark@gmail.com>
> ---
>  Documentation/hwmon/oxp-sensors.rst | 17 +++++----
>  MAINTAINERS                         |  6 ++++
>  drivers/hwmon/oxp-sensors.c         | 54 ++++++++++++++++++++++++-----
>  3 files changed, 63 insertions(+), 14 deletions(-)
>=20
> diff --git a/Documentation/hwmon/oxp-sensors.rst b/Documentation/hwmon/ox=
p-sensors.rst
> index 39c588ec5c50..b93892c892c5 100644
> --- a/Documentation/hwmon/oxp-sensors.rst
> +++ b/Documentation/hwmon/oxp-sensors.rst
> @@ -3,18 +3,21 @@
>  Kernel driver oxp-sensors
>  =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D
> =20
> -Author:
> +Authors:
> +    - Derek John Clark <derekjohn.clark@gmail.com>
>      - Joaqu=C3=ADn Ignacio Aramend=C3=ADa <samsagax@gmail.com>
> =20
>  Description:
>  ------------

Trim the trailing colon as it is not needed for section title.

> =20
> -One X Player devices from One Netbook provide fan readings and fan contr=
ol
> -through its Embedded Controller.
> +Handheld devices from One Netbook and Aya Neo provide fan readings and f=
an
> +control through their Embedded Controllers.

s/Embedded Controllers/embedded controllers/

> =20
> -Currently only supports AMD boards from the One X Player and AOK ZOE lin=
eup.
> -Intel boards could be supported if we could figure out the EC registers =
and
> -values to write to since the EC layout and model is different.
> +Currently only supports AMD boards from One X Player, AOK ZOE, and some =
Aya
> +Neo devices. One X PLayer Intel boards could be supported if we could fi=
gure
> +out the EC registers and values to write to since the EC layout and mode=
l is
> +different. Aya Neo devices preceding the AIR may not be usable as the EC=
 model
> +is different and do not appear to have manual control capabiltities.
> =20
>  Supported devices
>  -----------------
> @@ -22,6 +25,8 @@ Supported devices
>  Currently the driver supports the following handhelds:
> =20
>   - AOK ZOE A1
> + - Aya Neo AIR
> + - Aya Neo AIR Pro
>   - OneXPlayer AMD
>   - OneXPlayer mini AMD
>   - OneXPlayer mini AMD PRO

Otherwise LGTM, thanks.

--=20
An old man doll... just what I always wanted! - Clara

--RgS/zDzB4VTPWHzp
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQSSYQ6Cy7oyFNCHrUH2uYlJVVFOowUCY5lBtAAKCRD2uYlJVVFO
o7LuAP41lOEEBtUdIbqsqp8XNq1N4hXdExfsPLKTJStBNtt3twD/WD3IPJAKdmNM
butxrHEN/axvjVAhMzPAWXAp9pSnSAY=
=cHGG
-----END PGP SIGNATURE-----

--RgS/zDzB4VTPWHzp--