Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c5be4dd3-824b-9ad0-29c4-d2f4c9149c34@intel.com>
Date:   Wed, 14 Dec 2022 12:30:32 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.5.1
Subject: Re: [PATCH v3] PCI/portdrv: Allow AER service only for Root Ports &
 RCECs
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>
CC:     Sathyanarayanan Kuppuswamy 
        <sathyanarayanan.kuppuswamy@linux.intel.com>,
        <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Bjorn Helgaas <bhelgaas@google.com>
References: <20221210002922.1749403-1-helgaas@kernel.org>
Content-Language: en-US
From:   "Gupta, Anshuman" <anshuman.gupta@intel.com>
In-Reply-To: <20221210002922.1749403-1-helgaas@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlZSVkZvTyt2MGlBeStiR1VnKzhjWC9vSnN1QzBUV1RJdjZkR1orZTczY05o?=
 =?utf-8?B?Ujh5dmNkWWFrajNmejVlMzlPbWF6cFlUZmZiUXlkYkJlK1Q1V0E0Vm52K0Rq?=
 =?utf-8?B?M3Qra0lPZ2ZtNStVTFZCTTNSTWhmSTY2NDlmcmdCeitFcWtJWnJXVTBxaVNz?=
 =?utf-8?B?UXpDR0JNNXI2Z1FVWE41TExFK08yUHlVTkE5WS8wRzFoVi9Ubjkyek9JMDZG?=
 =?utf-8?B?UGFKZlNXTzRGZWNCYS9NdHNGby9xYm1qb0FRR3pzc2RhNDROTUh0bXdzTGhH?=
 =?utf-8?B?NzMrd0d4ZW1ka3JuS3VQVWdYbUViMGNLVytXaytmUTlxMGFXMkxZRUJOWTBm?=
 =?utf-8?B?OThRelU1OVNrRE5tdUJ4YmtQQmNmY0RvOHFnZnZkemtEckRzdno1bWloWXF5?=
 =?utf-8?B?ekU4TjM2WERzcVprS3Rudk5RVm5wMjNTbEcxekJ0QzRoMlBueXN3eUVXM0Zm?=
 =?utf-8?B?dlE4UktOVDIxT0tQT0ZreDIxRXpacWJTMlNCZDBhTVB0QXgwbFFSNDRFdE0x?=
 =?utf-8?B?K3g4bG5yaE1PajJnQVRTcWNkcUR6SXNZVlpWblluQ3cyaXpDQ0FNck50YUZi?=
 =?utf-8?B?dmRrWHFRcDZKSi82eG85ZldUMldQYWQ2RlpsWGZ4V1U1K3RwZGJualhEcHlV?=
 =?utf-8?B?SlEyd09LeDVJVFU5QWVVOWpOVFZscDdmZ1ZCbi85eTUrZjlMN2dvWDJvT3ND?=
 =?utf-8?B?aGpydXhnUHB3V2ZUb0N1VXQ3VXNJTDVRR3VqTHlYRXFsQTBWb0J4TUk1TVlX?=
 =?utf-8?B?YVQxVnkyelc0TGtxZFhXQUY5dXZDZllsYWUvR2F3OHhTM3NvTXM4c2E4RUdm?=
 =?utf-8?B?ekZMaWhWRHpGL0xmWWppSHJzZDN6aU1EeE0vVHdvS0d1Uk1uNlpvYkRzMmJx?=
 =?utf-8?B?dHVOVDgzbG9DQzg2bW9UZlEzUVhzRDRVWEpYOWcrMFMxS2paMHRqd2R3NXEz?=
 =?utf-8?B?NkFObmZGZFE4eHk5TDNrRnFCNHpNeWFXTWsxZUx2NEZuZ2RKT0FGc1hmcms5?=
 =?utf-8?B?OVdYa2pYSjVDQ3hwdjVTKzc1amsvNkkzUG5aM1gzY0x0b3REOHZwWEYxMS9H?=
 =?utf-8?B?aTh4aGVybTJaZyt2NWJYYk9oaUdpOTlpMDRWU2dXdGlUMlREUEFHd1NXSzZ2?=
 =?utf-8?B?aDdoV3FYcE1YRkt4TncrT2NMMzF3emlGaDJva1YyTzYyQkg0aVVhOVdMbkhH?=
 =?utf-8?B?YTFjaUVXeFFXMkNOUG9FMDJNWGJ2akh2R0RFajZKSW1PaHA2Tk9HblRaQ1Rt?=
 =?utf-8?B?aGd6WWlyKzh6Q0sreXIyYUJQN01KcE53TWViRTNsNnlPdTFmZDEvem42TzVx?=
 =?utf-8?B?Vm81ZHoybDN3dlErT3AzNlZGRUlmZWYzVlA3Wm0waURhVHlVQnUxNkIzMENt?=
 =?utf-8?B?RlBHUVdhdVZYa3FxMUtNbFJmZXlhQVhsMnQwR0IvM0ZuaGM5dk1MRTJkTjd0?=
 =?utf-8?B?Z0liUVN4RlBSS1dDMGZyOHIvZVQ3MGRCWmJ1ai9SeUU5VlpTckI4WWpHSUdO?=
 =?utf-8?B?cGE2Vk5OKytmUDY0c0RkVWZLa1AyYmY0QmRXZTBjVWhOMkFWZ0xRQ3ZSWDRN?=
 =?utf-8?B?R2xQbFozenhNSEpyY2E5VlV0UXlIb1B2eXIxZGVqOWlSNTRBanlXUXhiRWFx?=
 =?utf-8?B?YU9tNWdGZ0kxWUtPQkdmMVJ1WXQ4WE4zZlQrSGpDN0xwVGF2Q01qcTBWTUtr?=
 =?utf-8?B?OTNCUkJlVjN5OWVsbnpCd0ZOd1J6MzhuLzA4RTVhWG1QUno0QlV3NXloa1hl?=
 =?utf-8?B?LzROSVRLc000WTVEY2QvMktISkNzaVlBNEN6TXcvNWdTaXZrd0ZZQXF4N1lm?=
 =?utf-8?B?SDZFdDV1WEZkSmtyRmgraGU0QWpJMkFCdGRYUlhKdkRDMGJ5T1NONFU3K1pX?=
 =?utf-8?B?anVDQ2F3UEpjcG43YklLVS9EMTRia3pwRll1bGxKL3BXQkQ5Y0hadm42Snhm?=
 =?utf-8?B?M3czendhMnBYajMyb1BmZHh3QXRwVXVWclhldEtXbGdlSnZaNHhURGdVUnZM?=
 =?utf-8?B?aTFLeGJWcExkTmZBODJhTjF2M3pFQUZzZGdtZ1hoZU53ZHVLRU9EaXJnbEtS?=
 =?utf-8?B?c2t4RUk4eVFvWkc1YUhvWW84dWJxN0M3enR2cjRLUTVkSTBkNjYrbzdkaEVW?=
 =?utf-8?B?L1BCYUNPMHlsTlJaeXl4bjlVQUZzTWpCU1Q4dmVmK1hFZXNLekM1TTRCai9x?=
 =?utf-8?B?cmc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a828b1a-0bcb-40f4-22d6-08dadda0ea55
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6211.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 07:00:43.7310
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KgxezoAG6oxvXV7Vf3KmUhS1EIb9llJbrBeeDbBcENefxZlyzHijy6ufBSv4SdqT4RG4LkKsSXRTQ+jK21dVOD95Qx7lhVW+Y5ZLa69n1GY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB4876
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 12/10/2022 5:59 AM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <bhelgaas@google.com>
> 
> Previously portdrv allowed the AER service for any device with an AER
> capability (assuming Linux had control of AER) even though the AER service
> driver only attaches to Root Port and RCECs.
> 
> Because get_port_device_capability() included AER for non-RP, non-RCEC
> devices, we tried to initialize the AER IRQ even though these devices
> don't generate AER interrupts.
> 
> Intel DG1 and DG2 discrete graphics cards contain a switch leading to a
> GPU.  The switch supports AER but not MSI, so initializing an AER IRQ
> failed, and portdrv failed to claim the switch port at all.  The GPU itself
> could be suspended, but the switch could not be put in a low-power state
> because it had no driver.
Tested with Intel DG2 Card, virtual switch ports bind with pcieport 
driver and enters to lower power state.
Tested-by: Anshuman Gupta <anshuman.gupta@intel.com>

> 
> Don't allow the AER service on non-Root Port, non-Root Complex Event
> Collector devices.  This means we won't enable Bus Mastering if the device
> doesn't require MSI, the AER service will not appear in sysfs, and the AER
> service driver will not bind to the device.
> 
> Link: https://lore.kernel.org/r/20221207084105.84947-1-mika.westerberg@linux.intel.com
> Based-on-patch-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> ---
> 
> This is a v3 based on Mika's patch at
> https://lore.kernel.org/r/20221207084105.84947-1-mika.westerberg@linux.intel.com
> 
> I wouldn't normally kibbitz like this, but I'm hoping to squeeze this into
> the v6.2 merge window.
> 
> Changes from v2:
> 
>    * Test the device type in get_port_device_capability() instead of
>      pcie_init_service_irqs().  The benefits are to keep the device type
>      checking together (this is similar to the PME test), avoid enabling Bus
>      Mastering unnecessarily, avoid exposing the portdrv AER service in
>      sysfs, and preventing the AER service driver from binding to devices it
>      doesn't need to.
> 
>   drivers/pci/pcie/portdrv.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pcie/portdrv.c b/drivers/pci/pcie/portdrv.c
> index a6c4225505d5..8b16e96ec15c 100644
> --- a/drivers/pci/pcie/portdrv.c
> +++ b/drivers/pci/pcie/portdrv.c
> @@ -232,7 +232,9 @@ static int get_port_device_capability(struct pci_dev *dev)
>   	}
>   
>   #ifdef CONFIG_PCIEAER
> -	if (dev->aer_cap && pci_aer_available() &&
> +	if ((pci_pcie_type(dev) == PCI_EXP_TYPE_ROOT_PORT ||
> +             pci_pcie_type(dev) == PCI_EXP_TYPE_RC_EC) &&
> +	    dev->aer_cap && pci_aer_available() &&
>   	    (pcie_ports_native || host->native_aer))
>   		services |= PCIE_PORT_SERVICE_AER;
>   #endif