Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp681279rwb; Wed, 14 Dec 2022 01:09:24 -0800 (PST) X-Google-Smtp-Source: AA0mqf7aSgOc9jYLs81W769XXQN9rtZoUqQENBMJmL7yu6WM3PVSbcDmhSrnFxn3xCxIgTdOTbjM X-Received: by 2002:a17:907:bd8:b0:7c1:706:d5bb with SMTP id ez24-20020a1709070bd800b007c10706d5bbmr22348894ejc.12.1671008964594; Wed, 14 Dec 2022 01:09:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671008964; cv=none; d=google.com; s=arc-20160816; b=rAC6glSaa65AxGXnvVIRWuujrT7RG4ObQGTfuK1tGpOJutQmUNa3ue83FamawiXZX2 Z7l9P5nqHah5ZCDNfyb7Ml6JhnHDNyVhQFMn3gM7p4RSoSYAHAJxA0CEytk3ZSwEgCgI Dv2gTU+1LcKWLXbhvvf0p7BCX9a7Truky1hdQ6tX0JJ2DM7qBVwem4i9N+UJF1/X/feM 01HnBtTLQr7z6HgLOtZUFYKbyQZXV0030M4/9JIEQwsGxGG+zK+tEZX2fUE7/hp71hcm HbDV4eLAuole8qaFp6a2bXH8digOjMssuWs0WXlJnDScd7jJsynYjjJH2DclYucgVN2c lKvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=ho4X8dDE+ta6/Kob/pY05oWmfJ4YX9vd2DewOO7u4b0=; b=rllORy3xGn3gNBfDjFUcrgh1iCQLkwBEDd3Lrw8PSfS2CK/AXuiMc7uWsgw62EI6jx 9FS58vsbUMv9/zvRmJMuBl90tupygm8jhcGoqPCFWtg3A8LVS1FgN59XM7CU62/wbfBt QZbwm2zFdFv/OTBg+NgZalcam2FaH66DU2FJiewh+Uo6uOJuCt7VAZ5WI+ZX83Wg2UJI lTxnsj+JIc/XWZIkRk+iolQYdDpNKgIMFpct0XH6Nr8bHImAhA+Xq54+QvaTPz/cH9VP A5PEXZwNQp6xPAMLLTGhRL/WG3qwpXey5NrcWnynHUhlKZdjc3d4v1IJZjwNKxwqNw3r 1qOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0H3gnYRx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w19-20020a50d793000000b0046c0e8b6cadsi3153532edi.450.2022.12.14.01.09.07; Wed, 14 Dec 2022 01:09:24 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=0H3gnYRx; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237805AbiLNItE (ORCPT + 70 others); Wed, 14 Dec 2022 03:49:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54914 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237787AbiLNItC (ORCPT ); Wed, 14 Dec 2022 03:49:02 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEBF319014; Wed, 14 Dec 2022 00:49:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6CB81B81103; Wed, 14 Dec 2022 08:49:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AC2A1C433D2; Wed, 14 Dec 2022 08:48:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671007739; bh=QSGvunYcJRNVyeLLqbAWJmdEG4zavxjUnpwOdm3ncP8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0H3gnYRxDaESjD8B7CSzc17LY3CLOnpwoT3yn9Q9hfz6SBPucXG9MTWOuJZBEhgx1 WMfwkbRFYcyIKRWoECvvq0VAkCm/Q8I7Ynj7eoa0d0lUbRmWYXwNVIj4NbkhnvKxYd FbRf0ebQiRQjfazSoAcYG+IWvSc3/kHJ50492SQ4= Date: Wed, 14 Dec 2022 09:48:56 +0100 From: Greg KH To: Puma Hsu Cc: mka@chromium.org, dianders@chromium.org, albertccwang@google.com, raychi@google.com, howardyen@google.com, leejj@google.com, hch@infradead.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] add hooks for usb suspend and resume Message-ID: References: <20221214081456.714859-1-pumahsu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221214081456.714859-1-pumahsu@google.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2022 at 04:14:54PM +0800, Puma Hsu wrote: > In mobile, a co-processor can be used for USB audio. When the co-processor > is working for USB audio, the co-processor is the user/owner of the USB > driver, and the ACPU is able to sleep in such condition to improve power > consumption. In order to support this, we need to create hooks in suspend > and resume functions. We also upload our implementations for reviewing. > > Puma Hsu (2): > usb: core: add hooks for usb suspend and resume > usb: core: add implementations for usb suspend/resume hooks > > drivers/usb/core/driver.c | 36 +++++++++++++ > drivers/usb/core/usb-hooks-impl-goog.c | 72 ++++++++++++++++++++++++++ > drivers/usb/core/usb.h | 5 ++ > 3 files changed, 113 insertions(+) > create mode 100644 drivers/usb/core/usb-hooks-impl-goog.c > > --- > Changes in v2: > - Remove the wrong input in the Makefile > - Change description in commit message > > -- > 2.39.0.rc1.256.g54fd8350bd-goog > My review comments on v1 still pertain here.