Message-ID: <387168935.12266@ustc.edu.cn>
Date: Wed, 15 Aug 2007 17:08:55 +0800
From: Fengguang Wu <wfg@mail.ustc.edu.cn>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
       linux-kernel <linux-kernel@vger.kernel.org>,
       Al Viro <viro@ftp.linux.org.uk>
Subject: Re: [PATCH] seqfile: fix uninitialized memory allocation in
	mounts_open()
Message-ID: <20070815090855.GB19293@mail.ustc.edu.cn>
References: <387168197.02674@ustc.edu.cn> <b6fcc0a0708150204k16997328s9ff723b2a809be@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b6fcc0a0708150204k16997328s9ff723b2a809be@mail.gmail.com>
User-Agent: Mutt/1.5.16 (2007-06-11)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 940
Lines: 26

On Wed, Aug 15, 2007 at 01:04:05PM +0400, Alexey Dobriyan wrote:
> On 8/15/07, Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:
> > proc_mounts.m.buf is not explicitly zeroed at allocation time, which
> > may later confuse the seqfile code and triggle an kfree(m->buf).
> 
> It's cleared in seq_open().

So it is :)

> > --- linux.orig/fs/proc/base.c
> > +++ linux/fs/proc/base.c
> > @@ -380,7 +380,7 @@ static int mounts_open(struct inode *ino
> >
> >  	if (ns) {
> >  		ret = -ENOMEM;
> > -		p = kmalloc(sizeof(struct proc_mounts), GFP_KERNEL);
> > +		p = kzalloc(sizeof(struct proc_mounts), GFP_KERNEL);
> >  		if (p) {
> >  			file->private_data = &p->m;
> >  			ret = seq_open(file, &mounts_op);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/