Received: by 2002:a05:6358:d09b:b0:dc:cd0c:909e with SMTP id jc27csp685343rwb; Wed, 14 Dec 2022 01:13:04 -0800 (PST) X-Google-Smtp-Source: AA0mqf4PrTp9gCODc95efTatNa3BOiEee7KXnhxiilnQybUpnuRgbVNmTv8Pb4AkAGitTE0+SYN1 X-Received: by 2002:a17:903:515:b0:189:ec2d:89c0 with SMTP id jn21-20020a170903051500b00189ec2d89c0mr24864547plb.59.1671009184048; Wed, 14 Dec 2022 01:13:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1671009184; cv=none; d=google.com; s=arc-20160816; b=hAlXMVOn5TUYxQ/DOirq82NJ5ISxNltDzoqKDsTafnk8SwdIHN6+e6iZh/RNUqFtgb eejrcQXY7eBsXqh74VchQ1YE834xl6PTYuo83BUpyQam13OIKUFFfXpd7RrnBVnK2cRe K0KNAXm2zowHVx9NqGQc9q8u10jsr/0wpDPLI6TiVWxhcB0XsrWPqca5ks6nDz13ui3L f9+D+3cYIx1KsqhmEDbZZCY9syeBE3ddKc/trfdV/P+nNYoC7q21GA1uE3Afq1v6B0// zPBWkxVryEtaZw6dAzRubG14ijsy2fpHKn83otvUKT0Vf9GwW94qO4fVNdpQvbSnnGaF 2A1A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=3lFPyxTf8o4Q7EWsj8Fal7zOverz9M4aKJmwqwbqEkI=; b=ETRNUNrege2yycocU21C2BI4qeQatgp0ttbGd1XA7+SB3WPVTZVzXVH6wMKyNKGFKD UmWDNnwEJBQffYoBmCXxk7vEAkgA1+prBG94Y5RZ5N09QeDpqNHeEk2ew5cfC/fe2via GVOSSG+0qjpYMehqiZvi73LF3ZJW0M9SUFhuHw8JdZ3E92dtlQB4cjbKK3sRmsoY84Uj JriAoMVxxbQif6/J+FdstFGHao7ZRio/zk+4LPcn/eFHzlFWpYlBCOpW9Ar+8yTMeuFI OREXwuApFGo+YUaHcnzZHB8oOsQ8TQtb1wHrJ/CwA/+UcXf9YlpeYU5R+HviCeI0MwBf J53w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=g7eSMWGF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z1-20020a1709027e8100b00183f6ff535dsi2142013pla.490.2022.12.14.01.12.54; Wed, 14 Dec 2022 01:13:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=g7eSMWGF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229662AbiLNIVe (ORCPT + 70 others); Wed, 14 Dec 2022 03:21:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237541AbiLNIV3 (ORCPT ); Wed, 14 Dec 2022 03:21:29 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E8F6E09; Wed, 14 Dec 2022 00:21:27 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 20615B816AC; Wed, 14 Dec 2022 08:21:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6DEA9C433EF; Wed, 14 Dec 2022 08:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1671006084; bh=AelTatIhVmzfRgJaI2rAkm+beB1sdjhm/gXAN7z25WM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g7eSMWGFGJ4lC5sncueD30uDdxKUjsMFOygKjkJRfnQ0PLIRtEF/2ts14hasQlDNj ogftZ2XP03wRuG6WUksnfnQi6bSIqXha+0bYOY5gF6RuapWfkmXj3PoVCGVU7ga1YV RlXGvlIFNLIX5JhwBFyYOmlA8sitiHVKN2iEvqi0= Date: Wed, 14 Dec 2022 09:21:21 +0100 From: Greg KH To: Puma Hsu Cc: mka@chromium.org, dianders@chromium.org, albertccwang@google.com, raychi@google.com, howardyen@google.com, leejj@google.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] usb: core: add implementations for usb suspend/resume hooks Message-ID: References: <20221214070650.703793-1-pumahsu@google.com> <20221214070650.703793-3-pumahsu@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221214070650.703793-3-pumahsu@google.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 14, 2022 at 03:06:50PM +0800, Puma Hsu wrote: > + /* > + * Note: Our private driver provides APIs to know the device is in audio playback > + * or capture. > + * > + * usb_playback = usb_audio_playback_enabled(); > + * usb_capture = usb_audio_capture_enabled(); > + */ There is no such thing as a "private driver" in Linux, sorry, you know this. Submit the real code please, otherwise this is just wasting everyone's time :( greg k-h