Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 10:18:20 +0100
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Markus Schneider-Pargmann <msp@baylibre.com>
Cc:     Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
        Wolfgang Grandegger <wg@grandegger.com>,
        linux-can@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH 02/15] can: m_can: Wakeup net queue once tx was issued
Message-ID: <20221214091820.geugui5ws3f7a5ng@pengutronix.de>
References: <20221116205308.2996556-1-msp@baylibre.com>
 <20221116205308.2996556-3-msp@baylibre.com>
 <20221130172100.ef4xn6j6kzrymdyn@pengutronix.de>
 <20221214091406.g6vim5hvlkm34naf@blmsp>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cmhdhkp6pjy3b5ee"
Content-Disposition: inline
In-Reply-To: <20221214091406.g6vim5hvlkm34naf@blmsp>
Precedence: bulk


--cmhdhkp6pjy3b5ee
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On 14.12.2022 10:14:06, Markus Schneider-Pargmann wrote:
> Hi Marc,
>=20
> On Wed, Nov 30, 2022 at 06:21:00PM +0100, Marc Kleine-Budde wrote:
> > On 16.11.2022 21:52:55, Markus Schneider-Pargmann wrote:
> > > Currently the driver waits to wakeup the queue until the interrupt for
> > > the transmit event is received and acknowledged. If we want to use the
> > > hardware FIFO, this is too late.
> > >=20
> > > Instead release the queue as soon as the transmit was transferred into
> > > the hardware FIFO. We are then ready for the next transmit to be
> > > transferred.
> >=20
> > If you want to really speed up the TX path, remove the worker and use
> > the spi_async() API from the xmit callback, see mcp251xfd_start_xmit().
> >=20
> > Extra bonus if you implement xmit_more() and transfer more than 1 skb
> > per SPI transfer.
>=20
> Just a quick question here, I mplemented a xmit_more() call and I am
> testing it right now, but it always returns false even under high
> pressure. The device has a txqueuelen set to 1000. Do I need to turn
> some other knob for this to work?

AFAIK you need BQL support: see 0084e298acfe ("can: mcp251xfd: add BQL supp=
ort").

The etas_es58x driver implements xmit_more(), I added the Author Vincent
on Cc.

Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--cmhdhkp6pjy3b5ee
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmOZlNgACgkQrX5LkNig
013EJwf/fUw4P4ApLkDodlL0ugrtogINg9KvZjtNjbtlVqam59pHJ3CAvrTLxRNg
KFBKLhZhjjEC8APOurmGbaIYSWolFIuGHKYozu2zytKqV2kiPiLtYGMxSpK7uNUk
rYJoy6obID+1aNLXKzu+5aLsByBBThFpz2+qf5UW4lIWBFLZeR2QyE8XPFLe4Mu1
iZ4s88rIfMb3rcqqMvVXVLQcC/U+RtWV3dNkVhUQYu99Jp37Vr99yEQP+LTHpP49
nRqjSD8iAqxQWMnP4EP0z1Yh9FtHZ6h8qQ2XmKa5O9iP1+hYedIrZgAJgPnUMHpr
a/3M0YvLKgETGgynY4wSP8R0g8eocA==
=VMKy
-----END PGP SIGNATURE-----

--cmhdhkp6pjy3b5ee--