Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Valentin Schneider <vschneid@redhat.com>
To:     Yair Podemsky <ypodemsk@redhat.com>, peterz@infradead.org,
        mingo@redhat.com, juri.lelli@redhat.com,
        vincent.guittot@linaro.org, dietmar.eggemann@arm.com,
        rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de,
        bristot@redhat.com, rafael.j.wysocki@intel.com,
        ggherdovich@suse.cz, jlelli@redhat.com, mtosatti@redhat.com,
        nsaenz@kernel.org, linux-kernel@vger.kernel.org
Cc:     ypodemsk@redhat.com
Subject: Re: [PATCH] sched/core: Fix arch_scale_freq_tick() on tickless systems
In-Reply-To: <20221130125121.34407-1-ypodemsk@redhat.com>
References: <20221130125121.34407-1-ypodemsk@redhat.com>
Date:   Wed, 14 Dec 2022 09:49:45 +0000
Message-ID: <xhsmhzgbq5n7q.mognet@vschneid.remote.csb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 30/11/22 14:51, Yair Podemsky wrote:
> In order for the scheduler to be frequency invariant we measure the
> ratio between the maximum cpu frequency and the actual cpu frequency.
> During long tickless periods of time the calculations that keep track
> of that might overflow, in the function scale_freq_tick():
>
> if (check_shl_overflow(acnt, 2*SCHED_CAPACITY_SHIFT, &acnt))
> =C2=BB       goto error;
>
> eventually forcing the kernel to disable the feature for all cpus,
> and show the warning message
> "Scheduler frequency invariance went wobbly, disabling!".
> Let's avoid that by limiting the frequency invariant calculations
> to cpus with regular tick.
>
> Fixes: e2b0d619b400 ("x86, sched: check for counters overflow in frequenc=
y invariant accounting")
> Signed-off-by: Yair Podemsky <ypodemsk@redhat.com>
> Suggested-by: "Peter Zijlstra (Intel)" <peterz@infradead.org>

Reviewed-by: Valentin Schneider <vschneid@redhat.com>

> ---
> V1 -> V2: solution approach was changed from detecting long tickless peri=
ods
> to frequency invariant measurements on housekeeping cpus only.
> Link: ee89073a1e9de11c7bd7726eb5da71a0e8795099.camel@redhat.com
> ---
>  kernel/sched/core.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index daff72f00385..1bb0a840c817 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -5469,7 +5469,9 @@ void scheduler_tick(void)
>       unsigned long thermal_pressure;
>       u64 resched_latency;
>
> -	arch_scale_freq_tick();
> +	if (housekeeping_cpu(cpu, HK_TYPE_TICK))
> +		arch_scale_freq_tick();
> +
>       sched_clock_tick();
>
>       rq_lock(rq, &rf);
> --
> 2.31.1