Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH v7] igb: Assign random MAC address instead of fail in case
 of invalid one
From:   =?utf-8?B?5qKB56S85a2m?= <lianglixuehao@126.com>
In-Reply-To: <Y5l5pUKBW9DvHJAW@unreal>
Date:   Wed, 14 Dec 2022 18:02:53 +0800
Cc:     Tony Nguyen <anthony.l.nguyen@intel.com>,
        Jakub Kicinski <kuba@kernel.org>, linux-kernel@vger.kernel.org,
        Jesse Brandeburg <jesse.brandeburg@intel.com>,
        David Miller <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Netdev <netdev@vger.kernel.org>,
        kernel test robot <lkp@intel.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <216119AA-C362-445D-9F04-47AC2A15EC11@126.com>
References: <20221213074726.51756-1-lianglixuehao@126.com>
 <Y5l5pUKBW9DvHJAW@unreal>
To:     Leon Romanovsky <leon@kernel.org>
Precedence: bulk

hi Leon,

Currently this module parameter is only used for igb.
Is the more user-friendly way not to use module parameters?
just like other network card drivers, use random MAC.=20
As I submitted [patch v3] before, link:=20
=
https://lore.kernel.org/netdev/20220530105834.97175-1-lianglixuehao@126.co=
m/

Or, can you suggest me how to do it more reasonable?

Thanks

> 2022=E5=B9=B412=E6=9C=8814=E6=97=A5 15:22=EF=BC=8CLeon Romanovsky =
<leon@kernel.org> =E5=86=99=E9=81=93=EF=BC=9A
>=20
> On Tue, Dec 13, 2022 at 07:47:26AM +0000, Lixue Liang wrote:
>> From: Lixue Liang <lianglixue@greatwall.com.cn>
>>=20
>> Add the module parameter "allow_invalid_mac_address" to control the
>> behavior. When set to true, a random MAC address is assigned, and the
>> driver can be loaded, allowing the user to correct the invalid MAC =
address.
>>=20
>> Signed-off-by: Lixue Liang <lianglixue@greatwall.com.cn>
>=20
>=20
> I'm amused that we are in v7 version of module parameter.
>=20
> NAK to any module driver parameter. If it is applicable to all =
drivers,
> please find a way to configure it to more user-friendly. If it is not,
> try to do the same as other drivers do.
>=20
> Thanks