Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   David Laight <David.Laight@ACULAB.COM>
To:     'Nicolas Schier' <nicolas@fjasle.eu>,
        Nathan Chancellor <nathan@kernel.org>
CC:     Masahiro Yamada <masahiroy@kernel.org>,
        "linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Nick Desaulniers <ndesaulniers@google.com>
Subject: RE: [PATCH] kbuild: ensure Make >= 3.82 is used
Thread-Topic: [PATCH] kbuild: ensure Make >= 3.82 is used
Thread-Index: AQHZDqgK2HakTLHXy0uTd8KCKGQlc65tOHlQ
Date:   Wed, 14 Dec 2022 11:05:10 +0000
Message-ID: <6c4413040a624b728081e27213fb46a1@AcuMS.aculab.com>
References: <20221211030352.2622425-1-masahiroy@kernel.org>
 <Y5djBr9rVhSq8+iK@dev-arch.thelio-3990X> <Y5f4ZgyK7QlqYu31@bergen.fjasle.eu>
In-Reply-To: <Y5f4ZgyK7QlqYu31@bergen.fjasle.eu>
Accept-Language: en-GB, en-US
MIME-Version: 1.0
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Precedence: bulk

From: Nicolas Schier
> Sent: 13 December 2022 03:59
...
> > > diff --git a/Makefile b/Makefile
> > > index 2dda1e9a717a..66dfc5751470 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -11,6 +11,11 @@ NAME = Hurr durr I'ma ninja sloth
> > >  # Comments in this file are targeted only to the developer, do not
> > >  # expect to learn how to build the kernel reading this file.
> > >
> > > +# Ensure Make >= 3.82

Wouldn't it be better to say either:
	# Ensure gmake supports 'undefine' (added in 3.82)
or:
	# Building with gmake versions prior to 3.82 fails due to
	# bug 'brief description'.
	# Check for 'undefine' support as a surrogate for the bug fix.

    David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)