Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <84f04d12-087c-99f1-f30a-9e35f65e9ec1@quicinc.com>
Date:   Wed, 14 Dec 2022 17:26:36 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: [PATCH 2/4] dt-bindings: remoteproc: qcom: sc7180: Update
 memory-region requirements
Content-Language: en-US
To:     Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
        <robh+dt@kernel.org>, <manivannan.sadhasivam@linaro.org>
CC:     <agross@kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <konrad.dybcio@somainline.org>, <amit.pundir@linaro.org>,
        <regressions@leemhuis.info>, <sumit.semwal@linaro.org>,
        <will@kernel.org>, <catalin.marinas@arm.com>,
        <robin.murphy@arm.com>
References: <20221213140724.8612-1-quic_sibis@quicinc.com>
 <20221213140724.8612-3-quic_sibis@quicinc.com>
 <612c1019-11c0-38b6-e1d5-1a52f1456989@linaro.org>
 <ea4e9a35-5468-820a-9e28-9cdf129b77e5@quicinc.com>
 <963cb30a-187a-57d1-65eb-34f9f8ed6315@linaro.org>
From:   Sibi Sankar <quic_sibis@quicinc.com>
In-Reply-To: <963cb30a-187a-57d1-65eb-34f9f8ed6315@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 12/14/22 17:00, Krzysztof Kozlowski wrote:
> On 14/12/2022 11:25, Sibi Sankar wrote:
>>
>>
>> On 12/14/22 01:11, Krzysztof Kozlowski wrote:
>>> On 13/12/2022 15:07, Sibi Sankar wrote:
>>>> Update the bindings to reflect the addition of the new modem metadata
>>>> carveout reference to the memory-region property.
>>>>
>>>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>>>> ---
>>>>    .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml    | 3 ++-
>>>>    .../devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml    | 3 ++-
>>>>    2 files changed, 4 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
>>>> index e4a7da8020f4..b1402bef0ebe 100644
>>>> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
>>>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml
>>>> @@ -95,6 +95,7 @@ properties:
>>>>        items:
>>>>          - description: MBA reserved region
>>>>          - description: modem reserved region
>>>> +      - description: metadata reserved region
>>>
>>> Which makes the third item now required, also for all out of tree DTS
>>> and other users of the bindings. Please write a bit more in commit msg
>>> why this is necessary (e.g. was it broken before?). I assume the driver
>>> does not break the ABI?
>>
>> I'll pad the commit msg with some of the additional info from patch 4.
>> commit c44094eee32f "arm64: dma: Drop cache invalidation from
>> arch_dma_prep_coherent()" exposed a bug in the driver affecting SoCs
>> from msm8996 on wards. The application processor accessing the
>> dynamically allocated region after giving control to the modem results
>> in a XPU violation. The recommended fix was to use a no-map carveout
>> instead and memunmap before giving control to the modem. The future
>> kernels that are paired with an older dtbs would crash during modem
> 
> Then it's an ABI break.
> 
>> bootup since we would continue to use dma_alloc_attr. But all the other
>> combinations (old kernel/new dtb) will continue to work.
> 
> Does it mean that old kernel with old DTB was working? If yes, then it's
> ABI break without clear benefits.

commit c44094eee32f is going to land regardless soon and will break
modem on mainline and any other branches that picks up the patch.
The suggested way to fix it (no-map carveout) requires this bindings
change.

> 
> Best regards,
> Krzysztof
>