Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 09:20:16 -0300
From:   =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado 
        <nfraprado@collabora.com>
To:     Shuah Khan <skhan@linuxfoundation.org>
Cc:     Mark Brown <broonie@kernel.org>, kernel@collabora.com,
        Jaroslav Kysela <perex@perex.cz>,
        Shuah Khan <shuah@kernel.org>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
        linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] kselftest/alsa: Increase kselftest timeout
Message-ID: <20221214122016.2geliu5k5n7fbo6r@notapiano>
References: <20221213183242.1908249-1-nfraprado@collabora.com>
 <2ee34e21-44bd-71e7-6da2-f4bea9a35452@linuxfoundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <2ee34e21-44bd-71e7-6da2-f4bea9a35452@linuxfoundation.org>
Precedence: bulk

On Tue, Dec 13, 2022 at 11:37:56AM -0700, Shuah Khan wrote:
> On 12/13/22 11:32, N?colas F. R. A. Prado wrote:
> > The default timeout for kselftests is 45 seconds, but pcm-test can take
> > longer than that to run depending on the number of PCMs present on a
> > device.
> > 
> > As a data point, running pcm-test on mt8192-asurada-spherion takes about
> > 1m15s.
> > 
> > Set the timeout to 10 minutes, which should give enough slack to run the
> > test even on devices with many PCMs.
> > 
> 
> 10 minutes is way too long.
> 
> > Signed-off-by: N?colas F. R. A. Prado <nfraprado@collabora.com>
> > 
> > ---
> > 
> >   tools/testing/selftests/alsa/settings | 1 +
> >   1 file changed, 1 insertion(+)
> >   create mode 100644 tools/testing/selftests/alsa/settings
> > 
> > diff --git a/tools/testing/selftests/alsa/settings b/tools/testing/selftests/alsa/settings
> > new file mode 100644
> > index 000000000000..a62d2fa1275c
> > --- /dev/null
> > +++ b/tools/testing/selftests/alsa/settings
> > @@ -0,0 +1 @@
> > +timeout=600
> 
> Adding timeouts like this especially 10 minutes will increase the time
> it takes to run tests. We run the risk of people not wanting to run tests
> anymore.

I set it high because I suspect the time it takes to run pcm-test might be a lot
higher in some machines (even on mt8192-asurada-spherion, it takes 1m15s, but
only ~10% of the tests are actually running, since many of the PCMs are
disabled).

But I can lower it to, say, 3 minutes, and we can increase the timeout as
needed.

Thanks,
N?colas