Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 14 Dec 2022 14:17:25 +0200
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     netdev@vger.kernel.org
Cc:     "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        linux-kernel@vger.kernel.org,
        Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Subject: Re: [PATCH net] net: enetc: avoid buffer leaks on xdp_do_redirect()
 failure
Message-ID: <20221214121725.g4ox7it4aeumde6x@skbuf>
References: <20221213001908.2347046-1-vladimir.oltean@nxp.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20221213001908.2347046-1-vladimir.oltean@nxp.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?4lLeGsoqwx/r04Mv21dqai9IvGchn3Gs40+Y420UZchvlQrRsVADeenTKY0Q?=
 =?us-ascii?Q?Pq392DCpH4lhpuGM1JvSYCLMj8sRPJvqC1qazv8sNkDHpy4w9PbNnEN2htz9?=
 =?us-ascii?Q?59MjtBjfpsWV/P0Q4N0rRB3GWQeNbOHyTAe2OEX1OvaiLezqSitazVAlwC9O?=
 =?us-ascii?Q?9bYw+wYkn55EyA7JmjpRs30SUj4mHzMzwurRJcEHrMePV+0tg+O2XRS3DRtk?=
 =?us-ascii?Q?TXMg25VHVolABuscxycmf6hd2krupi9+MmkMPKkSeboBVRbHmKmvYOkM3K4w?=
 =?us-ascii?Q?8KjcZ5LT+flb5tDQ+mZwxSL1/16HR7SGJYMeqfUs8SdlF3TEOC9/KN8D6Zzq?=
 =?us-ascii?Q?4qwHhFIK1ei9ji4cuHk/AswYnNm5NdlM4APF1neNFzSe8eskvaWhwyMhRLEO?=
 =?us-ascii?Q?f14l8L/m6MfM8v1nuCNHaHhkkTxHJ4HObiKl0zuKc64lqEV2EWlAnC5EXffp?=
 =?us-ascii?Q?5+M9+2ojUi4WH6w8NCzO3o0HSa/91CsyHPwS8ABmGBmNtPEpt8+EgQt6jXfb?=
 =?us-ascii?Q?pTxR+zcmm15XPnZbTsnNAkJH4FMcnvwAmfNX1CeUKjyHMPDsUgujCm/UcokK?=
 =?us-ascii?Q?5m/bLqoDg3UJFAMmPclHP49p5AJ3+bW2aIU0YOQYJVre38/HzZa/CquhYaFp?=
 =?us-ascii?Q?R34BIlcV3Laxa599nputSIB4QY4TRG2nXUD7VNx6zD41r6OjBAekxp7Od4l7?=
 =?us-ascii?Q?iHz6GBSpj9Y2titBYgsdztLh4a+OjZ+DC4sOU2ShNA88Is3AFGFxz3rJImJt?=
 =?us-ascii?Q?jaP+pzGLhpNQH35FxL4h2z5MT0fj6HqDNIEY1LuMG2a2LGvdJHlywYHk0nDw?=
 =?us-ascii?Q?MWiJBVhnesshjR1/dVm61hV4Ucc9vvTUsYQ4bbG6nE9d1zotczFyy9eedvXa?=
 =?us-ascii?Q?zKGzyGGGkWGUc2SNOYeLWj/3veXY4LDGb3DFCtGh/2rPFqGsUwnfxEdc0bIJ?=
 =?us-ascii?Q?s57uVScxgMn6vqP9b3tSJV8JePYVj3GbSelTJTqiKxkyQCe8koXVTL0n3ZmT?=
 =?us-ascii?Q?vKh6R9mt41jNMZidZSWeiIfexJ6XQVVxjNFBZYyPel5Bvv3tcSVlDCHzE87Y?=
 =?us-ascii?Q?w0RQe4kNw4mul/527L83OPvTv4D+6rvg5MqXw0Dth3PpFbrlJoEnPDd5tODv?=
 =?us-ascii?Q?sEnTFN1qYjEnC1rkzgO18dJ+1wsDFsrNkbeARg9+Oci6lhCROnq3MLWwrFOy?=
 =?us-ascii?Q?y/9airxSPSEZew2PAcUNyy49m7vamE8MY33TTXkxVFE3UpQAebcklODrilVB?=
 =?us-ascii?Q?WJIUQiy+4zqrA4ZTX2l5FvJtgr2YOgPnNzosmrbdTo3n1cbsorvfVyJpgDru?=
 =?us-ascii?Q?YnUIE8ICl6srnu/FfRueNOC76aLWSI3bHAkj5gOIN+JMkDseVEdqUNFLHrLL?=
 =?us-ascii?Q?QviemkkkjPIl9OhLZ8P/c0WmDNQl9GepITftRxfJHE6OdZWNjV8y6e+2zbmJ?=
 =?us-ascii?Q?5/jE8PnjpckhxTzx7CjnwdjLUq7McMMk7qP6u83QuxfXuzowWPoZht9EXaYg?=
 =?us-ascii?Q?IGjY/Gbl+hOmwtp017DTiLP3N/afUCAh7yDiE9w1/xqbBsh0xrD8pG2LsXnQ?=
 =?us-ascii?Q?kwjuEE3KqcQve42ttDKeiqTJeMcA2Ax0X87LmouCGf5nnIhxJ/9Nod1hMy2u?=
 =?us-ascii?Q?yQ=3D=3D?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3e14e914-f0b2-4dcb-1699-08daddcd2acb
X-MS-Exchange-CrossTenant-AuthSource: VI1PR04MB5136.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Dec 2022 12:17:28.9989
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TlM/XyeoW+DS4qsp4lWbjbwn3X2TCmmKjquLtp1qkNlq5rzl24XBOd2kcs8j3ObProqpU3oep2QUatSxsuJ7bA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9346
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 13, 2022 at 02:19:08AM +0200, Vladimir Oltean wrote:
> The problem, summarized, is that we zeroize rx_swbd->page before we're
> completely done with it, and this makes it impossible for the error path
> to do something with it.
> ---

I was pretty tired when I wrote this commit message, please let me know
if it rambles too much or it misses the point, I can rewrite it and
shorten it if needed.